| Message ID | 1484229217-23364-4-git-send-email-akdwived@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu 12 Jan 05:53 PST 2017, Avaneesh Kumar Dwivedi wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 9d1d7ad..2457b20 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -541,5 +541,29 @@ > #interrupt-cells = <2>; > }; > }; > + > + smp2p-slpi { > + compatible = "qcom,smp2p"; > + qcom,smem = <481>, <430>; > + > + interrupts = <0 178 1>; Please use <GIC_SPI 178 IRQ_TYPE_EDGE_RISING>; > + > + qcom,ipc = <&apcs 4 8>; Looking at qcom,smp2p-dsps downstream I get this to <&apcs 16 26>; > + > + qcom,local-pid = <0>; > + qcom,remote-pid = <3>; > + > + slpi_smp2p_in: slave-kernel { > + qcom,entry-name = "slave-kernel"; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; Please correct the indentation of this block. > + > + slpi_smp2p_out: master-kernel { > + qcom,entry-name = "master-kernel"; > + #qcom,state-cells = <1>; > + }; > + }; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 1/12/2017 11:54 PM, Bjorn Andersson wrote: > On Thu 12 Jan 05:53 PST 2017, Avaneesh Kumar Dwivedi wrote: >> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> index 9d1d7ad..2457b20 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> @@ -541,5 +541,29 @@ >> #interrupt-cells = <2>; >> }; >> }; >> + >> + smp2p-slpi { >> + compatible = "qcom,smp2p"; >> + qcom,smem = <481>, <430>; >> + >> + interrupts = <0 178 1>; > Please use <GIC_SPI 178 IRQ_TYPE_EDGE_RISING>; OK, > >> + >> + qcom,ipc = <&apcs 4 8>; > Looking at qcom,smp2p-dsps downstream I get this to <&apcs 16 26>; I think i missed it, during validation it was working with <&apcs 4 8> and so did not realize to verify its validity. will check and update. > >> + >> + qcom,local-pid = <0>; >> + qcom,remote-pid = <3>; >> + >> + slpi_smp2p_in: slave-kernel { >> + qcom,entry-name = "slave-kernel"; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + }; > Please correct the indentation of this block. OK. > >> + >> + slpi_smp2p_out: master-kernel { >> + qcom,entry-name = "master-kernel"; >> + #qcom,state-cells = <1>; >> + }; >> + }; > Regards, > Bjorn
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 9d1d7ad..2457b20 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -541,5 +541,29 @@ #interrupt-cells = <2>; }; }; + + smp2p-slpi { + compatible = "qcom,smp2p"; + qcom,smem = <481>, <430>; + + interrupts = <0 178 1>; + + qcom,ipc = <&apcs 4 8>; + + qcom,local-pid = <0>; + qcom,remote-pid = <3>; + + slpi_smp2p_in: slave-kernel { + qcom,entry-name = "slave-kernel"; + interrupt-controller; + #interrupt-cells = <2>; + }; + + slpi_smp2p_out: master-kernel { + qcom,entry-name = "master-kernel"; + #qcom,state-cells = <1>; + }; + }; + }; #include "msm8996-pins.dtsi"
Add SMP2P DT nodes required for Qualcomm SLPI Peripheral Image Loader. Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)