From patchwork Tue Jan 24 23:13:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarangdhar Joshi X-Patchwork-Id: 9536077 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E5B056042D for ; Tue, 24 Jan 2017 23:13:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBDDA26E98 for ; Tue, 24 Jan 2017 23:13:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D0741279E0; Tue, 24 Jan 2017 23:13:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC14A26E98 for ; Tue, 24 Jan 2017 23:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751125AbdAXXNQ (ORCPT ); Tue, 24 Jan 2017 18:13:16 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:39798 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbdAXXNO (ORCPT ); Tue, 24 Jan 2017 18:13:14 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1B726609D0; Tue, 24 Jan 2017 23:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1485299594; bh=U/66FoS2ZpNDdB4MEnOU4PMxgrvlgbkJu+Nfk9A6lhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jLXPoFD1DsF4+XvJlP1mAUHixky+/j+lrbk/hmGtIcSSG3yHWVVBz/9ONTS0RV5Ez tJuz7hzL+ErInltUpRKuCDx3VyAIEjTyyiuxgWxEJZzknbEBthMDMOtQ87cFo6iAYV ZOWWjrPtsmEQhfhGunBy7Q906ivwmKlFnEQBWKA4= Received: from spjoshi-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: spjoshi@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id ADFDE60996; Tue, 24 Jan 2017 23:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1485299593; bh=U/66FoS2ZpNDdB4MEnOU4PMxgrvlgbkJu+Nfk9A6lhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Vbu4ZaGzWCDgDBrtZ/R1On6D396Od2icj9mFMEgNs6AHBRzYFNn+RXr5xybtNidOL LmFyesIhCSOGbKe3N7BqO5hOrvTXBPJo3B8cYme/7C7TqZFvwybdOA5pBHnG2NW1Me Qe/hiHKipsPrN61RsNENNoA4x+5YA3mA/0PozVPQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ADFDE60996 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=spjoshi@codeaurora.org From: Sarangdhar Joshi To: Ohad Ben-Cohen , Bjorn Andersson , Loic Pallardy , Santosh Shilimkar Cc: Sarangdhar Joshi , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Dave Gerlach , Suman Anna , Stephen Boyd , Trilok Soni Subject: [PATCH 2/2] remoteproc: Modify the function names Date: Tue, 24 Jan 2017 15:13:01 -0800 Message-Id: <1485299581-30476-2-git-send-email-spjoshi@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1485299581-30476-1-git-send-email-spjoshi@codeaurora.org> References: <1485299581-30476-1-git-send-email-spjoshi@codeaurora.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The functions rproc_add_virtio_devices() and rproc_fw_config_virtio() are reduced to trigger auto-boot only. Modify these function names and related comments to reflect their current state. This patch does not add any functional change. Signed-off-by: Sarangdhar Joshi --- drivers/remoteproc/remoteproc_core.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 16242b0..c6b1d4a 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -959,14 +959,14 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw) } /* - * take a firmware and look for virtio devices to register. + * take a firmware and boot it up. * * Note: this function is called asynchronously upon registration of the * remote processor (so we must wait until it completes before we try * to unregister the device. one other option is just to use kref here, * that might be cleaner). */ -static void rproc_fw_config_virtio(const struct firmware *fw, void *context) +static void rproc_auto_boot_callback(const struct firmware *fw, void *context) { struct rproc *rproc = context; @@ -975,21 +975,17 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context) release_firmware(fw); } -static int rproc_add_virtio_devices(struct rproc *rproc) +static int rproc_trigger_auto_boot(struct rproc *rproc) { int ret; /* - * We must retrieve early virtio configuration info from - * the firmware (e.g. whether to register a virtio device, - * what virtio features does it support, ...). - * * We're initiating an asynchronous firmware loading, so we can * be built-in kernel code, without hanging the boot process. */ ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_HOTPLUG, rproc->firmware, &rproc->dev, GFP_KERNEL, - rproc, rproc_fw_config_virtio); + rproc, rproc_auto_boot_callback); if (ret < 0) dev_err(&rproc->dev, "request_firmware_nowait err: %d\n", ret); @@ -1287,7 +1283,7 @@ int rproc_add(struct rproc *rproc) /* if rproc is marked always-on, request it to boot */ if (rproc->auto_boot) { - ret = rproc_add_virtio_devices(rproc); + ret = rproc_trigger_auto_boot(rproc); if (ret < 0) return ret; }