From patchwork Fri May 26 00:40:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarangdhar Joshi X-Patchwork-Id: 9749505 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 38CB560388 for ; Fri, 26 May 2017 00:41:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B6E2283D2 for ; Fri, 26 May 2017 00:41:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2044A283FF; Fri, 26 May 2017 00:41:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3296283D2 for ; Fri, 26 May 2017 00:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162231AbdEZAki (ORCPT ); Thu, 25 May 2017 20:40:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38738 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163357AbdEZAkS (ORCPT ); Thu, 25 May 2017 20:40:18 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 12380611DF; Fri, 26 May 2017 00:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1495759212; bh=zBF85DIaDKLJjfasdK884veV805BNiE8jkW5d4yi1Fs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ipxkYWycmHlJtg765VcRdRKpYSFNhJ6qsIbFrMaUSqp57evplyunhA8GP2BM98FGb ZpCyGTQC0QpbYlkhbXd9ipsLJ6LLsjqc/a1oQTjTDZW1zMKe7VgDnNqY+qRe6B6l0s 3OjmOsfJhe3oqIBVPwbt59GdWAd2PzSiE+46Y4p8= Received: from spjoshi-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: spjoshi@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1DB92611C6; Fri, 26 May 2017 00:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1495759211; bh=zBF85DIaDKLJjfasdK884veV805BNiE8jkW5d4yi1Fs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c+FRKr1B3KVcHR+UtC2OHMZPdI7Tf0zeLQUGunWWwrXFVbHLy6pG7kr7/Ih+tvGf8 BSDE9zes5sDqnfI4Fjf37YCwNsx+ePvIlII8Q6QbWl9rhS6Q9XIBY3ZQ3WsgOs0Skf xNB2nMa1rZfrsmESdMSTUF/5e4MCsVrmAE4PbUZ4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1DB92611C6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=spjoshi@codeaurora.org From: Sarangdhar Joshi To: Ohad Ben-Cohen , Bjorn Andersson , Loic Pallardy Cc: Sarangdhar Joshi , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Stephen Boyd , Trilok Soni Subject: [PATCH v2 2/2] remoteproc: Modify recovery path to use rproc_{start, stop}() Date: Thu, 25 May 2017 17:40:00 -0700 Message-Id: <1495759200-5575-2-git-send-email-spjoshi@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1495759200-5575-1-git-send-email-spjoshi@codeaurora.org> References: <1495759200-5575-1-git-send-email-spjoshi@codeaurora.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace rproc_shutdown() by rproc_stop() and rproc_boot() by rproc_start() in the recovery path, in order to avoid remoteproc resources re-allocation overhead and to assist with extracting the coredumps after stopping the remote processor. Signed-off-by: Sarangdhar Joshi --- Changes from v1: * Separate modification in recovery path * Call release_firmware() when rproc_start() fails drivers/remoteproc/remoteproc_core.c | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index aeb7bdd..9830a1d 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -1050,23 +1050,40 @@ static int rproc_stop(struct rproc *rproc) */ int rproc_trigger_recovery(struct rproc *rproc) { - dev_err(&rproc->dev, "recovering %s\n", rproc->name); + const struct firmware *firmware_p; + struct device *dev = &rproc->dev; + int ret; + + dev_err(dev, "recovering %s\n", rproc->name); init_completion(&rproc->crash_comp); - /* shut down the remote */ - /* TODO: make sure this works with rproc->power > 1 */ - rproc_shutdown(rproc); + ret = mutex_lock_interruptible(&rproc->lock); + if (ret) + return ret; + + ret = rproc_stop(rproc); + if (ret) + goto unlock_mutex; /* wait until there is no more rproc users */ wait_for_completion(&rproc->crash_comp); - /* - * boot the remote processor up again - */ - rproc_boot(rproc); + /* load firmware */ + ret = request_firmware(&firmware_p, rproc->firmware, dev); + if (ret < 0) { + dev_err(dev, "request_firmware failed: %d\n", ret); + goto unlock_mutex; + } - return 0; + /* boot the remote processor up again */ + ret = rproc_start(rproc, firmware_p); + + release_firmware(firmware_p); + +unlock_mutex: + mutex_unlock(&rproc->lock); + return ret; } /**