From patchwork Thu Aug 31 04:45:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan Ramabadhran X-Patchwork-Id: 9931167 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C0D50602F0 for ; Thu, 31 Aug 2017 04:47:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B50782881C for ; Thu, 31 Aug 2017 04:47:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A9F1D2881E; Thu, 31 Aug 2017 04:47:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 591952881C for ; Thu, 31 Aug 2017 04:47:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751708AbdHaEqR (ORCPT ); Thu, 31 Aug 2017 00:46:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37250 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbdHaEqN (ORCPT ); Thu, 31 Aug 2017 00:46:13 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C5AD7629E1; Thu, 31 Aug 2017 04:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1504154773; bh=QXFmVM4AdrTGmSk/MXM7+F9nD5Dtl2nNXOHyPtXw7uE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n1inbyFmD4CPZEULnld9Ps3+FGv+MAYYNlQ49wA3FDLZ9mLrCYLP61pkBo1UO21iZ wTY4uDXkAmaBHDi3U8QkkXmj0sUnsKSKWbrRaGAuRqO+wF7UrEwIalqr2AxpyqFhgs tVDz5beEHsHkBnhKigBnYzXJ1tokTFU6vob3OSuw= Received: from srichara-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BB0DE62C7A; Thu, 31 Aug 2017 04:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1504154762; bh=QXFmVM4AdrTGmSk/MXM7+F9nD5Dtl2nNXOHyPtXw7uE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gacbf2dZZd6RtfFEljt215x1b9z/hPtSdIkTWaFxJq35P1G0Q01qaQsHRbjhBCG8O nh1qOCZjnqLPOAtey3zAEhKiOHgVo3IiDomQv2crrFzmtZwVaglOhzVS7W2kTLrlsE yrayP/cxwAjY1uYCqc0kmlylWIllJ2nhXHFJtyL4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BB0DE62C7A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org From: Sricharan R To: bjorn.andersson@linaro.org, ohad@wizery.com, robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Cc: sricharan@codeaurora.org Subject: [PATCH v3 3/6] remoteproc: qcom: Push reset ops, fw ops, rproc ops in to of_match data Date: Thu, 31 Aug 2017 10:15:31 +0530 Message-Id: <1504154734-12175-4-git-send-email-sricharan@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1504154734-12175-1-git-send-email-sricharan@codeaurora.org> References: <1504154734-12175-1-git-send-email-sricharan@codeaurora.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Instead of directly assigning reset, fw and rproc ops, put them in to of_match data and get from that. Currently same ops are used for all compatibles, but that will change when we add q6v5-wcss support. Signed-off-by: Sricharan R --- drivers/remoteproc/qcom_q6v5_pil.c | 38 +++++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 808ee45..5b5811d 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -116,16 +116,6 @@ struct qcom_mss_reg_res { int uA; }; -struct rproc_hexagon_res { - const char *hexagon_mba_image; - struct qcom_mss_reg_res *proxy_supply; - struct qcom_mss_reg_res *active_supply; - char **proxy_clk_names; - char **active_clk_names; - int version; - bool need_mem_protection; -}; - struct q6v5 { struct device *dev; struct rproc *rproc; @@ -173,6 +163,19 @@ struct q6v5 { int version; }; +struct rproc_hexagon_res { + const char *hexagon_mba_image; + struct qcom_mss_reg_res *proxy_supply; + struct qcom_mss_reg_res *active_supply; + char **proxy_clk_names; + char **active_clk_names; + int version; + bool need_mem_protection; + int (*init_reset)(struct q6v5 *qproc); + const struct rproc_fw_ops *fw_ops; + const struct rproc_ops *ops; +}; + enum { MSS_MSM8916, MSS_MSM8974, @@ -1125,14 +1128,14 @@ static int q6v5_probe(struct platform_device *pdev) if (!desc) return -EINVAL; - rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops, + rproc = rproc_alloc(&pdev->dev, pdev->name, desc->ops, desc->hexagon_mba_image, sizeof(*qproc)); if (!rproc) { dev_err(&pdev->dev, "failed to allocate rproc\n"); return -ENOMEM; } - rproc->fw_ops = &q6v5_fw_ops; + rproc->fw_ops = desc->fw_ops; qproc = (struct q6v5 *)rproc->priv; qproc->dev = &pdev->dev; @@ -1182,7 +1185,7 @@ static int q6v5_probe(struct platform_device *pdev) } qproc->active_reg_count = ret; - ret = q6v5_init_reset(qproc); + ret = desc->init_reset(qproc); if (ret) goto free_rproc; @@ -1253,6 +1256,9 @@ static int q6v5_remove(struct platform_device *pdev) }, .need_mem_protection = true, .version = MSS_MSM8996, + .init_reset = q6v5_init_reset, + .fw_ops = &q6v5_fw_ops, + .ops = &q6v5_ops, }; static const struct rproc_hexagon_res msm8916_mss = { @@ -1284,6 +1290,9 @@ static int q6v5_remove(struct platform_device *pdev) }, .need_mem_protection = false, .version = MSS_MSM8916, + .init_reset = q6v5_init_reset, + .fw_ops = &q6v5_fw_ops, + .ops = &q6v5_ops, }; static const struct rproc_hexagon_res msm8974_mss = { @@ -1323,6 +1332,9 @@ static int q6v5_remove(struct platform_device *pdev) }, .need_mem_protection = false, .version = MSS_MSM8974, + .init_reset = q6v5_init_reset, + .fw_ops = &q6v5_fw_ops, + .ops = &q6v5_ops, }; static const struct of_device_id q6v5_of_match[] = {