From patchwork Fri Oct 27 10:45:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun Kumar Neelakantam X-Patchwork-Id: 10029555 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8A2726034B for ; Fri, 27 Oct 2017 10:46:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7928828F13 for ; Fri, 27 Oct 2017 10:46:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B1E528F8F; Fri, 27 Oct 2017 10:46:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F01D028F13 for ; Fri, 27 Oct 2017 10:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbdJ0KqI (ORCPT ); Fri, 27 Oct 2017 06:46:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47276 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbdJ0KqH (ORCPT ); Fri, 27 Oct 2017 06:46:07 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2C7E2601A1; Fri, 27 Oct 2017 10:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1509101167; bh=x1ZLGY1TCHw6a/FOBqMjx6mC2NSw75Ym1hXqpB5wgvk=; h=From:To:Cc:Subject:Date:From; b=UIZ6YuGa4bwANiu6ho5V9GsFYsYh3JKW3dZReaoCiag+Hy/ZQj77TefXvlgX3hBHn zlO0GuUvpRfEJT7C0Vq0OYj7AkkuAylI3cTz3dHlInIwkm68u+IcH/wW5HcHUUzNK8 15SCaID386cNz9l41kiFUrpdbxX82l5rW4eF63V8= Received: from aneelaka-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aneela@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9BD72601A1; Fri, 27 Oct 2017 10:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1509101166; bh=x1ZLGY1TCHw6a/FOBqMjx6mC2NSw75Ym1hXqpB5wgvk=; h=From:To:Cc:Subject:Date:From; b=YKeKlWLCl1oxGz2lWFQpNRFfrjrjmFxYLXkK+J/q7IM+rgrtnUazXPf7c7v4WXtym CImp/D123GvIa0ucNjZvxeGQRMMuMUHar8nSN86Kg4V2vXgKToSB5AXpIYHVsUWQ56 FFC5wPwz1vtY6MAwcKqipXPUi2pvDFHlyfkEI+Mc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9BD72601A1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aneela@codeaurora.org From: Arun Kumar Neelakantam To: ohad@wizery.com, bjorn.andersson@linaro.org, sricharan@codeaurora.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Arun Kumar Neelakantam Subject: [PATCH] rpmsg: glink: Initialize the "intent_req_comp" completion variable Date: Fri, 27 Oct 2017 16:15:52 +0530 Message-Id: <1509101152-1340-1-git-send-email-aneela@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The "intent_req_comp" variable is used without initialization which results in NULL pointer derefernce in qcom_glink_request_intent(). we need to initialize the completion variable before using it. Fixes: 27b9c5b66b23 ("rpmsg: glink: Request for intents when unavailable") Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 5dcc9bf..fcd46ab 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -227,6 +227,7 @@ static struct glink_channel *qcom_glink_alloc_channel(struct qcom_glink *glink, init_completion(&channel->open_req); init_completion(&channel->open_ack); + init_completion(&channel->intent_req_comp); INIT_LIST_HEAD(&channel->done_intents); INIT_WORK(&channel->intent_work, qcom_glink_rx_done_work);