From patchwork Thu Feb 8 11:41:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: JITENDRA SHARMA X-Patchwork-Id: 10207009 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD3AD602D8 for ; Thu, 8 Feb 2018 11:41:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFEFA294A7 for ; Thu, 8 Feb 2018 11:41:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4D7E294AE; Thu, 8 Feb 2018 11:41:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2795294A7 for ; Thu, 8 Feb 2018 11:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751725AbeBHLlO (ORCPT ); Thu, 8 Feb 2018 06:41:14 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57592 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbeBHLlN (ORCPT ); Thu, 8 Feb 2018 06:41:13 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0B49B60314; Thu, 8 Feb 2018 11:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518090073; bh=RyU4+X32AfWgp9qON22QajRHLPOn1O5DuhKjluYbnhw=; h=From:To:Cc:Subject:Date:From; b=nXrFqMlBJIc7IRC0Ov+PgTM03YHCnv8lDmDvcgtCrUW+JYEiov0JWemccHHE4Rj8o 2VsBbHVzqvOro+7JpF1pUY88SzuPdXP1MEGsPwsMYUn2EUIkNLD7ah+AzsMio4q5wd Pxw3asumeUkb/HlddMebH/CPGMIhOPvmupb//GtQ= Received: from shajit-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: shajit@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 070F960314; Thu, 8 Feb 2018 11:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518090072; bh=RyU4+X32AfWgp9qON22QajRHLPOn1O5DuhKjluYbnhw=; h=From:To:Cc:Subject:Date:From; b=F+YsB3ySY7hTgb+WYF/mpFkHFQc5HLrWgNFox2wntisn0V9gVeCXTIY1q2Q4iJKQx 3A48Yi6FcrsBUnrK9tzLEcdstBT8tQlRKqT3fR+lHYBoLYh1UgQh7jiwmFHnwj5Hls yUWF9dYf6v990y0kbkoxCSL9PBcWVbQGxZ7n6jDA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 070F960314 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shajit@codeaurora.org From: Jitendra Sharma To: bjorn.andersson@linaro.org Cc: linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jitendra Sharma Subject: [PATCH v1] remoteproc: Remove null character write of shared mem Date: Thu, 8 Feb 2018 17:11:02 +0530 Message-Id: <1518090062-20877-1-git-send-email-shajit@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP remoteproc is writing '\0' in the shared mem region. This region is shared among multiple clients that are also trying to read. Hence they miss first character. Remove this null character write, as this mem area is supposed to be Read only. Further during every subsystem reboot, this region is initialized with default, hence no need to write this region. Signed-off-by: Jitendra Sharma --- drivers/remoteproc/qcom_adsp_pil.c | 3 --- drivers/remoteproc/qcom_q6v5_pil.c | 6 ------ drivers/remoteproc/qcom_wcnss.c | 3 --- 3 files changed, 12 deletions(-) diff --git a/drivers/remoteproc/qcom_adsp_pil.c b/drivers/remoteproc/qcom_adsp_pil.c index 373c167..4a2ee6c 100644 --- a/drivers/remoteproc/qcom_adsp_pil.c +++ b/drivers/remoteproc/qcom_adsp_pil.c @@ -201,9 +201,6 @@ static irqreturn_t adsp_fatal_interrupt(int irq, void *dev) rproc_report_crash(adsp->rproc, RPROC_FATAL_ERROR); - if (!IS_ERR(msg)) - msg[0] = '\0'; - return IRQ_HANDLED; } diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index b4e5e72..7293d45 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -939,9 +939,6 @@ static irqreturn_t q6v5_wdog_interrupt(int irq, void *dev) rproc_report_crash(qproc->rproc, RPROC_WATCHDOG); - if (!IS_ERR(msg)) - msg[0] = '\0'; - return IRQ_HANDLED; } @@ -959,9 +956,6 @@ static irqreturn_t q6v5_fatal_interrupt(int irq, void *dev) rproc_report_crash(qproc->rproc, RPROC_FATAL_ERROR); - if (!IS_ERR(msg)) - msg[0] = '\0'; - return IRQ_HANDLED; } diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c index 3f06092..043f3d3 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -332,9 +332,6 @@ static irqreturn_t wcnss_fatal_interrupt(int irq, void *dev) rproc_report_crash(wcnss->rproc, RPROC_FATAL_ERROR); - if (!IS_ERR(msg)) - msg[0] = '\0'; - return IRQ_HANDLED; }