From patchwork Thu Apr 26 02:07:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Lew X-Patchwork-Id: 10364561 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8459760225 for ; Thu, 26 Apr 2018 02:09:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75BFD290E2 for ; Thu, 26 Apr 2018 02:09:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A712290E4; Thu, 26 Apr 2018 02:09:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1714F290E2 for ; Thu, 26 Apr 2018 02:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753795AbeDZCIx (ORCPT ); Wed, 25 Apr 2018 22:08:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44318 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751867AbeDZCIm (ORCPT ); Wed, 25 Apr 2018 22:08:42 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D964A60FB1; Thu, 26 Apr 2018 02:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524708521; bh=PncrJar2lMH+54y6mOPXVRJPwgyjdf/DBQxkUJSqKMk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZTxaoHgnr7mTjIT/9edH2UTEIDWKfNmqWGfLmUsA2UL1yaQxoP8Iq3SoRUq4va3Lz BRK2Ir2fYtX00706zZ4TVbRYdCeNsZ09qHiN8QZ8F2OkBkXI0gaWGUd3TXFSVUut1S Td4v12zetttWgVSk6/6wQels5/x/PoQrugK5XBck= Received: from clew-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: clew@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CFB7F60F74; Thu, 26 Apr 2018 02:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524708521; bh=PncrJar2lMH+54y6mOPXVRJPwgyjdf/DBQxkUJSqKMk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZTxaoHgnr7mTjIT/9edH2UTEIDWKfNmqWGfLmUsA2UL1yaQxoP8Iq3SoRUq4va3Lz BRK2Ir2fYtX00706zZ4TVbRYdCeNsZ09qHiN8QZ8F2OkBkXI0gaWGUd3TXFSVUut1S Td4v12zetttWgVSk6/6wQels5/x/PoQrugK5XBck= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CFB7F60F74 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clew@codeaurora.org From: Chris Lew To: bjorn.andersson@linaro.org, andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, clew@codeaurora.org Subject: [PATCH v2 3/6] rpmsg: glink: Use complete_all for open states Date: Wed, 25 Apr 2018 19:07:49 -0700 Message-Id: <1524708472-18263-4-git-send-email-clew@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1524708472-18263-1-git-send-email-clew@codeaurora.org> References: <1524708472-18263-1-git-send-email-clew@codeaurora.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew --- Changes since v1: - New change drivers/rpmsg/qcom_glink_native.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index c3f548e2ff20..120d6b9bb9f3 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -957,7 +957,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid) return -EINVAL; } - complete(&channel->open_ack); + complete_all(&channel->open_ack); return 0; } @@ -1401,7 +1401,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid, channel->rcid = ret; spin_unlock_irqrestore(&glink->idr_lock, flags); - complete(&channel->open_req); + complete_all(&channel->open_req); if (create_device) { rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);