From patchwork Fri Jul 27 12:17:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun Kumar Neelakantam X-Patchwork-Id: 10547043 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 498791751 for ; Fri, 27 Jul 2018 12:19:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38A2C2B852 for ; Fri, 27 Jul 2018 12:19:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2CB752B859; Fri, 27 Jul 2018 12:19:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF9572B852 for ; Fri, 27 Jul 2018 12:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730784AbeG0NkP (ORCPT ); Fri, 27 Jul 2018 09:40:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45894 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730488AbeG0NkP (ORCPT ); Fri, 27 Jul 2018 09:40:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id BDC2C6085F; Fri, 27 Jul 2018 12:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1532693914; bh=a0tfnI0doOCjNvfCw741371JJr81Y5dLABlWTH4KQxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RId7ecU2ZKQhpIMU/KTo5Uj88DzKVZZZqEUQd44UANlke+hBC1t6QdNvQ1TxN3NbY 7SkkWMOjU0XSfGV2BuabI2jzWljhD2xxdPkM3/pOmxB/6g3j9BSCtxmnMtYFTVrZft gmiNipooMiaj0WHtQIEa4wXYmFgrSccAE2mHviMo= Received: from aneelaka-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aneela@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4E2B560B7A; Fri, 27 Jul 2018 12:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1532693914; bh=a0tfnI0doOCjNvfCw741371JJr81Y5dLABlWTH4KQxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RId7ecU2ZKQhpIMU/KTo5Uj88DzKVZZZqEUQd44UANlke+hBC1t6QdNvQ1TxN3NbY 7SkkWMOjU0XSfGV2BuabI2jzWljhD2xxdPkM3/pOmxB/6g3j9BSCtxmnMtYFTVrZft gmiNipooMiaj0WHtQIEa4wXYmFgrSccAE2mHviMo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4E2B560B7A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aneela@codeaurora.org From: Arun Kumar Neelakantam To: ohad@wizery.com, bjorn.andersson@linaro.org, clew@codeaurora.org, robh+dt@kernel.org, arnaud.pouliquen@st.com, andy.gross@linaro.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Arun Kumar Neelakantam Subject: [PATCH V4 3/9] rpmsg: glink: Use complete_all for open states Date: Fri, 27 Jul 2018 17:47:23 +0530 Message-Id: <1532693849-7037-4-git-send-email-aneela@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1532693849-7037-1-git-send-email-aneela@codeaurora.org> References: <1532693849-7037-1-git-send-email-aneela@codeaurora.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chris Lew The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 22a3cac..f43341d 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -949,7 +949,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid) return -EINVAL; } - complete(&channel->open_ack); + complete_all(&channel->open_ack); return 0; } @@ -1393,7 +1393,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid, channel->rcid = ret; spin_unlock_irqrestore(&glink->idr_lock, flags); - complete(&channel->open_req); + complete_all(&channel->open_req); if (create_device) { rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);