Message ID | 1593017121-7953-2-git-send-email-deesin@codeaurora.org (mailing list archive) |
---|---|
State | Accepted |
Commit | 4fcdaf6e28d11e2f3820d54dd23cd12a47ddd44e |
Headers | show |
Series | [V7,1/4] rpmsg: glink: Use complete_all for open states | expand |
Hello: This series was applied to andersson/remoteproc.git (refs/heads/for-next). On Wed, 24 Jun 2020 22:15:18 +0530 you wrote: > From: Chris Lew <clew@codeaurora.org> > > The open_req and open_ack completion variables are the state variables > to represet a remote channel as open. Use complete_all so there are no > races with waiters and using completion_done. > > Signed-off-by: Chris Lew <clew@codeaurora.org> > Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org> > Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org> > > [...] Here is a summary with links: - [V7,1/4] rpmsg: glink: Use complete_all for open states https://git.kernel.org/andersson/remoteproc/c/4fcdaf6e28d11e2f3820d54dd23cd12a47ddd44e - [V7,2/4] rpmsg: Guard against null endpoint ops in destroy https://git.kernel.org/andersson/remoteproc/c/d5158cda9e7b66fd412815df32e58943b7383f0c - [V7,3/4] rpmsg: glink: Add support for rpmsg glink chrdev https://git.kernel.org/andersson/remoteproc/c/0f579e52472198cec2d3d794a26e277c84e9dbd2 - [V7,4/4] rpmsg: glink: Expose rpmsg name attr for glink https://git.kernel.org/andersson/remoteproc/c/4e3dda0bc603c1ca84680a56bfc49e8fe2519c89 You are awesome, thank you!
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 1995f5b..d5114ab 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -970,7 +970,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid) return -EINVAL; } - complete(&channel->open_ack); + complete_all(&channel->open_ack); return 0; } @@ -1178,7 +1178,7 @@ static int qcom_glink_announce_create(struct rpmsg_device *rpdev) __be32 *val = defaults; int size; - if (glink->intentless) + if (glink->intentless || !completion_done(&channel->open_ack)) return 0; prop = of_find_property(np, "qcom,intents", NULL); @@ -1413,7 +1413,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid, channel->rcid = ret; spin_unlock_irqrestore(&glink->idr_lock, flags); - complete(&channel->open_req); + complete_all(&channel->open_req); if (create_device) { rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);