From patchwork Wed Jan 11 14:35:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 9511583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C44ED60231 for ; Wed, 11 Jan 2017 22:35:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B268428696 for ; Wed, 11 Jan 2017 22:35:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A465F286BC; Wed, 11 Jan 2017 22:35:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 251F128696 for ; Wed, 11 Jan 2017 22:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935196AbdAKWeu (ORCPT ); Wed, 11 Jan 2017 17:34:50 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:35433 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758118AbdAKWen (ORCPT ); Wed, 11 Jan 2017 17:34:43 -0500 Received: by mail-pf0-f175.google.com with SMTP id f144so1041264pfa.2 for ; Wed, 11 Jan 2017 14:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KlHKX6ry2YUWQb6UB6hzMYEpuEeslsaXBdpSKhc10gE=; b=YPqnil9muPh2iDq1j3UgYllkaIxM3GTRGLg0E/xDlVr/tDm871Q6CDGoblvFuCFX2M cCkofo29fSeQl0tsPh1XR4Wg48QHprJI3rZ6aW1jEOb0ViIHgB9Q0vVB+SP9LJOF6/QP NG5FzTuxGpkZSDk1jSlxISYZgQWcg+WkaUWsc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KlHKX6ry2YUWQb6UB6hzMYEpuEeslsaXBdpSKhc10gE=; b=eUenfnQDi5uDX4GQ5v+xlwWvhSH9u1JttTfyF5bMZqOXimsDQW/tfLDzcGD9+4vweE R0B8gDRSmyJKf26IgfIbRodY12MlgYxcq2qSJEiSitNjBLDSDvQTFKpkLFP8Xio3ckZG 0t2HSVmXRQq64rEjaFVQNOgRf0bqEnsVsRgU9g239iD+60Vua7Dfuh6s12xJSlw1Mt3h oBM2+qGLHeEUNmnMN4H82d2oTvrnN+JOvqO/UZ3CfzCvqQcltChO77MC24Gg6zq+em6e lAoLTqNitLpTTAqVtc1xZ6BbcQxvtAKRdJ/ZJfdC9XEAzMurW6ccMD8/iTFU17BJ5t2K Y1Iw== X-Gm-Message-State: AIkVDXJDhwP1pHiqwa95RKuDRs0QPGiGkjJs4UV2FZnSxjsvyQeP7YNnYnpIP3SO48f4w5XF X-Received: by 10.98.117.10 with SMTP id q10mr10187753pfc.31.1484174082810; Wed, 11 Jan 2017 14:34:42 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id o89sm16128591pfi.26.2017.01.11.14.34.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2017 14:34:41 -0800 (PST) From: Bjorn Andersson To: Ohad Ben-Cohen , Bjorn Andersson Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 4/4] rpmsg: smd: Register rpmsg user space interface for edges Date: Wed, 11 Jan 2017 06:35:13 -0800 Message-Id: <20170111143513.32251-4-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170111143513.32251-1-bjorn.andersson@linaro.org> References: <20170111143513.32251-1-bjorn.andersson@linaro.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Create and register a rpmsg device for use with the rpmsg user space interface, allowing user space to access SMD channels. Also provide the "rpmsg_name" device attribute to expose the edge name in sysfs, allowing the user to write udev rules for specific rpmsg devices and their children. Signed-off-by: Bjorn Andersson --- Changes since v2: - None Changes since v1: - Moved rpmsg_name attribute to different patch drivers/rpmsg/qcom_smd.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 9e2af6a18aa2..beaef5dd973e 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1002,6 +1002,20 @@ static int qcom_smd_create_device(struct qcom_smd_channel *channel) return rpmsg_register_device(rpdev); } +static int qcom_smd_create_chrdev(struct qcom_smd_edge *edge) +{ + struct qcom_smd_device *qsdev; + + qsdev = kzalloc(sizeof(*qsdev), GFP_KERNEL); + if (!qsdev) + return -ENOMEM; + + qsdev->edge = edge; + qsdev->rpdev.ops = &qcom_smd_device_ops; + qsdev->rpdev.dev.parent = &edge->dev; + return rpmsg_chrdev_register_device(&qsdev->rpdev); +} + /* * Allocate the qcom_smd_channel object for a newly found smd channel, * retrieving and validating the smem items involved. @@ -1357,6 +1371,12 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, goto unregister_dev; } + ret = qcom_smd_create_chrdev(edge); + if (ret) { + dev_err(&edge->dev, "failed to register chrdev for edge\n"); + goto unregister_dev; + } + schedule_work(&edge->scan_work); return edge;