From patchwork Mon Nov 6 13:37:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10043487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE8EC603FF for ; Mon, 6 Nov 2017 13:37:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D49D929C02 for ; Mon, 6 Nov 2017 13:37:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C861329C7C; Mon, 6 Nov 2017 13:37:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54D8829C02 for ; Mon, 6 Nov 2017 13:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbdKFNhu (ORCPT ); Mon, 6 Nov 2017 08:37:50 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:57235 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbdKFNht (ORCPT ); Mon, 6 Nov 2017 08:37:49 -0500 Received: from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0M7az9-1f8uE10Sgx-00xK6h; Mon, 06 Nov 2017 14:37:38 +0100 From: Arnd Bergmann To: Ohad Ben-Cohen , Bjorn Andersson Cc: Arnd Bergmann , Avaneesh Kumar Dwivedi , Andy Gross , Philipp Zabel , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] remoteproc: qcom: use %pap format string for phys_addr_t Date: Mon, 6 Nov 2017 14:37:17 +0100 Message-Id: <20171106133736.584646-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:2hqBSeuoILu6PdvOkvvizzp1wC7BHci1trN8hH0vLvAsxXa/U06 Y3B+mfOobKb15F5ODlsceLyZHXdEDxxhuJVGwprlCtgPlLg4a/npOVABPe2sTUSJhbf53mc 4GlOMBVSQjYfNK/m6XqRHt4vidK2OApLwhRazPO5zCnIdKbxOTC3mwyRTuVoGo2vo+DXP+t 7UofGPPunMiW6WB9H3lsQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:mPTf7TiYagE=:fmu3KoIuk+lRuLWE5PAIqa YSFT6jHK25IxnpJ79u04jD/Z24nKly2K7jFC4qhlJK7Xs+iGPgnOF6A9yx+5qvjFVp31PeLH8 dJ0ibfZX26T+c8kBX72N33pvwTpHJ/4GdncZXbHkFz/wv188raWKHE2fnnjNeEXyPjS25gEbA AqdB29vR5TqsS7Ab5qCcUGUau0z9tIBSxfkN2QOQI1INdU+xT5Bi/jeQY6c+5gl3MYdCzZ1Zm XhMd8cr1DGNtJGdJdIgRQgpS7HZwqNClVqa+OjC1ZPMXm8IBS1V4XLs2lnOi1jPG8iAxts8Lu 9GXtsjmT8NsMwmuWjMNLnuILxxTN7t/XTJuNpZBDC42iSSRDaFxXBspisPHKLn4sIUFMWpa3w 0ivSI5M1AdIMqznsjy5wD8htkb8v7vscbKzblHVnqW/+AEOrIcpJIUBzqy2EZme09bx9fZD5m RI2uMMdXrsuwIpmSlOQCX1hNjEfwZl8dE1sqko/SqNsArxbd4mktdcoeMWmt1wZK7F+RuPDPu K0S3lx7TrD3pLqp/TfalckMJwxUPeBeYsE9tYtj3O3rvm+Z2gEn8YtbdgYUnVVniVdjPXDNjY lTkm88wulUabSVC2sALytHZvMHGesgWg4ij0wM+FhG6b7h9G/HFJhoMhOR3aicoqtKUE7G2MM 1pwxPOnUBuBFCgAvPyFjNuNsNSg2hd1KNvdd4oNe9W6MMUPIZZhcQgTlBh/UmEZL1cYl2kVzS 7vOaznrd+yXTbESvslI/fjV2bEWLGPZppWN5fQ== Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We cannot cast a phys_addr_t variable to a pointer on 32-bit architectures with CONFIG_PHYS_ADDR_T_64BIT set: In file included from include/linux/kernel.h:14:0, from include/linux/clk.h:16, from drivers/remoteproc/qcom_q6v5_pil.c:18: drivers/remoteproc/qcom_q6v5_pil.c: In function 'q6v5_xfer_mem_ownership': drivers/remoteproc/qcom_q6v5_pil.c:337:10: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (void *)addr, (void *)(addr + size), ^ The correct way to print the contents is to use the %pap format string, passing the phys address by reference. Fixes: 6c5a9dc2481b ("remoteproc: qcom: Make secure world call for mem ownership switch") Signed-off-by: Arnd Bergmann --- drivers/remoteproc/qcom_q6v5_pil.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 5460f61ee21c..4576f88499cb 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -333,9 +333,9 @@ static int q6v5_xfer_mem_ownership(struct q6v5 *qproc, int *current_perm, ret = qcom_scm_assign_mem(addr, ALIGN(size, SZ_4K), current_perm, &next, 1); if (ret < 0) { - pr_err("Failed to assign memory access in range %p to %p to %s ret = %d\n", - (void *)addr, (void *)(addr + size), - remote_owner ? "mss" : "hlos", ret); + phys_addr_t end = addr + size; + pr_err("Failed to assign memory access in range %pap to %pap to %s ret = %d\n", + &addr, &end, remote_owner ? "mss" : "hlos", ret); return ret; }