From patchwork Fri Mar 23 13:04:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 10304687 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F0C6660386 for ; Fri, 23 Mar 2018 13:09:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2B3028E65 for ; Fri, 23 Mar 2018 13:09:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D786728E6B; Fri, 23 Mar 2018 13:09:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8109328E65 for ; Fri, 23 Mar 2018 13:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbeCWNJG (ORCPT ); Fri, 23 Mar 2018 09:09:06 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:41398 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752935AbeCWNFI (ORCPT ); Fri, 23 Mar 2018 09:05:08 -0400 Received: by mail-wr0-f196.google.com with SMTP id f14so12054771wre.8 for ; Fri, 23 Mar 2018 06:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U1TfO8aiHw1+4sjUXHFMzAyxiOYHnHiizDs5ufLc9rY=; b=eFTbw1ivENBYVBUUs3ILyz0lbbQn7Mph1IQPR1GFf6YWROrPVlRwgt2tM0SVntYXcR xSrkkY3uW6J2l+3a6NpBF750/gPMLlsEW8HnFGRSx994bLRcG+exMalV2MEgUccPcZiC ZKh4gWxy3ndfYRhuZZ9Tb1cFhW1WpZXH8XazhbGgqsY1tPBMLPkls1LxMdMSzeAYkktV u/USp+dJtcOIpKUc0eHY7toqGLSKpfH+lFn7+BWLimWTA4+J5SFhbfrYDEHPGyjv2NZ6 CHMQFulCd0qPRHXzejmLfUDjw8gnOHxH5ElNwdZAcxfQ73pL1wwZqWy5giwTNn0bzAI7 yRIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U1TfO8aiHw1+4sjUXHFMzAyxiOYHnHiizDs5ufLc9rY=; b=SptGhO32gFyDuGUxLEnhJ7jkIwS8QqYjqZ10A4Z4/9xBSNgPO5RiZ3CbxlwSgwiVeu JcgQJyswaSx4xvicoQTgVV9XTmJQP3helE/B0Xz8LD0rNDtMGWcfE+JsydR6mxCF5nfG NYE/CxCVKNXEGHN29IoXbdUQF9TBneMIQLEz/TvzCAixSmu8bI8ZEZ2zNj4J7Z1d8cd8 Bl18n1mGERbvDiHOoCYn8ti3IkOanW1WOIC6Mc33q67Av/jKmwfey3yScTXG5kHAlQ9r WLsuIUq/turuQpAdrfywQjUd7h5fDnYdONjPpmlE0txFaMt6ibrd/jFkLZZvb78JfEhZ bjGQ== X-Gm-Message-State: AElRT7GbxWGCm9DX26fU1JPrS/VARMDnpw4TQq1VP4KxznAWr33KBuL/ k29Yo0MkpeOFW3KbwR9bRrf3nw== X-Google-Smtp-Source: AG47ELuyIYt1a7L+Le1gC0Czh6f+MaN2HDnC2jcpJUJMCCE2xWXguswFEH+fZYVA+q4cxWnJsXTO0Q== X-Received: by 10.223.185.73 with SMTP id b9mr22988941wrg.229.1521810307352; Fri, 23 Mar 2018 06:05:07 -0700 (PDT) Received: from brgl-bgdev.lan (LFbn-1-7086-217.w90-116.abo.wanadoo.fr. [90.116.254.217]) by smtp.gmail.com with ESMTPSA id x67sm7069964wma.5.2018.03.23.06.05.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Mar 2018 06:05:06 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Rob Herring , Mark Rutland , Russell King , David Lechner , Michael Turquette , Stephen Boyd , Ohad Ben-Cohen , Bjorn Andersson , Philipp Zabel Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-remoteproc@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v4 5/8] remoteproc: da8xx: add the missing retval check for clk_enable() Date: Fri, 23 Mar 2018 14:04:52 +0100 Message-Id: <20180323130455.11470-6-brgl@bgdev.pl> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180323130455.11470-1-brgl@bgdev.pl> References: <20180323130455.11470-1-brgl@bgdev.pl> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartosz Golaszewski The davinci platform is being switched to using the common clock framework, where clk_enable() can fail. Add the return value check. Signed-off-by: Bartosz Golaszewski Acked-by: Suman Anna --- drivers/remoteproc/da8xx_remoteproc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c index bf3b9034c319..2b24291337b7 100644 --- a/drivers/remoteproc/da8xx_remoteproc.c +++ b/drivers/remoteproc/da8xx_remoteproc.c @@ -138,6 +138,7 @@ static int da8xx_rproc_start(struct rproc *rproc) struct device *dev = rproc->dev.parent; struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv; struct clk *dsp_clk = drproc->dsp_clk; + int ret; /* hw requires the start (boot) address be on 1KB boundary */ if (rproc->bootaddr & 0x3ff) { @@ -148,7 +149,12 @@ static int da8xx_rproc_start(struct rproc *rproc) writel(rproc->bootaddr, drproc->bootreg); - clk_enable(dsp_clk); + ret = clk_enable(dsp_clk); + if (ret) { + dev_err(dev, "clk_enable() failed: %d\n", ret); + return ret; + } + davinci_clk_reset_deassert(dsp_clk); return 0;