From patchwork Tue Mar 27 09:20:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 10309647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1A6DC60353 for ; Tue, 27 Mar 2018 09:23:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0776D29BEE for ; Tue, 27 Mar 2018 09:23:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EEB0C29C1D; Tue, 27 Mar 2018 09:23:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F18429BEE for ; Tue, 27 Mar 2018 09:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbeC0JWl (ORCPT ); Tue, 27 Mar 2018 05:22:41 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33898 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbeC0JUm (ORCPT ); Tue, 27 Mar 2018 05:20:42 -0400 Received: by mail-wr0-f194.google.com with SMTP id o8so21635442wra.1 for ; Tue, 27 Mar 2018 02:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GjNGu1a1C6nTUDAr1cwJbdU8qk0eOqfPmLDOO9cSlLo=; b=iot9M+JIsoiZDXKcuUfMHve5IbX5YLJ5zKQhNcdxdubj0zHh7QPrh/DHwyaRTldQj5 DxZJsbomlJIS/jRKvR3Q0GbzT6FwQaZhAjxQbpgQjl41Fs+ZKZKC8FJn/ImMY/tCip1U BNhFR0UwblXYO3JqGBmP2f03zLtnpxEIcCLMb5q0NL9B7sz8HzQHJgKxLpervYkPXASw /4XzLeB9wqfayncFB9KCgJmwT4UVteBOPb4HeneysGyIFhPeiIIhfOmRcp2dk0Sr4zLV m5o23IAhrjeLcGfWI3CAre2VLHbySF8bYudcLdXSBYmGXJ6u2dQiOBPXp/+uuBU0gXmR icJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GjNGu1a1C6nTUDAr1cwJbdU8qk0eOqfPmLDOO9cSlLo=; b=DomJ7b6egnQzh8+PxrRdOKsFx6bCGaENYb8eU1WU6wpww18gJlM+Ot170N4eXf9f3O mwt9ahyG1lwPXwMWK7nTU7zQl/u7IkxsSiKb/wU/t/yCTpe5gACLjaiAwaA124HUhLJ+ 4NErvGKJ6bT2Ld6kM42GHS4fAEAz9f+GmFIDwdMDE0UXGPVbOpHxMBY93+xh/TPOtX9y hDCtEOB4reMi3YdtbZjkTH/lkeIPdgyMbBDScLGr3lfgOTOi1hukSY5dwGcKxwPLUx2D syFxsqpOD6JoRoMOad4OV3HIPOR1a+b/N8TiI234+PlnhmrLX/pJBwiFVGhLPMaXzJSR vr4g== X-Gm-Message-State: AElRT7H2XmfV/r06+2ZtigX3gdYFYPu0+uDW9/iACYaHb1LPShGIJwxX K320wjW2qEBcdkBXeI+gFcTwhmCXjyc= X-Google-Smtp-Source: AG47ELu9vlw6Q3kCFDdLXQtXzh6BniPjRwycnAaHBUVK1rJGFDcEbwws8IEQsOvOFsIi3kkqW6mzYQ== X-Received: by 10.223.143.7 with SMTP id p7mr32391686wrb.207.1522142441019; Tue, 27 Mar 2018 02:20:41 -0700 (PDT) Received: from brgl-bgdev.baylibre.local ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id h190sm1288925wmd.22.2018.03.27.02.20.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Mar 2018 02:20:40 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Rob Herring , Mark Rutland , Russell King , David Lechner , Michael Turquette , Stephen Boyd , Ohad Ben-Cohen , Bjorn Andersson , Philipp Zabel Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-remoteproc@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 4/8] remoteproc/davinci: add the missing retval check for clk_enable() Date: Tue, 27 Mar 2018 11:20:27 +0200 Message-Id: <20180327092031.11251-5-brgl@bgdev.pl> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180327092031.11251-1-brgl@bgdev.pl> References: <20180327092031.11251-1-brgl@bgdev.pl> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartosz Golaszewski The davinci platform is being switched to using the common clock framework, where clk_enable() can fail. Add the return value check. Signed-off-by: Bartosz Golaszewski Acked-by: Suman Anna --- drivers/remoteproc/da8xx_remoteproc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c index bf3b9034c319..2b24291337b7 100644 --- a/drivers/remoteproc/da8xx_remoteproc.c +++ b/drivers/remoteproc/da8xx_remoteproc.c @@ -138,6 +138,7 @@ static int da8xx_rproc_start(struct rproc *rproc) struct device *dev = rproc->dev.parent; struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv; struct clk *dsp_clk = drproc->dsp_clk; + int ret; /* hw requires the start (boot) address be on 1KB boundary */ if (rproc->bootaddr & 0x3ff) { @@ -148,7 +149,12 @@ static int da8xx_rproc_start(struct rproc *rproc) writel(rproc->bootaddr, drproc->bootreg); - clk_enable(dsp_clk); + ret = clk_enable(dsp_clk); + if (ret) { + dev_err(dev, "clk_enable() failed: %d\n", ret); + return ret; + } + davinci_clk_reset_deassert(dsp_clk); return 0;