From patchwork Mon Jul 9 15:12:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sibi Sankar X-Patchwork-Id: 10514867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 22F7260318 for ; Mon, 9 Jul 2018 15:12:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12CE8289B1 for ; Mon, 9 Jul 2018 15:12:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06E5128D2C; Mon, 9 Jul 2018 15:12:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B113289B1 for ; Mon, 9 Jul 2018 15:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933611AbeGIPMe (ORCPT ); Mon, 9 Jul 2018 11:12:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43674 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933299AbeGIPMc (ORCPT ); Mon, 9 Jul 2018 11:12:32 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4A0C8606AC; Mon, 9 Jul 2018 15:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1531149152; bh=g+TvRpVx09570I3bQK4yvqg3hH9WdZv2ulCIAKQ7HpM=; h=From:To:Cc:Subject:Date:From; b=PNSvxhSBgg7XHfbUqsXj2zCA/7O9KSRQ0KMg9lITROtybe0XpXhzco8Edu7g2v0Pe uTlcYO2l+/8goDjJas6h96S42SuC6tPwvJ9NmG1ziu4BF415ujt8Zs65YSjrhQuMAp voFPhCWPdcHOGkEtWkbwSpQE1J0wQWqvVRbjO8v0= Received: from blr-ubuntu-87.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sibis@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 464DA6063F; Mon, 9 Jul 2018 15:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1531149151; bh=g+TvRpVx09570I3bQK4yvqg3hH9WdZv2ulCIAKQ7HpM=; h=From:To:Cc:Subject:Date:From; b=EhfMwSv5Nbz4NQJvkHxB/eWJL62mJq0+craTHE9aGYDNzaV95+GDZOMRizRARSPVu q3J9G2dfdBMj/Bf/o4fwE+WRGVuTnEMPykK+PrsKqkIXPGzLEnaTDyjlohXOrOiVHD uDxQaBdzs9XuvBzJgpapgP6oiXWLDwsffqcr4kq0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 464DA6063F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sibis@codeaurora.org From: Sibi Sankar To: bjorn.andersson@linaro.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, ohad@wizery.com, kyan@codeaurora.org, sricharan@codeaurora.org, akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org, tsoni@codeaurora.org, Sibi Sankar Subject: [PATCH] remoteproc: qcom: q6v5-pil: fix modem hang on SDM845 after axis2 clk unvote Date: Mon, 9 Jul 2018 20:42:20 +0530 Message-Id: <20180709151220.12641-1-sibis@codeaurora.org> X-Mailer: git-send-email 2.17.0 Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP GCC_MSS_AXIS2 clock is used for disabling boot IMEM (a part of AP boot up). With Boot IMEM disable now a part TZ/ATF, AXIS2 clock is no longer required post AP boot up and expected to remain untouched. However if the clock is turned ON after Q6 is brought out of reset and later turned off, it results in modem hang. When Q6 attempts a power collapse the internal handshaking to check if AXIS2 is idle never goes through since it is turned off preventing the RSC from getting triggered, leaving modem in a funky state. Hence removing AXIS2 clk enable/disable from the driver. [bjorn: identified unvoting axis2 clk caused modem hang] Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_pil.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index e04319573c91..d7a4b9eca5d2 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -1243,7 +1243,6 @@ static const struct rproc_hexagon_res sdm845_mss = { .hexagon_mba_image = "mba.mbn", .proxy_clk_names = (char*[]){ "xo", - "axis2", "prng", NULL },