| Message ID | 20200324220329.15523-3-mathieu.poirier@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | remoteproc: stm32: Add support for synchronisation with MCU | expand |
> -----Original Message----- > From: Mathieu Poirier <mathieu.poirier@linaro.org> > Sent: mardi 24 mars 2020 23:03 > To: bjorn.andersson@linaro.org > Cc: ohad@wizery.com; Loic PALLARDY <loic.pallardy@st.com>; s- > anna@ti.com; peng.fan@nxp.com; Arnaud POULIQUEN > <arnaud.pouliquen@st.com>; Fabien DESSENNE > <fabien.dessenne@st.com>; linux-remoteproc@vger.kernel.org > Subject: [PATCH 02/11] remoteproc: stm32: Request IRQ with platform > device > > Request IRQ with platform device rather than remote proc in order to > call stm32_rproc_parse_dt() before rproc_alloc(). That way we can > know whether we need to synchronise with the MCU or not. > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Thanks Mathieu Reviewed-by: Loic Pallardy <loic.pallardy@st.com> > --- > drivers/remoteproc/stm32_rproc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c > b/drivers/remoteproc/stm32_rproc.c > index cde4b1a56381..0c1f0b84e057 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -261,7 +261,8 @@ static int stm32_rproc_parse_fw(struct rproc *rproc, > const struct firmware *fw) > > static irqreturn_t stm32_rproc_wdg(int irq, void *data) > { > - struct rproc *rproc = data; > + struct platform_device *pdev = data; > + struct rproc *rproc = platform_get_drvdata(pdev); > > rproc_report_crash(rproc, RPROC_WATCHDOG); > > @@ -553,7 +554,7 @@ static int stm32_rproc_parse_dt(struct > platform_device *pdev) > > if (irq > 0) { > err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0, > - dev_name(dev), rproc); > + dev_name(dev), pdev); > if (err) { > dev_err(dev, "failed to request wdg irq\n"); > return err; > -- > 2.20.1
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index cde4b1a56381..0c1f0b84e057 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc/stm32_rproc.c @@ -261,7 +261,8 @@ static int stm32_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw) static irqreturn_t stm32_rproc_wdg(int irq, void *data) { - struct rproc *rproc = data; + struct platform_device *pdev = data; + struct rproc *rproc = platform_get_drvdata(pdev); rproc_report_crash(rproc, RPROC_WATCHDOG); @@ -553,7 +554,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev) if (irq > 0) { err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0, - dev_name(dev), rproc); + dev_name(dev), pdev); if (err) { dev_err(dev, "failed to request wdg irq\n"); return err;
Request IRQ with platform device rather than remote proc in order to call stm32_rproc_parse_dt() before rproc_alloc(). That way we can know whether we need to synchronise with the MCU or not. Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/remoteproc/stm32_rproc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)