| Message ID | 20200713020003.134039-1-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0cf17702d872128fc2bec79a9578b5cb00d54a11 |
| Headers | show |
| Series | [-next] remoteproc: qcom: Add missing slab.h | expand |
On 7/12/20 9:00 PM, Kefeng Wang wrote: > drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’: > drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’? > [-Werror=implicit-function-declaration] > info = kzalloc(sizeof(*info), GFP_KERNEL); > ^~~~~~~ > vzalloc > > kzalloc() is declared in linux/slab.h, add include to fix build issue. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/remoteproc/qcom_common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c > index 2f45f0c79914e..085fd73fa23ae 100644 > --- a/drivers/remoteproc/qcom_common.c > +++ b/drivers/remoteproc/qcom_common.c > @@ -15,6 +15,7 @@ > #include <linux/remoteproc/qcom_rproc.h> > #include <linux/rpmsg/qcom_glink.h> > #include <linux/rpmsg/qcom_smd.h> > +#include <linux/slab.h> > #include <linux/soc/qcom/mdt_loader.h> > > #include "remoteproc_internal.h" You beat me to it. I just build-tested this fix on linux-next/master and can confirm the build fails without it, succeeds with it. -Alex
On Sun 12 Jul 19:00 PDT 2020, Kefeng Wang wrote: > drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’: > drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’? > [-Werror=implicit-function-declaration] > info = kzalloc(sizeof(*info), GFP_KERNEL); > ^~~~~~~ > vzalloc > > kzalloc() is declared in linux/slab.h, add include to fix build issue. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Thank Kefeng, patch applied. Regards, Bjorn > --- > drivers/remoteproc/qcom_common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c > index 2f45f0c79914e..085fd73fa23ae 100644 > --- a/drivers/remoteproc/qcom_common.c > +++ b/drivers/remoteproc/qcom_common.c > @@ -15,6 +15,7 @@ > #include <linux/remoteproc/qcom_rproc.h> > #include <linux/rpmsg/qcom_glink.h> > #include <linux/rpmsg/qcom_smd.h> > +#include <linux/slab.h> > #include <linux/soc/qcom/mdt_loader.h> > > #include "remoteproc_internal.h" > -- > 2.26.2 >
Hello: This patch was applied to andersson/remoteproc.git (refs/heads/for-next). On Mon, 13 Jul 2020 10:00:03 +0800 you wrote: > drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’: > drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’? > [-Werror=implicit-function-declaration] > info = kzalloc(sizeof(*info), GFP_KERNEL); > ^~~~~~~ > vzalloc > > [...] Here is a summary with links: - [-next] remoteproc: qcom: Add missing slab.h https://git.kernel.org/andersson/remoteproc/c/0cf17702d872128fc2bec79a9578b5cb00d54a11 You are awesome, thank you!
diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c index 2f45f0c79914e..085fd73fa23ae 100644 --- a/drivers/remoteproc/qcom_common.c +++ b/drivers/remoteproc/qcom_common.c @@ -15,6 +15,7 @@ #include <linux/remoteproc/qcom_rproc.h> #include <linux/rpmsg/qcom_glink.h> #include <linux/rpmsg/qcom_smd.h> +#include <linux/slab.h> #include <linux/soc/qcom/mdt_loader.h> #include "remoteproc_internal.h"
drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’: drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’? [-Werror=implicit-function-declaration] info = kzalloc(sizeof(*info), GFP_KERNEL); ^~~~~~~ vzalloc kzalloc() is declared in linux/slab.h, add include to fix build issue. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- drivers/remoteproc/qcom_common.c | 1 + 1 file changed, 1 insertion(+)