| Message ID | 20201107233630.9728-3-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0eee3d28ff6572f0e1afd41e863e44d396a308e2 |
| Headers | show |
| Series | remoteproc: Constify static struct rproc_ops | expand |
Hi Rikard, On 11/8/20 12:36 AM, Rikard Falkeborn wrote: > The only usage of st_rproc_ops is to pass its address to rproc_alloc() > which accepts a const pointer. Make it const to allow the compiler to > put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index d2414cc1d90d..a180aeae9675 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -541,7 +541,7 @@ static void stm32_rproc_kick(struct rproc *rproc, int vqid) > } > } > > -static struct rproc_ops st_rproc_ops = { > +static const struct rproc_ops st_rproc_ops = { > .start = stm32_rproc_start, > .stop = stm32_rproc_stop, > .attach = stm32_rproc_attach, > acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Thanks, Arnaud
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index d2414cc1d90d..a180aeae9675 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc/stm32_rproc.c @@ -541,7 +541,7 @@ static void stm32_rproc_kick(struct rproc *rproc, int vqid) } } -static struct rproc_ops st_rproc_ops = { +static const struct rproc_ops st_rproc_ops = { .start = stm32_rproc_start, .stop = stm32_rproc_stop, .attach = stm32_rproc_attach,
The only usage of st_rproc_ops is to pass its address to rproc_alloc() which accepts a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/remoteproc/stm32_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)