| Message ID | 20201122234540.34623-1-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dd8f52660cb1f6fac0b4cc8adb3f008edd2c14d2 |
| Headers | show |
| Series | remoteproc: qcom_sysmon: Constify qmi_indication_handler | expand |
Hello: This patch was applied to andersson/remoteproc.git (refs/heads/for-next): On Mon, 23 Nov 2020 00:45:40 +0100 you wrote: > The only usage of qmi_indication_handler[] is to pass its address to > qmi_handle_init() which accepts a const pointer. Make it const to allow > the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > drivers/remoteproc/qcom_sysmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - remoteproc: qcom_sysmon: Constify qmi_indication_handler https://git.kernel.org/andersson/remoteproc/c/dd8f52660cb1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c index 9eb2f6bccea6..6c3275b58c36 100644 --- a/drivers/remoteproc/qcom_sysmon.c +++ b/drivers/remoteproc/qcom_sysmon.c @@ -283,7 +283,7 @@ static void sysmon_ind_cb(struct qmi_handle *qmi, struct sockaddr_qrtr *sq, complete(&sysmon->ind_comp); } -static struct qmi_msg_handler qmi_indication_handler[] = { +static const struct qmi_msg_handler qmi_indication_handler[] = { { .type = QMI_INDICATION, .msg_id = SSCTL_SHUTDOWN_READY_IND,
The only usage of qmi_indication_handler[] is to pass its address to qmi_handle_init() which accepts a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/remoteproc/qcom_sysmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)