From patchwork Fri Jan 14 13:32:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 12713633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF3AC433EF for ; Fri, 14 Jan 2022 13:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236861AbiANNdV (ORCPT ); Fri, 14 Jan 2022 08:33:21 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57896 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231860AbiANNdV (ORCPT ); Fri, 14 Jan 2022 08:33:21 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2ADCB1F46992 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1642167199; bh=bIGZkqg8TQB584qijqAGY+JJJVnU59xCz/eRyLXwgkI=; h=From:To:Cc:Subject:Date:From; b=c5xKYpgSzYg0CLKJsgl7jrbku95RwK5bFFjlw7yyT9Nz+yuzagvspFdbKMAKOsMi1 Hq0GGOPfQXh9rWbmanKrVXZpogKs0WbrEb/31KMoFTi9sqgMCFTkZtb/UfsJ9r02Ij dhc2no736Q3KKl9d2rtsdSvEpk5H+KRbo9CIAohmwvZw5y5DZNX2lmg9F4CImiJBGx GeqUtjv0uWfaVIcL5ZZDO2wZYMvocWWBH69QsNJZXZEZ6w5z9WzwtgWK2ls6WZ/Us9 3ldfMfw8W6BvshG4g7GmX5SzBYRV9has5kA5aDuzvfXal6zDxXudEFOiX6fWg6rAI6 byF9mb1dXHWeA== From: AngeloGioacchino Del Regno To: agross@kernel.org Cc: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno Subject: [PATCH v2] rpmsg: qcom_smd: Fix redundant channel->registered assignment Date: Fri, 14 Jan 2022 14:32:59 +0100 Message-Id: <20220114133259.247726-1-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org In qcom_channel_state_worker(), we are setting channel->registered to true when registering a channel, but this is getting repeated both before and after re-locking the channels_lock spinlock, which is obviously a typo. Remove the assignment done out of the spinlock to fix this redundancy. Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend") Signed-off-by: AngeloGioacchino Del Regno --- v2: Fixed funny typo in commit title (channel->assigned => channel->registered) drivers/rpmsg/qcom_smd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 540e027f08c4..0ee3f7ddabb0 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1298,9 +1298,7 @@ static void qcom_channel_state_worker(struct work_struct *work) spin_unlock_irqrestore(&edge->channels_lock, flags); qcom_smd_create_device(channel); - channel->registered = true; spin_lock_irqsave(&edge->channels_lock, flags); - channel->registered = true; }