diff mbox series

[V4] remoteproc: imx_rproc: Ignore create mem entry for resource table

Message ID 20220415025737.1561976-1-peng.fan@oss.nxp.com (mailing list archive)
State Accepted
Headers show
Series [V4] remoteproc: imx_rproc: Ignore create mem entry for resource table | expand

Commit Message

Peng Fan (OSS) April 15, 2022, 2:57 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

Resource table is used by Linux to get information published by
remote processor. It should be not be used for memory allocation, so
not create rproc mem entry.

Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V4:
 Typo fix
 use strcmp, not strncmp

V3:
 Update commit log
 Update Fixes tag

V2:
 Add Fixes tag
 Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
 Address typo


 drivers/remoteproc/imx_rproc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mathieu Poirier April 18, 2022, 5:13 p.m. UTC | #1
On Fri, Apr 15, 2022 at 10:57:37AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Resource table is used by Linux to get information published by
> remote processor. It should be not be used for memory allocation, so
> not create rproc mem entry.
> 
> Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V4:
>  Typo fix
>  use strcmp, not strncmp
> 
> V3:
>  Update commit log
>  Update Fixes tag
> 
> V2:
>  Add Fixes tag
>  Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
>  Address typo
> 
> 
>  drivers/remoteproc/imx_rproc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..91eb037089ef 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
>  		if (!strcmp(it.node->name, "vdev0buffer"))
>  			continue;
>  
> +		if (!strcmp(it.node->name, "rsc-table"))
> +			continue;
> +

Applied.

Thanks,
Mathieu

>  		rmem = of_reserved_mem_lookup(it.node);
>  		if (!rmem) {
>  			dev_err(priv->dev, "unable to acquire memory-region\n");
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 7a096f1891e6..91eb037089ef 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -423,6 +423,9 @@  static int imx_rproc_prepare(struct rproc *rproc)
 		if (!strcmp(it.node->name, "vdev0buffer"))
 			continue;
 
+		if (!strcmp(it.node->name, "rsc-table"))
+			continue;
+
 		rmem = of_reserved_mem_lookup(it.node);
 		if (!rmem) {
 			dev_err(priv->dev, "unable to acquire memory-region\n");