| Message ID | 20220921043648.2152725-4-sireeshkodali1@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: qcom: Add support for pronto-v3 | expand |
On Wed, 21 Sep 2022 10:06:47 +0530, Sireesh Kodali wrote: > This is not a fallback compatible, it must be present in addition to > "qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This > is the reason for documenting it in a separate commit. > > This compatible is used in the wcn36xx driver to determine which > register must be accessed. However it isn't immediately clear why the > wcn36xx driver relies on this extra compatible string rather than just > looking for "qcom,pronto-v*". > > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> > --- > .../bindings/remoteproc/qcom,wcnss-pil.yaml | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ remoteproc@fb21b000: 'power-domain-names' is a required property arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb remoteproc@fb21b000: 'power-domains' is a required property arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb
On 21/09/2022 06:36, Sireesh Kodali wrote: > This is not a fallback compatible, it must be present in addition to > "qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This > is the reason for documenting it in a separate commit. > > This compatible is used in the wcn36xx driver to determine which > register must be accessed. However it isn't immediately clear why the > wcn36xx driver relies on this extra compatible string rather than just > looking for "qcom,pronto-v*". Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index a99a1e5242f8..31232c59b22b 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -15,10 +15,15 @@ description: properties: compatible: - enum: - - qcom,riva-pil - - qcom,pronto-v1-pil - - qcom,pronto-v2-pil + description: + Append "qcom,pronto" if the device is actually pronto, and not riva + oneOf: + - items: + - enum: + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + - const: qcom,pronto + - const: qcom,riva-pil reg: maxItems: 3 @@ -198,7 +203,7 @@ examples: #include <dt-bindings/clock/qcom,rpmcc.h> #include <dt-bindings/power/qcom-rpmpd.h> pronto@a21b000 { - compatible = "qcom,pronto-v2-pil"; + compatible = "qcom,pronto-v2-pil", "qcom,pronto"; reg = <0x0a204000 0x2000>, <0x0a202000 0x1000>, <0x0a21b000 0x3000>; reg-names = "ccu", "dxe", "pmu";
This is not a fallback compatible, it must be present in addition to "qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This is the reason for documenting it in a separate commit. This compatible is used in the wcn36xx driver to determine which register must be accessed. However it isn't immediately clear why the wcn36xx driver relies on this extra compatible string rather than just looking for "qcom,pronto-v*". Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> --- .../bindings/remoteproc/qcom,wcnss-pil.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)