| Message ID | 20230213231931.6546-2-bage@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable hwlock on Allwinner A64 | expand |
On Tue, 14 Feb 2023 00:19:28 +0100 Bastian Germann <bage@debian.org> wrote: > The allwinner,sun6i-a31-hwspinlock.yaml binding needs #hwlock-cells > which is required by the hwlock type. > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > Signed-off-by: Bastian Germann <bage@debian.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > index 10e5a53e447b..01b1bbb3061f 100644 > --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > @@ -26,11 +26,15 @@ properties: > resets: > maxItems: 1 > > + '#hwlock-cells': > + const: 1 > + > required: > - compatible > - reg > - clocks > - resets > + - "#hwlock-cells" > > additionalProperties: false >
On 14/02/2023 00:19, Bastian Germann wrote: > The allwinner,sun6i-a31-hwspinlock.yaml binding needs #hwlock-cells > which is required by the hwlock type. > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > Signed-off-by: Bastian Germann <bage@debian.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, 14 Feb 2023 00:19:28 +0100, Bastian Germann wrote: > The allwinner,sun6i-a31-hwspinlock.yaml binding needs #hwlock-cells > which is required by the hwlock type. > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > Signed-off-by: Bastian Germann <bage@debian.org> > --- > .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.example.dtb: hwlock@1c18000: '#hwlock-cells' is a required property From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230213231931.6546-2-bage@debian.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Feb 13, 2023 at 5:20 PM Bastian Germann <bage@debian.org> wrote: > > The allwinner,sun6i-a31-hwspinlock.yaml binding needs #hwlock-cells > which is required by the hwlock type. > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > Signed-off-by: Bastian Germann <bage@debian.org> > --- > .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 4 ++++ > 1 file changed, 4 insertions(+) Now failing in linux-next as reported. Please send a fix. Rob
Am 15.02.23 um 15:07 schrieb Rob Herring:
> Now failing in linux-next as reported. Please send a fix.
That is in v2 2/5.
diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index 10e5a53e447b..01b1bbb3061f 100644 --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -26,11 +26,15 @@ properties: resets: maxItems: 1 + '#hwlock-cells': + const: 1 + required: - compatible - reg - clocks - resets + - "#hwlock-cells" additionalProperties: false
The allwinner,sun6i-a31-hwspinlock.yaml binding needs #hwlock-cells which is required by the hwlock type. Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") Signed-off-by: Bastian Germann <bage@debian.org> --- .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 4 ++++ 1 file changed, 4 insertions(+)