From patchwork Fri Jul 12 08:34:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13731399 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010054.outbound.protection.outlook.com [52.101.69.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 661AB143758; Fri, 12 Jul 2024 08:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720772774; cv=fail; b=I59k79oBR6AekQDJA4ZcLqyoAsdq72eRiCtDJ4lOFOgEZOJvFE0NOO1GoaN5m63XG/rmj3ZzM9FoH5coRIYsB4UeeSLpBR4o0RIt9xrbeZlN4RkP2zZWe9AZyg40uxhZfsxMWUrqp45TzIR5Hw+71XJR7mKl3rBYhhkkjxTwFDw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720772774; c=relaxed/simple; bh=YtyxW0v6xd2Oi+TbQ8vQLzd1o6q+eAQL4yq5VB5TBF0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WP9RxZzdyEjlhSZ4e+smK8bvWE4gX7XUOvQa6cLuTE7qQLhBVPlFbpM6Dwrg+RPLkBYqcsDgFQZIu7XmHS/RY9jpOJmbr978TromnFViVavvl7jbQpohHHL319dbgQpVwo80VR4oWxydXkYrtP0/pqP0IyiMJkyMt+DmUaTLD2s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=gKMpYrBJ; arc=fail smtp.client-ip=52.101.69.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="gKMpYrBJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U5HKPn7Lc1PEwsRK0dECs1T0/9qCWQe6SsT1ObyTwE+oHyCGGoAe+wmw2iZY0N/Y1fNFJyTKBiKcmXBnIWuikc1gkX7RwLGP+0ryimtvo2v/4sFMV1ZtSSI8JYsvq0fjIr901NaeWQ7RrCocXWyGzvctMlliJ/22akrrlSAAl5ijc6X/G9fbRQMmTmThEllRYuaO5DN0ifGmuVHIyR5eUWP0IBHZEs54XqpuzF9WsouGFz72Ka5OxjUzZBNPoVtEv0uC8CvpnO2IaMD89MsbpI+L27mLDgiMZdYJ6L6TAEi53M8U+n5wR9OX+WIP7/unLfwlaMgUF5/UONhWhebjAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2oWHKCUVfvrNAzxd6DC9qQ+keZBb/vPFAM96MmrhN6M=; b=XaPDaKBrlGhQhZIiOz2sU92hNDaXoKitU4sllqa32fcU/mDro0DWgi2B1M1jweNXZMC6p5NDp92tEtataGYCD4NgeFUhxvaiz/5Uit+i5bJqiOwhdsLuCXtX8eC0EfFOhA+I2nchLapGNhBYkxic1wE190XXV81ZbdHj0Tzb6SPmm7zA0pCcv6gf4hl5UtOGUNcVoSjS338iksebnUTgpvKTWHUEIweLhHXorkDYa+uwzCbf83Dc3W9p9hjo/eB6I2UPxRKpNezISrE4iZAWCr7v7jGdcp60ECkuOLwsFqcudRc3gEbSlQonugDdRlDBztbnTQGlkKId1ASKANWxAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2oWHKCUVfvrNAzxd6DC9qQ+keZBb/vPFAM96MmrhN6M=; b=gKMpYrBJ8SAWNlUZvNs21utDcOC3eRQ2YwKnAohXI0d+TJvWDhOFJXvWSL1Z3oP/TiSsowX1XRgu6XHP5AvxME0/M67qw191v0hQsFeXdHyz/856h9MO8wE64K8hCuY96eu8BaB3Q6IrxLapEq/NLSz46sj1BpbNBtuDBEVvYrk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DU2PR04MB8709.eurprd04.prod.outlook.com (2603:10a6:10:2dc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Fri, 12 Jul 2024 08:26:09 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.7762.020; Fri, 12 Jul 2024 08:26:09 +0000 From: "Peng Fan (OSS)" Date: Fri, 12 Jul 2024 16:34:56 +0800 Subject: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier Message-Id: <20240712-imx_rproc-v1-3-7bcf6732d328@nxp.com> References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> In-Reply-To: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1720773307; l=1089; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=30BtbG0V4zrqqgPMiZOOg2E1J67bBTLgehXqosatdF4=; b=sPaOPV7FaSLgnsmRzqAItmpVuWs1UFpyRjcdsJmJqR2xWS3+WdjW02OMOo42y2XHPZ35WUGep UPBQhkoHycUA8tS0Y0yyPKyZSNFqBPrzjrQ8uuZ6/zkFSgoOL36fq9L X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0013.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::12) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DU2PR04MB8709:EE_ X-MS-Office365-Filtering-Correlation-Id: c872be37-318a-4c30-84a4-08dca24c4816 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?5WiLC7AXO74F8dnvES7zWPRBNZET3dI?= =?utf-8?q?Av21CdN3f/Q7RdLXnn/1tmuPZ+ZJDi8LMA0/DW7EC6NLeErZ9FF4vKCEMCakBUqDe?= =?utf-8?q?EQjg+lZim/6EA4dlG2kkE7Dhx6sKYXim+CdISyfD3HVDZpC1t7CgtOFkTndTROxkN?= =?utf-8?q?3UqMDkW9Bfj/cY4kNJ9MOXCOHqE3RiWHxYsZrssKemG6td76GRS/EFGmrgRr5FVAT?= =?utf-8?q?bRSaYvNStSIappLOzNjo9oOctEXbDLyPCwFnuWrpVIwPo1yTFXjv3adQFJqqx+DjP?= =?utf-8?q?aRfE/Pvriqurd5aMq8lnPILdAGnfm6tZ5mDRfl6IBH3GjPxUtJ6aWxL4O7JUN7H1K?= =?utf-8?q?QTEGIhmhm4ICD3d4LiQj2BEPzoXZ2v6AntJhMLNHWTGtzJUUTLBMQxvf9ulD0V3Yn?= =?utf-8?q?fxqC0izakdlAboHVnlFAUs9uOEYLfQsRMuNm78ik/UKFSssjKppTKxMSv86fFV6uQ?= =?utf-8?q?ENHdBbhgAfRUQ34xvBKWZXe+KhvN9YMLoRSxeaneCDjSc2ie+EpCNxmV5hXxkVBJC?= =?utf-8?q?a1roDdOwIS4qBQy1cM2OpIxGcc9puZ12CMkgeH6R52NDrNexT3rqshKb+4vaedIzM?= =?utf-8?q?EGgiapxkybAzhB+GqoAOpFty2lDC7qS83vtwjIhvPR59L0xW6aETbBeQqFtvBkm7M?= =?utf-8?q?pSregqaHmAtlo2TxUxt02yJCPgUXMWLvQcFAHbgTpcKT+rVmGAeAe4cd9EdZICHDz?= =?utf-8?q?nR1IepMidos3SfB7BMbHGAyh/YB6Dnuuf4ztoWB/5JXYL6ucYTW71pTLuR7VMYTnK?= =?utf-8?q?HkHxWu/ztXUrchfysUC3tAaxyAWqkANKb+JW3LHTyuXI9ljbM5VVYOwO7TAcvy0Om?= =?utf-8?q?ZW7dAaeGvbiJiDCFARcXh2BGJe79NWU5Mrfnl3aIG8CkLLVEMHKuL174jAVPeEK+k?= =?utf-8?q?ITYeBad2KLEDKi4oIdwGT8scyMFoNaFvWXT2qBwTRwG2O68cNvSq3i6jo8taR+iQK?= =?utf-8?q?UBv4H+jAbZjMTUcy9uPhpZovKzxbbrKy9WN//mFm8PcRXL5Gy8q1IFW/ajJYbQ5fL?= =?utf-8?q?OJLkqwIJ0UwqxBomlh7M7eN9DJB0iwQh2gpMQ8tHbgViK0OxLjTk9azsvEjaBHvmv?= =?utf-8?q?V7HTYS3aiMHh+sLAg50IZj3C4MBS1C3voL2InaBbKqrpXYzVD/Tr/R5ujkXGVQBvy?= =?utf-8?q?MCPFZfoqIjpsjjylrxoS4eGQuQ7XJN6r9dY9qW+u0d4W+HOCXsIoQpDV1UzEbkRI1?= =?utf-8?q?9N6+4tQBfcN+FpfcBdGaOzNPMQiXVxrafMd4yr1TcipVm5Iawwf07bkiEUlCQD/4+?= =?utf-8?q?rBuVoXClLJj3xlw1M93+VX+LeYYsSpwHCFGZOt6UEcEpPg+mcDLVUOh4e1ULYBc8+?= =?utf-8?q?uXGzpHi5EQzKa6RCzo/XRf4TdnYLKZYkfQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?iBwmtSWc8ssVK9UtgJdBovbyHOft?= =?utf-8?q?9aIvS199x81IW/uuKLCK9Vqc3jC0Z2x9+8k9IbyETTEsRuPZgIjusg5llH7mawhx6?= =?utf-8?q?SL8plDbl3gFZue49p1c1M9uRaw/nVIlynQyBXcK9+AM0vxiGJCL4cgQb4IvXBDX7Y?= =?utf-8?q?k0TIBt5WZGF3bFmcnnBvFgYVca8Mk7y5kVMKTR5ulYfskel5NN6dfoCWVJ2HvaD2r?= =?utf-8?q?tFRINcbOzRgQm2nKmPN3Mumb/G6XIpAY9WGU5RL3WEUwZ15UcRb5UPebBLp9iB6ND?= =?utf-8?q?e4gKLpf0uc8iywA8jCnOxZ0FhIYiKCWgWPTDhAfDBcRW2vCcgMDhjWQ85qMqCu7Cr?= =?utf-8?q?SJXqf7pWYdE35Z1SDVWsPoIP6YGT9HRnNaSdBwM4UlqAmVeDJouY0lecDxyvKMw7S?= =?utf-8?q?fXHk0RYcCp6BzE7UKli6U3Jf8Rsq9GFXd38YdcOFHbRW2mYAV8QvBBAwFftkmlLKT?= =?utf-8?q?E6EjfrdcUv4isYh6YQcv4Kf6/Yyt2W26cKYo8u5sj8+lmxTX7Sk2+R6RJTGh8g3Bt?= =?utf-8?q?3R+2GaC+5O9gfrH6g4uKJqzujCHtdpjGdskMeEB1tLlamOF+t+Z0mBGehHAO5URQN?= =?utf-8?q?ITpmn5wRPwKivgxH9G90IbVVdaFb5slSZD783GBrqzvgAbjkGLgq6qoQ9UoGY5TeC?= =?utf-8?q?XV2Xgt6iQ9ZH3Rca8KLTDiunYvDB+BXpTao+rFxSUXrwScsNG2Ns+dzwsr6qb0yRY?= =?utf-8?q?it2kSRlMFUAitXnozdnO5iVugRuAKn4wSlF3zjEMYC9GdfOVNyhbnK+FpMHnaKHCO?= =?utf-8?q?OBaPNhGHXdhKyx0A6FWMVNYw9TfW03HP0vaBz/uv/0h8Um2DlvV1Z9MIdKP1NN1d2?= =?utf-8?q?EJsDMFFJhMpkeMD4yjn0oNRT4KRWaiCXMkox6TjkmBVzTtXCF9fjco4L/x03BX4g7?= =?utf-8?q?umMWHFqqa17EhvDADxiyhjlDoyFAcl+wGMvv7ub8QFXFjUxTY81ukACJLKxDE5AHN?= =?utf-8?q?HDucNdEPtaLkY1SaO6lAewMSMtu1E9m8yIVoGKMXQKIrxtrjuIS2U6e4U1EmsQhFH?= =?utf-8?q?ghztBhaMenknrQ5bjbIE8Xkr3tfY9lGKr7TGwnG8YrVxliEaxe2MrEq2zH+j+NpYz?= =?utf-8?q?MAdplbE4KQSK2RBRVQuzEGIA7Fx7gy+bNKM3C9xcbPBm96sFRWjqTZyGaOlNuh4Kr?= =?utf-8?q?+SgMG00jOcB5mCOmI9UA3yGrpRjUixxlGNTlH12gMrRp7kqpiZKqzrqjTJVNsBuAg?= =?utf-8?q?vkgmQxVFI33KeNC09QZdxdbT9zy/2ZM2Rd/JtgdVdxxTlFpADJApVoHy5RCm2Lm3+?= =?utf-8?q?r9VK9bRnVP38y8VT18HTuzYk5jEipEoJh0gFjTucEwSTNypGMa8ug0nfxW1K5p8IX?= =?utf-8?q?QCRkRbiucrGg0BFpS3R02xYYCxhWzUromfQYijCJTv4BILDDlAHpisoyPMupJFbDP?= =?utf-8?q?+r3ubve1MXb7Cp9ySFAH/6nSqGXyOaG73fIeQfpkYdk8QnYU/yOzzDqR9eCuS69Sd?= =?utf-8?q?YdFoFYrifA5n+GZZCrs1HwEStQ/vI73QLm3KXHIc/vz9DUdI+jeCpfdr7KBAeibHu?= =?utf-8?q?MNfKySakLXyw?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c872be37-318a-4c30-84a4-08dca24c4816 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 08:26:09.1283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i/3FsvXXlpKiQ/trTpOcFR4nl3xo863+Q3hCN40j8EtqeFZbOykqanksKYZWDsDXTTsSzcC8QYzTeRWJSrSdUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8709 From: Peng Fan Initialize workqueue before requesting mailbox channel, otherwise if mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback will trigger issue. Reviewed-by: Richard Zhu Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 48c48b53a3aa..9e99bb27c033 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -1087,6 +1087,8 @@ static int imx_rproc_probe(struct platform_device *pdev) return -ENOMEM; } + INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); + ret = imx_rproc_xtr_mbox_init(rproc); if (ret) goto err_put_wkq; @@ -1105,8 +1107,6 @@ static int imx_rproc_probe(struct platform_device *pdev) if (ret) goto err_put_scu; - INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); - if (rproc->state != RPROC_DETACHED) rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot");