From patchwork Fri Jul 12 08:34:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13731401 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010054.outbound.protection.outlook.com [52.101.69.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB3B145FE9; Fri, 12 Jul 2024 08:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720772780; cv=fail; b=iDyW4VF68oEVukErbGR68LYxzDBsRRuk0IPByLIsCOFYeDC5lV9d8svD+aMuiCHQaCExMdjI8gkP/GAvyGQ1bw0nd934FQjienx7o3f+ZP68OFzipCdkj53BWuTRGrkShixXFY0QMwy0aWAubge0OUDa3yGERa1mOWu+gcq+UDE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720772780; c=relaxed/simple; bh=XJF6Xsho2Koc81UfvCWYce+LgposwVGbuNdUlbHpzrg=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=XgBNAAopMtcUTT1Go5w+EQbGE84kNupS/2ih+kOuIfnKYWaG6yQOgIYpa4GcTIqWrvQxUEErXPGSrp0JRhU2v0d2YEeodtMox4EQeC5JP3cI2U5UqAWgenL3U/vj6Ger+mSSCwq7kqfMUES7ui/rzv+ztbv9C+WTl0GkK7tHTV0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=HwQcagt/; arc=fail smtp.client-ip=52.101.69.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HwQcagt/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IlDzC5YJB3Ha+U/G2z73wdETtFwgrNZP+0Bm7Tuxs/tT/G/qmoGkYQHw4gmBGsK14s2vYmzcGPFXDYmOrJd2+xUfKXxAQfaVUyg+ur9XLHmB7HnuiHJSLSNB2Ef7tYyZ/CI6+FGWumaD/eej+cOEYxvXATDSBkNd+6eRdWmlqYhPKxuUxjwOiGiVXOsHddWSFte7lkchuJNMjQx6Cl/RglJyNuY4MeTXORK2JbxgO4N5b7ABGgTedQOxg02cRcIYQVDvwLLY7NOlxOER6W0G2KzAqyXsAIuQSKlsS0pogv1M14oqlo+k0i7mRkgrcIHuOJp2gdT3uzzoaKQNxBYiSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UUX6R497YRg7q1iy7q2/yhhuRn5+gy3qVyTi3N3KxUE=; b=X0N/tZh+qBAjMeYCGsmsi6axAStWR66yBanWheOLzT24TQitcKN5xULw8l+PNLgJpi19NyjK305iAI3fpEv+qpbPqn2BD9wp8izNqpp2Mc14KIjWcfZcdfLFIpzx5ix4lQKnbfmUd/6WTzhYRr0q2rS7l5YGBDmVeneOjH7aVOAmw+jr+KlZjs8Us0EvRl05IZr5I0VjOO4sj7Uq5NldM9fDpEIHSceikhir8w14rd/DR3aY86xuOd3VpI1WuZ+ncKiyOnKtBtKfxqE5/kBPhK1gzDPY/2MtndMtDqteb5uLRqcL0HwdPn63M9JUxo3xQZxf2DxSxNz9VD9YDVb7Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UUX6R497YRg7q1iy7q2/yhhuRn5+gy3qVyTi3N3KxUE=; b=HwQcagt/+X21LAIVTOgn+WxESDHHmC7rIZWGhx1Ycb0dujiey8i3CtevTsjmqDyqGzR+pSgryqJinyDfOLbZmhb0jh7xyBJk1ujGxGtOympdckybmfZgpG1Jwg0mgWEi2xzmSTeQFisuov2xb3iGx354UQ7OpRms8aZnyKijRuw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DU2PR04MB8709.eurprd04.prod.outlook.com (2603:10a6:10:2dc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Fri, 12 Jul 2024 08:26:16 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.7762.020; Fri, 12 Jul 2024 08:26:16 +0000 From: "Peng Fan (OSS)" Date: Fri, 12 Jul 2024 16:34:58 +0800 Subject: [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set Message-Id: <20240712-imx_rproc-v1-5-7bcf6732d328@nxp.com> References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> In-Reply-To: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1720773307; l=2319; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=p7aJwJNDnCiunEqGoMTxl7aI0DSNvgXZL6nZNHRBXks=; b=oVNucySmyuBcOoI187p7YzPR4LqOFvyuL+1dvez+QJLQtwHmN5kh+JyacHsrPnEKetmauw+5s NVZWqQS2JNxDplPOVI4SslJyuAcEX+4vewNULpUqdzIggMkTB1oTZlB X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0013.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::12) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DU2PR04MB8709:EE_ X-MS-Office365-Filtering-Correlation-Id: fde0177e-91c5-402e-1b69-08dca24c4ca6 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?4gXy2mNzp7By49dBbuO817dGOl3q3MP?= =?utf-8?q?QS7sFiR6CoAx/ppXf2gRV4yLpkK6IbglOiTgdgYtcyIqqdnMyBqLQ49u+41h95uH0?= =?utf-8?q?NbH4uqkZ6vGxtDeYWGDlpTxmk0LfnnEQJoj5g93dq1qYKOAMIKR+s0eJZikvUQv2y?= =?utf-8?q?kI9UEahl+dE5I4EmKk8yuuIQcgLqeRwwROMac+gE5SbbOqAuxqU3wPo+PGg8dG/IM?= =?utf-8?q?/UjGKa1ABJh1fdMf+15zR66JOEjZVwkklwh6MYlDdwy6SSziaa7nCqHbeDm2anEdI?= =?utf-8?q?IYggMt4OtjU/hm2VLWsuak3iw0GbZMxksKRQYZNn0l6C9HUphGnY4G+t0kb2JcWNO?= =?utf-8?q?61ylQN0hzk0biVaOoY2IM5beycXwAO54Tx/rCiGjNthUJYzXiROIPHt+M6AVK8Vec?= =?utf-8?q?F1KBL+zRlJ89SIuLJ3ROVBs/azpLFugcpPT607mg3CDj0kTVGEK8PnOvPwpOUDVEE?= =?utf-8?q?JQTAPFvr6JMNv9BrNNZQjSFOKV7swF3uHGDl9dsCB3nQiXdEs4UZ6DekZ04DOOV57?= =?utf-8?q?vLNsHIytzXf9p6+iYRKpVkpq0QmHBSI4Te+LXVNH8lX8G8owHo364xL0c6c/dAb4q?= =?utf-8?q?+F0MR9ttyIUtYRr3lJAv+Gu4kc2NoIHilxYtzLqrMITyNKlwdWhhnbeJ8BNZQrv+A?= =?utf-8?q?c735FmncNqK5etc8216Qo4F8+AO55wnIV+WW7shIAhy56uxLM1bvhkh//GYraedm+?= =?utf-8?q?5yaB9kwQ7W9bjpD/7f1d18USrj/dKqB8ZS5V9IPMVWpdc1BcXe0rkgQRp8K6iLMu7?= =?utf-8?q?I/XW8NXDYqwolZDjl6e/M8LNqceqkGi9k1sF2bL2/g1FulEjqA2C5Z5x1fGdDZLZV?= =?utf-8?q?d3iS6s8n9J2/M5Aop/E/Jy/HyoSoBJuspknSJLIxLGkdqmT9rvvykZTxMGo15uorP?= =?utf-8?q?yYmfhifmj8HTiyVv7Z/IeovTnQPyMI6QLt7d8R00BtNgDDrWpBwVw8NZIt6OoIE7V?= =?utf-8?q?uSYKhogXxABsMlffuNSPd7MExUP+jRfUtlkKzAuw0PX3BeEO3JXgPCF5thawIysk/?= =?utf-8?q?HOBro2dF1DyCxTVdBIJzxFAXtX3M6LQMoJi2162oLsgbSVx2HjTAcFcwOgoeQBve0?= =?utf-8?q?YQUHawaTmqpZf4MfldZeiiqzapVLUC6hQDOYr38jMKVuG2gx63BGVifImJ02d8awM?= =?utf-8?q?d8QJilMoz4J/DauMsIJS9KOTGmHVNnTvmzuQnAblsmNz+51rDMJffIreLFq9whGpW?= =?utf-8?q?6Dd5Xdq6MZkEHNcfQ6t0Yr8+IUzYtSbYirKAvPgp6F512IspSW66Ao2wLSkukjPwO?= =?utf-8?q?NJnzl4VOt1aVnCkiJoEZrRc6emLlVNUf/P75WvXRxd1yg5Az6WG1qX7xhNn4/CZtr?= =?utf-8?q?bA6sbHJH7jJFCsw9FWQUc07Pf81nddqmgw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?rvNNQAFh01veOVg/O6akhwVkljr6?= =?utf-8?q?kdqXSQAb8AqscJNds0Lm7AmYoMfAqiyI5R7terMgW94oidVqD1WY1cz93HaBrunL6?= =?utf-8?q?MHb5hA1I0Khbj04/YWsOnO7COoieaTwk5F7rtrbhlF9jf0GDpdO74r9endX9IGM9f?= =?utf-8?q?SR4glqihSj3gCVqA8QteAxUptOokWxurbhKLrl9SGrzuSu7q6Iuoc/9DqtTKToRcQ?= =?utf-8?q?gwqjMwlGMB8YW07iElibJxXsoyUfv9IPMATdj7XaFyJ762t7MJiC2aQoSTGojt+Ja?= =?utf-8?q?EtQ+DxPsa73G5p1mskD53DDOVDrx6ota5ZDkvE6Fcm+iXYPEvCgEyfcticCPat8qr?= =?utf-8?q?8kgQ5n5AaESjABUqCT6RDgen13p9b9fi4+J+GwRQvwNqyRQcCjSgncdo3/eC5Esus?= =?utf-8?q?E5H3PjHyfJDCClhKkrQB8R1iM3lTXUab6Q+Q57e7MQ1vx/j1RJ/8hZNiwEIZ/W1kk?= =?utf-8?q?SChDQGotnblKqWEToH1F28yj5SbHAMrbMpctEceGM983zrxb2vvNakXbq5s/Qxolb?= =?utf-8?q?J84ZqZc+0iM4qO8FH2X3Wv3jAkGV8HULqj4aC8MUkyBgOevRqbjfAzy4z9/epqYfi?= =?utf-8?q?sKkBCkSIv8Y2vbZPZPU7gB7wqpgk4jz0+OAzpDzj5b7ZubuZAvh7gThr/+AaAJ+Ug?= =?utf-8?q?BEaEtnHtBcP+v8s0mYJtzvxBr39NYHC/rbd5pqcWGajhm6/Ka6W2gmNKStWCScCDN?= =?utf-8?q?0oXJ+OzG0yie4fnCkfIO9IoECyCI/z8duuL6AzV2OV2QZKQx8IdAxBMaHlDfCAU4U?= =?utf-8?q?gaVIH3vjAfR6jP1NnK+F0NT+sNgQOUtpeokv+edmOkH21FmqGTiuoQxKTOwG8vZbz?= =?utf-8?q?6betS6QDmxm0CSuMGx+20vtLVBn/LTiZi+jiarqNoIqRuZpDUe5j66sdc+G3NWNBJ?= =?utf-8?q?1d6rRPFfcfGVK9+0erxK5hWQ+27thq6IGfe0VywWgDUsZNDYXg63GraRaGFdmGYSK?= =?utf-8?q?jmI3I+T90u7LPvGzetwcBPLwI8YEnjVfajuxEPMh7l5VSSBxSmlsEsJNf5mZ8I8+q?= =?utf-8?q?BNT3HzZmd3pOqK6ITA0hUUZhWlusuPzAX4QRzfwuA00i6dxGLV8QI9EGXffbdpTil?= =?utf-8?q?30FGL3axlGFJYfyBLK9yAEa8myDDNy4bhT36vS5zbtAC5Nu+b3/7Yft/bn7xqO//i?= =?utf-8?q?gw13q8i40kXXN5Q1u4eRCKkPZbeD6CGmL4xvHvbhplPRSoPySpfDQX9xhkAEwCz2C?= =?utf-8?q?EDF2wCBI7ALdbsrP5IBvBWdmaIWoAIB1NYEySdLDkkRT1rv57Pc/VknMzp6jGVNlw?= =?utf-8?q?a+koVRHDKB6+JZgh9HJpi5FBNLbcs4M+TzebFb7PSjMce0YoOsYYRkDDC5ShK7PMU?= =?utf-8?q?pIVSLLkcgq5zzTR+dsRvfT2Jwsak5dFNpTeVIE9dr+i73y3RvicrtasZby/IMf59l?= =?utf-8?q?xLQZ4Mttkb9QDd4rPvDH+v2mCwTx4z8Q7oxgmYIm8R+gPcWIe29VLfsbijAUHwJPQ?= =?utf-8?q?6MreAN7uAg1IMmHvjIgR8efouj+vOAAIwwyy7a+qbIwcbUfvxNwooEmoX/xM4crhl?= =?utf-8?q?YJ/n0G5jLZ8u?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fde0177e-91c5-402e-1b69-08dca24c4ca6 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 08:26:16.7902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +goJhrMDSxft3VAHBJGMTkBbfNyxyzlhhmyXgZhSb1XpTrGdbGbAtZU8F8pYOoxnO7OEumL8+V8XooBFNsr6Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8709 From: Peng Fan Current tx_block is set to true, but there is case that no need to wait response. Linux just needs to send data to remote processor, so let's allow tx_block could be set to false. Reviewed-by: Jacky Bai Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 552fccebf7e2..01cf1dfb2e87 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -90,7 +90,7 @@ struct imx_rproc_mem { #define ATT_CORE_MASK 0xffff #define ATT_CORE(I) BIT((I)) -static int imx_rproc_xtr_mbox_init(struct rproc *rproc); +static int imx_rproc_xtr_mbox_init(struct rproc *rproc, bool tx_block); static void imx_rproc_free_mbox(struct rproc *rproc); struct imx_rproc { @@ -369,7 +369,7 @@ static int imx_rproc_start(struct rproc *rproc) struct arm_smccc_res res; int ret; - ret = imx_rproc_xtr_mbox_init(rproc); + ret = imx_rproc_xtr_mbox_init(rproc, true); if (ret) return ret; @@ -629,7 +629,7 @@ static void imx_rproc_kick(struct rproc *rproc, int vqid) static int imx_rproc_attach(struct rproc *rproc) { - return imx_rproc_xtr_mbox_init(rproc); + return imx_rproc_xtr_mbox_init(rproc, true); } static int imx_rproc_detach(struct rproc *rproc) @@ -794,7 +794,7 @@ static void imx_rproc_rx_callback(struct mbox_client *cl, void *msg) queue_work(priv->workqueue, &priv->rproc_work); } -static int imx_rproc_xtr_mbox_init(struct rproc *rproc) +static int imx_rproc_xtr_mbox_init(struct rproc *rproc, bool tx_block) { struct imx_rproc *priv = rproc->priv; struct device *dev = priv->dev; @@ -817,7 +817,7 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc) cl = &priv->cl; cl->dev = dev; - cl->tx_block = true; + cl->tx_block = tx_block; cl->tx_tout = 100; cl->knows_txdone = false; cl->rx_callback = imx_rproc_rx_callback; @@ -1083,7 +1083,7 @@ static int imx_rproc_probe(struct platform_device *pdev) INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); - ret = imx_rproc_xtr_mbox_init(rproc); + ret = imx_rproc_xtr_mbox_init(rproc, true); if (ret) goto err_put_wkq;