From patchwork Fri Jul 19 08:36:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13737001 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013019.outbound.protection.outlook.com [52.101.67.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A665081726; Fri, 19 Jul 2024 08:27:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721377655; cv=fail; b=p8cZMABy3pvSB1Qo6trOKWBsbPRFHyYCHTT3aFejKLw9PQFB7UKjQ8Vts3gcB0MdK7RX0/RbeU9A51FOr96uIMCYyciNbHNbGip/uJPRemSHNoNFpjs3wMWd4sq3c17YXLiBHkkWwEbs8O4H9KNr1LmCiW42m6hJSX128XZHDIQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721377655; c=relaxed/simple; bh=q0Gek6k+OjnV6338kq2OtybrLk8NEEN+c3BxvHLABcA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UcXWk3PX95+KaYKl93t2NLPURtkZv+spIimBQJa+EVgk1EuvizuLM13rSn5ypW/5ex0p9RWtTftIgB5L/zt36wBjevMGwM0/bm52Ab5YzoBNh45l4/RqndKFKCiaBXdVWHnOT+61aT89U2eA7T++CPm87ks2mxanUOzXmXVuj3A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=N1VvrUJZ; arc=fail smtp.client-ip=52.101.67.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="N1VvrUJZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pc3zMcISoH3TIUhUel4tLaLAEB618jGt9Qd0TmcJXt1xS/J0r9UJpmJ8Pp8nF1EHtc0yMxA+0aq3ni4h+KCwhXmlG97WOJ7QchfzqJiLtesvo76kBV896rq5Y8EWDzfJypYm90rp6v/qgGfn+r/hNiXJ87ZTVzvxk3KDgKWe/JRuBut77gtWC9QeNHc+DIvqzVYNSX/kkZFyUjxZAd2jFahhhNt5bSIdh6xG+4rn8qbwOQLStHmUFHwxnVtJ5/avGLM1DOg1kN6SNexDQikK13W/pEL4remcQ5AxUjZCRpi8v5+X88q2gAo8+f077rcJSn4kQOgf/26WKpSFY7ZstQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CueRkbqhz48rnYutf4T4ktNQ8uvs51G3cYlzWCavKy4=; b=wLi+Agj+AEWGKd15hmc6iBnurFINAQWVsqG6lMocOzvFY5yn4RZIUwsfAwnAyJk4OpBn6XI6cV5oyCyiIIkLO+A4sg5KzkaCB94tddJroUC63YExS7JEP+b8tSTMtfiahQf/lhEynu7gMcUpIP1/g/lZHb+eA0D93xHPZGC7wfm3zFZ8HICu5+748teTluzo5M0xAvDZtMEplALuv6lA4ElbUja+xo9jDDpX3dBTUJc7+Pq5S/HZb51487GtqjPwHS+jL21pHepBsVnwxCUd2/eKsFi1EGV4AEDmSLNcZa+F95AoVfyGTYxqp2C146DbxdVVW8QhYvEw/nx1cKmmHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CueRkbqhz48rnYutf4T4ktNQ8uvs51G3cYlzWCavKy4=; b=N1VvrUJZsbz2mcITqawEOU9ssbMJ4k59Kr06m6bguZNk23weMTVXXXd4vVuMFqWZhjs4QHQO/OQctjuwCRpPoVWp/iw0Jv4iEIAJMXASJ3Ce1mj2CTAnwRCdDbXZjTnRiFyK+2OZHExzX+STHst7SiKbshob4kj7YMKtXhqaYW8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7904.eurprd04.prod.outlook.com (2603:10a6:102:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Fri, 19 Jul 2024 08:27:30 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.7762.020; Fri, 19 Jul 2024 08:27:30 +0000 From: "Peng Fan (OSS)" Date: Fri, 19 Jul 2024 16:36:13 +0800 Subject: [PATCH v2 3/4] remoteproc: imx_rproc: initialize workqueue earlier Message-Id: <20240719-imx_rproc-v2-3-10d0268c7eb1@nxp.com> References: <20240719-imx_rproc-v2-0-10d0268c7eb1@nxp.com> In-Reply-To: <20240719-imx_rproc-v2-0-10d0268c7eb1@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Daniel Baluta , Iuliana Prodan , Marek Vasut Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1721378185; l=1109; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ZF4X2mUEk5W+41kIPzV6kV8qVtCKJb1wG6vsUcranFg=; b=4oAil4sBNmb1moRx98l0b6xH8MYeYSCp2w2N22BuGbvTcWaP6DA6eQJsaGXvefgknaX80A4wx E+HOMRnkxpMDvMGLqPB8ILsZgbvwkY7EK3S2Jkrb36waN4fcAfa/0uH X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0232.apcprd06.prod.outlook.com (2603:1096:4:ac::16) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7904:EE_ X-MS-Office365-Filtering-Correlation-Id: 2080e538-6677-4de1-c57d-08dca7cca16b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?h+ss++5WJIRDv+reK96jOMuuWslCcuj?= =?utf-8?q?u4ZQa0mexHL8+xnosxfR6Upa8AOL7l10fd1j8r7VOudBlNObOhDogqywPEt+npRH5?= =?utf-8?q?Fm5s4igC/lIVvrxT8PGr4eOvao/CXvEFeANvkitbndeqTmQtMEEnmcCXZGeH61/2z?= =?utf-8?q?E8cZBtHlicFasryB+45gYWse6bPiD9emlyD8lkmfY1ELEddMkAaU8dmzQx6C84ypz?= =?utf-8?q?xnh8UktjMZGuvXltoKbx8/ruTNxmu5iZxDnqdkD4+ixrKrVqv4do9I48+p/kT0+mT?= =?utf-8?q?eLGImw5Se4STYap3xlFrGSDpHWM9J+bZ9+PIK7UOa5v4e34mwZUvJxHNpAwXaNz6F?= =?utf-8?q?zfv3/xMvuZqxg43g/gH241jfnZ63xm1uJDW4qxJWhF3HwOYmVgUGJMkyNrXVAnxHp?= =?utf-8?q?M91zN/X1XxWKIdvRwlCDzuaQp1RwF+yfEGpiYilcr4gZ+9qHH5yofJ144WbYBXVLl?= =?utf-8?q?8hG6pH5aDlf5wuNt48kBSKcG87R4V6Dt3S/09Eg1nYd1++WOYQzSsxW/6PAA8wgvg?= =?utf-8?q?YQIX04GWpCK0I6JFsfKzYsCR1WGiQXunke8Hgka9QnrLFbiXHfOaWFLbtxrqAEL1e?= =?utf-8?q?ENlMxIK0QIXRLx0ISkfp0Rh8jCCk/2f0rD2aEGEtyoS8cdGG/exIR1D7yrhvR4+Ba?= =?utf-8?q?E2Ry3LXUgXlt89SsoxqBwmMHpBXDpiv2t29fslIAinDevdj1Kc0jCJm5BWMGosD57?= =?utf-8?q?Xbt64j2sH/POT7iPKZztHCsdi60YjK5dLojbEUrEarzYJgZ14+cyn/FijU/GwKOxB?= =?utf-8?q?E9+TuNDAn+TuFv/rjdxlKAwwXYnJnkDv9wi2Lsh5gtKt1Ki8DR7Cr+3yUvCjTaGoi?= =?utf-8?q?AwQwkV5lZJ9hbh58cv/M85IU+xWroYsKdD5RqmEZrpMz2UwjU+8aIPAuOgL3gJo9S?= =?utf-8?q?/+yGnSBKHRR+HbRGF+SkL6JmiLsLD8h+rIWN3uvNXEaALHWTGAUI6YY7s1UdrDeLf?= =?utf-8?q?xjBF15CY3PJcLj2oWFuUTcWGQd3DnnhjloFd74u1HY4JAgpdRt2uPiJqvlHjSNheI?= =?utf-8?q?sLNM/dAgnDlhXE9dMrzFHmyIVj/NuwMNK9cyEhFBjx2gHOa+o/XQz5dL/APpfQBRY?= =?utf-8?q?k9DFiVBgwNt0Ww7J0bqG5bvzYsWKDQrIvYJt5cqOi5DdVRCwIF7zbBwNViqX95kv2?= =?utf-8?q?u/P468IZ93V7feZ/XBnFwZL5fnk1k5edLoWXodmfWM5wphErn2MEvu/qlEfTArhm/?= =?utf-8?q?JaG8+CLzGVXWKszubwvoTRJLcXTbmgD9z0d0Kiovcz8cjOBxBfV1MhqPW6o/bLlwg?= =?utf-8?q?jbF0B0/guYrIpXqlAQKmQ+nj5RCveSJQu/SnZlj4PiFQnagFFCGgQyNuU08PeuIcv?= =?utf-8?q?dGuFyuFayuptCgExZ55RcdhBHLkXvif5hQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?EYP4VlPVfzw/wm4gUhx0x9J/2jMD?= =?utf-8?q?RljWqcMNcY7G8RBheGbC4JDq7Symy702g1ol4hT9Gz+0a4s/85R1Cki1ACGCclSMJ?= =?utf-8?q?UilfRJ5TrjrcVCL7FOitkWsZ0QhntU79YlA0uLH2YENiavEMYavyhhIY0B9zT2Flk?= =?utf-8?q?zm8DssfYbvChY0l2hqyx2iK1Il1Rwq+kNfPKM0i2rLNVB+4lUMXGiv3+XtEliYj0N?= =?utf-8?q?f/FTANAzIvrSDg+p+2ULISxyBEsQ3uGGrAhBfBW1Cap18EwOfud3EZ2hsbmkuHXIW?= =?utf-8?q?AMCSt7Vuv50WMrI5UpEy/+jbMIJ+yi3Imi5LQZmAxE5mruhtb6MplIt+DnO2C91FY?= =?utf-8?q?w5b5fWFAsYy5+07kKwWgyL4jYu5/v69vsM2mTbn0Y61i0e9o3pS54IHg1IqAgUnCA?= =?utf-8?q?pn2JPhU2AjUkIN/DHKk7zjojeRXFpvNxUh+IMLXyYI7Y8KIpbbvNEgOR5GE+udCQt?= =?utf-8?q?RsuQXkfXWHyPQZ5RcV2CSJiiPllTU4C22W1kzVQd+Qn63PEN9h0VOa+7Wb259hA4g?= =?utf-8?q?8AqtjmdynV8GgPfGygz3K+3qguu+R2+Ioo/V6nrDkvds3nn/2mbk4f5G9J3LBN5X1?= =?utf-8?q?Ee0/Ck4c3w0tQl7ihyI+0w3b4m/AHjHfkACUYjJzPsRBhdfBPUOvoJU5990lOLA5a?= =?utf-8?q?MkHayCouylaWF4j2FFDSVp4kqcvswzy51wCWVWQUprBKm00PyoEn8enS49dtlL5dZ?= =?utf-8?q?EVQJX56k1RPF4GtmhIkVqQqVTQi+i7TNrgSVEmmC8O4vcdxBovO8B2zJNrPaaHr5/?= =?utf-8?q?cL4ED04PpaI7BIfe6yo7OVlT/bEIIUZkMEpeyuB/BkPOeLVR/nN3DGSTNrlfXXaal?= =?utf-8?q?gfAB/998EADzb3qTp9ppKrqUjHw0ObyCxusgVLzYHZ7TVhlxmc+H0jD/jaDUhu06a?= =?utf-8?q?qSiyBa572LXXcMqgLrUecGOCea5JUJ5ud7Sfzk3woXP1j2OKVtPhB1WeME6mBg709?= =?utf-8?q?rbY9BLydS3MzpOn1+SdT7KPGJpVqXh12IzhvfSYFNurgC5b823IXBxAtSPfOCGmZN?= =?utf-8?q?NeANri3XQ3AAT1FmJ2Fgk4YHUmmzOCiUeSDmviS73V+P4tXpYsfA26CVi1G6OBOPK?= =?utf-8?q?j96jIEh1UpoDbYPwEFxT+GTABr5jbPZuzoZJd9jwxbXAnrjMoqgpKqbU7vJyLjbWu?= =?utf-8?q?IFaR/n9jvCu/vby1aQCbqJ5vdmepqk8OZGW08BspVRteGcGJrJ+7mDnU/ImNJKsY5?= =?utf-8?q?kfZYwRZc1p8EKMgpBHfotWRNPptNB0nRZl/ykZvn8q19a0RyJp5Re86F2Ge5Nc/0c?= =?utf-8?q?kBNoCWD1LjP9BnyAUPUB0R2FnVOZMYIFCBJI+5K9RO+pT81573phwklwUjFErSwvP?= =?utf-8?q?qa3ULOLK8rbKzC8NFP4yHzUqg5nXj82FI2elzHx+hZXh6cJUA2tzZHySqJiuyYR7Z?= =?utf-8?q?X+wuRU5HhPEG/amWnQmWbJDkbMGZPoxaSu5AP+lMfuEK//p0v0DPSEyTltCs5uFhi?= =?utf-8?q?cyT9i660/XlxqgAE/NJt4vl8+D1aYyVKzs79Z/563qsTGaIV0+pZL9lTswXT0+0jw?= =?utf-8?q?SnqIWiDmkXO4?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2080e538-6677-4de1-c57d-08dca7cca16b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2024 08:27:30.3996 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BBEz7bNy8sbKL2aBbiklVt5FJ2/N7qelYU+CESif0gEcHZfM0vsD+KO+7pH3rVasYj0Jj4hsatzWScI6fLBzxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7904 From: Peng Fan Initialize workqueue before requesting mailbox channel, otherwise if mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback will trigger issue. Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox") Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 48c48b53a3aa..9e99bb27c033 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -1087,6 +1087,8 @@ static int imx_rproc_probe(struct platform_device *pdev) return -ENOMEM; } + INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); + ret = imx_rproc_xtr_mbox_init(rproc); if (ret) goto err_put_wkq; @@ -1105,8 +1107,6 @@ static int imx_rproc_probe(struct platform_device *pdev) if (ret) goto err_put_scu; - INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); - if (rproc->state != RPROC_DETACHED) rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot");