diff mbox series

[2/3] rpmsg: glink: Pass channel to qcom_glink_send_close_ack()

Message ID 20240805-glink-tracepoints-v1-2-a5f3293fb09e@quicinc.com (mailing list archive)
State Accepted
Headers show
Series rpmsg: glink: Introduce tracepoints | expand

Commit Message

Bjorn Andersson Aug. 6, 2024, 3:56 a.m. UTC
Align the qcom_glink_send_close_ack() arguments with other functions to
take the struct glink_channel, so that the upcoming tracepoint patch can
access the channel attributes.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 drivers/rpmsg/qcom_glink_native.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Chris Lew Aug. 7, 2024, 11:42 p.m. UTC | #1
On 8/5/2024 8:56 PM, Bjorn Andersson wrote:
> Align the qcom_glink_send_close_ack() arguments with other functions to
> take the struct glink_channel, so that the upcoming tracepoint patch can
> access the channel attributes.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>   drivers/rpmsg/qcom_glink_native.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: Chris Lew <quic_clew@quicinc.com>
diff mbox series

Patch

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index e764ea8a290c..ba0ea28df821 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -511,12 +511,12 @@  static void qcom_glink_send_close_req(struct qcom_glink *glink,
 }
 
 static void qcom_glink_send_close_ack(struct qcom_glink *glink,
-				      unsigned int rcid)
+				      struct glink_channel *channel)
 {
 	struct glink_msg req;
 
 	req.cmd = cpu_to_le16(GLINK_CMD_CLOSE_ACK);
-	req.param1 = cpu_to_le16(rcid);
+	req.param1 = cpu_to_le16(channel->rcid);
 	req.param2 = 0;
 
 	qcom_glink_tx(glink, &req, sizeof(req), NULL, 0, true);
@@ -1628,7 +1628,7 @@  static void qcom_glink_rx_close(struct qcom_glink *glink, unsigned int rcid)
 	}
 	channel->rpdev = NULL;
 
-	qcom_glink_send_close_ack(glink, channel->rcid);
+	qcom_glink_send_close_ack(glink, channel);
 
 	spin_lock_irqsave(&glink->idr_lock, flags);
 	idr_remove(&glink->rcids, channel->rcid);