| Message ID | 20241022-rproc-friendly-name-v1-1-350c82b075cb@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | remoteproc: qcom: pas: Make remoteproc name human friendly | expand |
On Tue, Oct 22, 2024 at 04:21:03AM +0000, Bjorn Andersson wrote: > The remoteproc "name" property is supposed to present the "human > readable" name of the remoteproc, while using the device name is > readable, it's not "friendly". > > Instead, use the "sysmon_name" as the identifier for the remoteproc > instance. It matches the typical names used when we speak about each > instance, while still being unique. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com> > --- > drivers/remoteproc/qcom_q6v5_pas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 10/21/2024 9:21 PM, Bjorn Andersson wrote: > The remoteproc "name" property is supposed to present the "human > readable" name of the remoteproc, while using the device name is > readable, it's not "friendly". > > Instead, use the "sysmon_name" as the identifier for the remoteproc > instance. It matches the typical names used when we speak about each > instance, while still being unique. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com> > --- > drivers/remoteproc/qcom_q6v5_pas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Chris Lew <quic_clew@quicinc.com>
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index ef82835e98a4efd4bc603cff604d531a51fe9f9c..b2108c3036a33f7e9a63380be3a6e319e76503cc 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -716,7 +716,7 @@ static int adsp_probe(struct platform_device *pdev) if (desc->minidump_id) ops = &adsp_minidump_ops; - rproc = devm_rproc_alloc(&pdev->dev, pdev->name, ops, fw_name, sizeof(*adsp)); + rproc = devm_rproc_alloc(&pdev->dev, desc->sysmon_name, ops, fw_name, sizeof(*adsp)); if (!rproc) { dev_err(&pdev->dev, "unable to allocate remoteproc\n");
The remoteproc "name" property is supposed to present the "human readable" name of the remoteproc, while using the device name is readable, it's not "friendly". Instead, use the "sysmon_name" as the identifier for the remoteproc instance. It matches the typical names used when we speak about each instance, while still being unique. Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com> --- drivers/remoteproc/qcom_q6v5_pas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 42f7652d3eb527d03665b09edac47f85fb600924 change-id: 20241022-rproc-friendly-name-410ca7185ce1 Best regards,