| Message ID | 20250128-pas-singlepd-v1-1-85d9ae4b0093@lucaweiss.eu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | qcom_q6v5_pas fixes for msm8226 | expand |
On Tue, Jan 28, 2025 at 10:53:59PM +0100, Luca Weiss wrote: > MSM8226 requires the CX power domain, so use the msm8996_adsp_resource > which has cx under proxy_pd_names and is otherwise equivalent. > > Suggested-by: Stephan Gerhold <stephan.gerhold@linaro.org> > Fixes: fb4f07cc9399 ("remoteproc: qcom: pas: Add MSM8226 ADSP support") > Signed-off-by: Luca Weiss <luca@lucaweiss.eu> Not sure if Reviewed-by makes sense if I already did Suggested-by, but anyway: Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org> > --- > drivers/remoteproc/qcom_q6v5_pas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index 88e7b84f223c0222a01e2a246a848f2889ac00b3..aca44bb6522f00cb525c4b816040445287444434 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -1319,7 +1319,7 @@ static const struct adsp_data sm8650_mpss_resource = { > }; > > static const struct of_device_id adsp_of_match[] = { > - { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init}, > + { .compatible = "qcom,msm8226-adsp-pil", .data = &msm8996_adsp_resource}, > { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource}, > { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, > { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, > > -- > 2.48.1 >
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index 88e7b84f223c0222a01e2a246a848f2889ac00b3..aca44bb6522f00cb525c4b816040445287444434 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -1319,7 +1319,7 @@ static const struct adsp_data sm8650_mpss_resource = { }; static const struct of_device_id adsp_of_match[] = { - { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init}, + { .compatible = "qcom,msm8226-adsp-pil", .data = &msm8996_adsp_resource}, { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource}, { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
MSM8226 requires the CX power domain, so use the msm8996_adsp_resource which has cx under proxy_pd_names and is otherwise equivalent. Suggested-by: Stephan Gerhold <stephan.gerhold@linaro.org> Fixes: fb4f07cc9399 ("remoteproc: qcom: pas: Add MSM8226 ADSP support") Signed-off-by: Luca Weiss <luca@lucaweiss.eu> --- drivers/remoteproc/qcom_q6v5_pas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)