| Message ID | 20250129-wcnss-singlepd-v1-1-b01a6ba0b1bd@lucaweiss.eu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Support single-PD in wcnss driver | expand |
On 29/01/2025 18:51, Luca Weiss wrote: > From: Matti Lehtimäki <matti.lehtimaki@gmail.com> > > Support platforms such as MSM8226 and MSM8974 with only one power rail > (CX) modelled as power domain while MX and PX are regulators. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > [luca: reword commit message] > Signed-off-by: Luca Weiss <luca@lucaweiss.eu> > --- > Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > index 8e033b22d28cfa8203234f744b3b408e976e20c3..d3c71bcf0f02122eb0dae214f135d8d7f71a9600 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > @@ -69,9 +69,11 @@ properties: > CX regulator to be held on behalf of the booting of the WCNSS core. > > power-domains: > + minItems: 1 > maxItems: 2 > > power-domain-names: > + minItems: 1 This should be further narrowed in allOf:if:then per each variant, because now you say that all devices here can have only one power domain... unless the compatibles do not allow that, but then explain in commit msg. Best regards, Krzysztof
On woensdag 29 januari 2025 19:44:54 Midden-Europese standaardtijd Krzysztof Kozlowski wrote: > On 29/01/2025 18:51, Luca Weiss wrote: > > From: Matti Lehtimäki <matti.lehtimaki@gmail.com> > > > > Support platforms such as MSM8226 and MSM8974 with only one power rail > > (CX) modelled as power domain while MX and PX are regulators. > > > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > > [luca: reword commit message] > > Signed-off-by: Luca Weiss <luca@lucaweiss.eu> > > --- > > Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss- pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > index 8e033b22d28cfa8203234f744b3b408e976e20c3..d3c71bcf0f02122eb0dae214f135d8d7f71a9600 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > @@ -69,9 +69,11 @@ properties: > > CX regulator to be held on behalf of the booting of the WCNSS core. > > > > power-domains: > > + minItems: 1 > > maxItems: 2 > > > > power-domain-names: > > + minItems: 1 > > > This should be further narrowed in allOf:if:then per each variant, > because now you say that all devices here can have only one power > domain... unless the compatibles do not allow that, but then explain in > commit msg. Yes, the compatibles are so broad that they cannot be used to narrow this down. I can add this information in v2. I'd add something like the following. Let me know if that isn't clear enough. "Due to the compatibles qcom,pronto-vN-pil being so broad we cannot narrow this down by SoC without introducing new compatibles." Regards Luca > > Best regards, > Krzysztof >
On Wed, Jan 29, 2025 at 10:42:22PM +0100, Luca Weiss wrote: > On woensdag 29 januari 2025 19:44:54 Midden-Europese standaardtijd Krzysztof > Kozlowski wrote: > > On 29/01/2025 18:51, Luca Weiss wrote: > > > From: Matti Lehtimäki <matti.lehtimaki@gmail.com> > > > > > > Support platforms such as MSM8226 and MSM8974 with only one power rail > > > (CX) modelled as power domain while MX and PX are regulators. > > > > > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > > > [luca: reword commit message] > > > Signed-off-by: Luca Weiss <luca@lucaweiss.eu> > > > --- > > > Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss- > pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > > index > 8e033b22d28cfa8203234f744b3b408e976e20c3..d3c71bcf0f02122eb0dae214f135d8d7f71a9600 > 100644 > > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > > @@ -69,9 +69,11 @@ properties: > > > CX regulator to be held on behalf of the booting of the WCNSS core. > > > > > > power-domains: > > > + minItems: 1 > > > maxItems: 2 > > > > > > power-domain-names: > > > + minItems: 1 > > > > > > This should be further narrowed in allOf:if:then per each variant, > > because now you say that all devices here can have only one power > > domain... unless the compatibles do not allow that, but then explain in > > commit msg. > > Yes, the compatibles are so broad that they cannot be used to narrow this > down. I can add this information in v2. > > I'd add something like the following. Let me know if that isn't clear enough. > > "Due to the compatibles qcom,pronto-vN-pil being so broad we cannot narrow > this down by SoC without introducing new compatibles." > The qcom,pronto-v2-pil compatible isn't too broad here IMO. It describes a specific hardware block that needs the CX and MX power domains to operate. The hardware block doesn't care if the power rail is being turned on via a regulator or power domain. At the end, this is a firmware difference "leaking" into the hardware description of the DT. We can describe this in the bindings. Both CX and MX must be present, either as actual power domains or regulators. For the old setup (= either PDs OR regulators, but not mixed) it's already there further below. You need to adjust the part where vddmx-supply is marked as deprecated, undeprecate it, and then try something like the following (untested): - if: properties: compatible: contains: enum: - qcom,pronto-v1-pil - qcom,pronto-v2-pil # ... drop deprecations ... # CX and MX must be present either as power domains or regulators oneOf: # Both CX and MX represented as power domains - required: - power-domains - power-domain-names properties: vddmx-supply: false vddcx-supply: false # CX represented as power domain, MX as regulator - required: - power-domains - power-domain-names - vddmx-supply properties: # Not sure if this works here, might need to put minItems: 1 # into top-level and restrict entry above to minItems: 2 power-domains: minItems: 1 maxItems: 1 power-domain-names: minItems: 1 maxItems: 1 vddcx-supply: false # Both CX and MX represented as regulators - required: - vddmx-supply - vddcx-supply properties: power-domains: false power-domain-names: false Thanks, Stephan
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index 8e033b22d28cfa8203234f744b3b408e976e20c3..d3c71bcf0f02122eb0dae214f135d8d7f71a9600 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -69,9 +69,11 @@ properties: CX regulator to be held on behalf of the booting of the WCNSS core. power-domains: + minItems: 1 maxItems: 2 power-domain-names: + minItems: 1 items: - const: cx - const: mx