From patchwork Wed Sep 19 15:56:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10606049 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5A7D8112B for ; Wed, 19 Sep 2018 15:57:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 443252B065 for ; Wed, 19 Sep 2018 15:57:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 38B612B289; Wed, 19 Sep 2018 15:57:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A62F22B065 for ; Wed, 19 Sep 2018 15:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732556AbeISVfh (ORCPT ); Wed, 19 Sep 2018 17:35:37 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:37216 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732545AbeISVfh (ORCPT ); Wed, 19 Sep 2018 17:35:37 -0400 Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 61E2C1C0C; Wed, 19 Sep 2018 17:57:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1537372623; bh=LjFSTqOhJLT4oCZ6+RkGtfMyckhUD5vkrbeiVvcJHbk=; h=From:To:Cc:Subject:Date:From; b=B1f/MxHU4eCwoJZJUKx5QjpcDg5Avv1wF3aCGsZeqXSJYNZHkOhM70+T+llETDgCZ EG42WxkAuvjRK+mIEtXkRh/nsBAoGH6noo8CSDvZw1h2X9rYXCoZDkqAHTjnFbMRfM sOJdkprSDvkabX1SluN1otWVMZ1IbYe8ILQfiNLQ= From: Kieran Bingham To: Laurent Pinchart , linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Alexandru-Cosmin Gheorghe , Kieran Bingham Subject: [PATCH 0/2] drm: Alpha blending issue Date: Wed, 19 Sep 2018 16:56:57 +0100 Message-Id: <20180919155700.10342-1-kieran.bingham+renesas@ideasonboard.com> X-Mailer: git-send-email 2.17.1 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Testing on the RCar Salvaltor-XS using the rcar-du has identified that commit 161ad653d6c9 ("drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying the logic") caused a regression in display output on the primary planes. The effect was that primary plane was 'invisible' though secondary planes were displayed correctly. This issue turned out to be a change in the initialisation of the default alpha property value in the state object. A plane without an alpha property would leave the alpha property unset (and thus at zero, or 'transparent'). Two patches are thus presented, which both individually can fix this regression - but both are suitable for integration. The RCar-DU driver is updated to provide an alpha property on primary planes, as it isn't unreasonable to be able to set the property there. This alone would have the effect of ensuring that the default value was set to the full opaque setting, and repair the regression. As a separate patch, we also update __drm_atomic_helper_plane_reset() call such that the alpha values are always initialised to a more practical default value of DRM_BLEND_ALPHA_OPAQUE for all planes. Kieran Bingham (2): drm/atomic: Initialise planes with opaque alpha values drm: rcar-du: Enable alpha property on primary planes drivers/gpu/drm/drm_atomic_helper.c | 4 +--- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 7 ++++++- 2 files changed, 7 insertions(+), 4 deletions(-)