Message ID | 20191017122640.22976-1-yuehaibing@huawei.com (mailing list archive) |
---|---|
Headers | show
Return-Path: <SRS0=mucG=YK=vger.kernel.org=linux-renesas-soc-owner@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3281614DB for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Thu, 17 Oct 2019 12:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ABA620854 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Thu, 17 Oct 2019 12:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502603AbfJQMs2 (ORCPT <rfc822;patchwork-linux-renesas-soc@patchwork.kernel.org>); Thu, 17 Oct 2019 08:48:28 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:59328 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729344AbfJQMs1 (ORCPT <rfc822;linux-renesas-soc@vger.kernel.org>); Thu, 17 Oct 2019 08:48:27 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 47C9634C1F89D02A68CC; Thu, 17 Oct 2019 20:48:11 +0800 (CST) Received: from localhost (10.133.213.239) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Thu, 17 Oct 2019 20:48:01 +0800 From: YueHaibing <yuehaibing@huawei.com> To: <linus.walleij@linaro.org>, <manivannan.sadhasivam@linaro.org>, <afaerber@suse.de>, <f.fainelli@gmail.com>, <rjui@broadcom.com>, <sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>, <jesper.nilsson@axis.com>, <lars.persson@axis.com>, <ludovic.desroches@microchip.com>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <baruch@tkos.co.il> CC: <linux-arm-kernel@lists.infradead.org>, <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@axis.com>, <linux-oxnas@groups.io>, <linux-renesas-soc@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <vz@mleia.com>, <narmstrong@baylibre.com>, <geert+renesas@glider.be>, <daniel@zonque.org>, <haojian.zhuang@gmail.com>, <wens@csie.org>, <thierry.reding@gmail.com>, <jonathanh@nvidia.com>, <agross@kernel.org>, YueHaibing <yuehaibing@huawei.com> Subject: [PATCH -next 00/30] pinctrl: use devm_platform_ioremap_resource() to simplify code Date: Thu, 17 Oct 2019 20:26:10 +0800 Message-ID: <20191017122640.22976-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: <linux-renesas-soc.vger.kernel.org> X-Mailing-List: linux-renesas-soc@vger.kernel.org |
Series |
pinctrl: use devm_platform_ioremap_resource() to simplify code
|
expand
|
Hi, On 17/10/2019 20:26:10+0800, YueHaibing wrote: > devm_platform_ioremap_resource() internally have platform_get_resource() > and devm_ioremap_resource() in it. So instead of calling them separately > use devm_platform_ioremap_resource() directly. > Shouldn't we stop with this insanity? The net gain is exactly 2 lines per driver and this puts the full review load on the maintainers. We end up with crap like: https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/ What is the end goal here ? platform_get_resource and devm_ioremap_resource will have to stay even after you have done the conversion.