From patchwork Sun Aug 2 11:06:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11696309 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 497EA14B7 for ; Sun, 2 Aug 2020 11:07:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20245207DF for ; Sun, 2 Aug 2020 11:07:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mdD4mNlz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726578AbgHBLHH (ORCPT ); Sun, 2 Aug 2020 07:07:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726416AbgHBLHH (ORCPT ); Sun, 2 Aug 2020 07:07:07 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED7C4C06174A for ; Sun, 2 Aug 2020 04:07:06 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id i10so1977579ljn.2 for ; Sun, 02 Aug 2020 04:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8iSb9SsfXotMXXf+wPkRF8OEMPr6gknDwlVziw1gsts=; b=mdD4mNlzh8/hcAcLfaA1qsXzZ8oea1pei/QT2fMuDKKGOBfhyTqk8jTw7vHHSkwv2E S+I7r0MKH5o8QMUps16qVHbHdLp9j6UUZvTNeHd7Zx9/ABhG1mxz241UKo+dVLKg6EIC NGTVvTqF6BPBHHVyim+OREuU+5VciwSejdZ+F4g2wPwnPpxugA61K8X/dKzZaFf/+yOi 6XaPsZePQEFtyUMX7UtdUUW+pDQdy6yWfdxwvTPpEzGtm08lN5ho0vpmjf/YcB71u/wO iQkPsz2BzIfEc0tWeOK7Hjx/NgCAwO5J/2QgNCBPElgyqnOVXdEVA7nPdEjqn8BgO7mr q9pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=8iSb9SsfXotMXXf+wPkRF8OEMPr6gknDwlVziw1gsts=; b=mJC2U2q5t1C6vL2xBvMkJGrTRfKJSBSjKAsICYx41PL//IpOYbrMP6sjSw1SA8kjiz N69bgIAstqb0NHXu32TDiCeiFrXecJGXNEVDcj5zn9yF4qy/NsfQ8ctcbxZt7robENY+ 7PoYpntaZNuRS/wioj6x97jiGhYGVimfm1ZLQDKrqQsZJXgdv3zpiuDrgXvcufZMytaT Cp9AITAXpsPGGcdyHQ1oDz8wV7qD/nExOffoyyahdB/iYNIhLW96AZMkWoBk1yjdqQ6G leZZLMXF72Uc+90OPxV7wc6NiDdYpIb4IyRJR3nGXlt8HpCfKGcKHo5mdVf9V6f/EV7O EphA== X-Gm-Message-State: AOAM530nnrldu54smOt5RTgPqH6wMRi2ucJLcXjXjWzzuJKTEPSTEL1a 0aWqIrqqGGQzImJxunngT7U= X-Google-Smtp-Source: ABdhPJzvy7FbOOwSjtrC7E60UDgnf+0RtBTJE2HqwFr0DdocntTu8GNpJxpAGgNCm/WLPHsWdBn7Sw== X-Received: by 2002:a05:651c:1350:: with SMTP id j16mr5241580ljb.227.1596366424119; Sun, 02 Aug 2020 04:07:04 -0700 (PDT) Received: from saturn.lan ([2a00:fd00:805f:db00:b9d6:7e3c:5453:a61c]) by smtp.gmail.com with ESMTPSA id l3sm3045520lji.115.2020.08.02.04.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 04:07:03 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Daniel Thompson Cc: Daniel Vetter , Sam Ravnborg , Alex Deucher , amd-gfx@lists.freedesktop.org, Andrzej Hajda , =?utf-8?q?Christian_K=C3=B6nig?= , Chris Wilson , Ezequiel Garcia , Hans de Goede , Hoegeun Kwon , Inki Dae , Jani Nikula , Jernej Skrabec , Jonas Karlman , Joonas Lahtinen , Jyri Sarha , Kieran Bingham , Konrad Dybcio , Laurent Pinchart , Linus Walleij , linux-renesas-soc@vger.kernel.org, Maarten Lankhorst , Manasi Navare , Neil Armstrong , Patrik Jakobsson , =?utf-8?q?Pawe=C5=82_Chmie?= =?utf-8?q?l?= , Philippe CORNU , Rob Clark , Robert Chiras , Rodrigo Vivi , Sebastian Reichel , Thierry Reding , Tomi Valkeinen , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= , Vinay Simha BN , Wambui Karuga , Zheng Bin Subject: [RFC PATCH v1 0/22] backlight: add init macros and accessors Date: Sun, 2 Aug 2020 13:06:14 +0200 Message-Id: <20200802110636.1018743-1-sam@ravnborg.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org The backlight drivers uses several different patterns when registering a backlight: - Register backlight and assign properties later - Define a local backlight_properties variable and use memset - Define a const backlight_properties and assign relevant properties On top of this there was differences in what members was assigned in backlight_properties. To align how backlight drivers are initialized introduce following helper macros: - DECLARE_BACKLIGHT_INIT_FIRMWARE() - DECLARE_BACKLIGHT_INIT_PLATFORM() - DECLARE_BACKLIGHT_INIT_RAW() The macros are introduced in patch 2. The backlight drivers used direct access to backlight_properties. Encapsulate these in get/set access operations resulting in following benefits: - The drivers no longer need to be concerned about the confusing power states, as there is now only a set_power_on() and set_power_off() operation. - The access methods can be called with a NULL pointer so logic around the access can be made simpler. - The code is in most cases more readable with the access operations. - When everyone uses the access methods refactroring in the backlight core is simpler. The get/set operations are introduced in patch 3. The first patch trims backlight_update_status() so it can be called with a NULL backlight_device. Then the called do not need to add this check just to avoid a NULL reference. The fourth patch introduce the new macros and get/set operations for the gpio backlight driver, as an example. The remaining patches updates most backlight users in drivers/gpu/drm/* With this patch set applied then: - Almost all references to FB_BLANK* are gone from drm/* - All panel drivers uses devm_ variant for registering backlight - Almost all direct references to backlight properties are gone The drm/* patches are used as examples how drivers can benefit from the new macros and get/set operations. Individual patches are only sent to the people listed in the patch + a few more. Please check https://lore.kernel.org/dri-devel/ for the full series. Feedback welcome! Sam Cc: Alex Deucher Cc: amd-gfx@lists.freedesktop.org Cc: Andrzej Hajda Cc: Christian König Cc: Chris Wilson Cc: Daniel Thompson Cc: Ezequiel Garcia Cc: Hans de Goede Cc: Hoegeun Kwon Cc: Inki Dae Cc: Jani Nikula Cc: Jernej Skrabec Cc: Jingoo Han Cc: Jonas Karlman Cc: Joonas Lahtinen Cc: Jyri Sarha Cc: Kieran Bingham Cc: Konrad Dybcio Cc: Laurent Pinchart Cc: Lee Jones Cc: Linus Walleij Cc: linux-renesas-soc@vger.kernel.org Cc: Maarten Lankhorst Cc: Manasi Navare Cc: Neil Armstrong Cc: Patrik Jakobsson Cc: Paweł Chmiel Cc: Philippe CORNU Cc: Rob Clark Cc: Robert Chiras Cc: Rodrigo Vivi Cc: Sam Ravnborg Cc: Sebastian Reichel Cc: Thierry Reding Cc: Tomi Valkeinen Cc: "Ville Syrjälä" Cc: Vinay Simha BN Cc: Wambui Karuga Cc: Zheng Bin Sam Ravnborg (22): backlight: Silently fail backlight_update_status() if no device backlight: Add DECLARE_* macro for device registration backlight: Add get/set operations for brightness/power properties backlight: gpio: Use DECLARE_BACKLIGHT_INIT_RAW and get/setters drm/gma500: Backlight support drm/panel: asus-z00t-tm5p5-n35596: Backlight update drm/panel: jdi-lt070me05000: Backlight update drm/panel: novatek-nt35510: Backlight update drm/panel: orisetech-otm8009a: Backlight update drm/panel: raydium-rm67191: Backlight update drm/panel: samsung-s6e63m0: Backlight update drm/panel: samsung-s6e63j0x03: Backlight update drm/panel: samsung-s6e3ha2: Backlight update drm/panel: sony-acx424akp: Backlight update drm/panel: sony-acx565akm: Backlight update drm/bridge: parade-ps8622: Backlight update drm/tilcdc: Backlight update drm/radeon: Backlight update drm/amdgpu/atom: Backlight update drm/i915: Backlight update drm/omap: display: Backlight update drm/shmobile: Backlight update drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 15 ++- drivers/gpu/drm/bridge/parade-ps8622.c | 43 ++++---- drivers/gpu/drm/gma500/backlight.c | 35 ++---- drivers/gpu/drm/gma500/cdv_device.c | 29 +++-- drivers/gpu/drm/gma500/mdfld_device.c | 9 +- drivers/gpu/drm/gma500/oaktrail_device.c | 10 +- drivers/gpu/drm/gma500/opregion.c | 2 +- drivers/gpu/drm/gma500/psb_device.c | 10 +- drivers/gpu/drm/gma500/psb_drv.c | 8 +- drivers/gpu/drm/i915/display/intel_panel.c | 88 +++++++-------- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 35 ++---- .../gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c | 15 +-- drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 17 ++- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 9 +- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 14 +-- drivers/gpu/drm/panel/panel-raydium-rm67191.c | 11 +- drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 68 ++++++------ drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 56 +++++----- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 25 ++--- drivers/gpu/drm/panel/panel-sony-acx424akp.c | 49 ++------- drivers/gpu/drm/panel/panel-sony-acx565akm.c | 44 +++----- drivers/gpu/drm/radeon/atombios_encoders.c | 23 ++-- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 15 ++- drivers/gpu/drm/shmobile/shmob_drm_backlight.c | 20 ++-- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 11 +- drivers/video/backlight/gpio_backlight.c | 17 ++- include/linux/backlight.h | 120 +++++++++++++++++++++ 27 files changed, 377 insertions(+), 421 deletions(-)