[v3,0/2] max9271: Fix pclk detect silent failure

Message

Jacopo Mondi Nov. 8, 2021, 12:20 p.m. UTC

Repeatedly reading register 0x15 to validate the incoming pixel clock
causes sporadic read errors which went silently ignored, causing the camera
module to fail to start streaming.

Fix that by ignoring the read error and while at it rework the error message
handling in all functions.

v2->v3
- Remove goto from 1/2 as suggested by Geert
v1->v2:
- Drop v1 [1/2]
- [2/2] new patch. Handle all bus access errors in the call sites

Jacopo Mondi (2):
  media: max9271: Ignore busy loop read errors
  media: max9271: Fail loud on bus errors in call sites

 drivers/media/i2c/max9271.c | 116 +++++++++++++++++++++---------------
 1 file changed, 68 insertions(+), 48 deletions(-)

--
2.33.1

Comments

Jacopo Mondi Dec. 16, 2021, 2 p.m. UTC | #1

Hi Sakari, Mauro,
   is it too late to collect these patches for the next merge window ?

On Mon, Nov 08, 2021 at 01:20:41PM +0100, Jacopo Mondi wrote:
> Repeatedly reading register 0x15 to validate the incoming pixel clock
> causes sporadic read errors which went silently ignored, causing the camera
> module to fail to start streaming.
>
> Fix that by ignoring the read error and while at it rework the error message
> handling in all functions.
>
> v2->v3
> - Remove goto from 1/2 as suggested by Geert
> v1->v2:
> - Drop v1 [1/2]
> - [2/2] new patch. Handle all bus access errors in the call sites
>
> Jacopo Mondi (2):
>   media: max9271: Ignore busy loop read errors
>   media: max9271: Fail loud on bus errors in call sites
>
>  drivers/media/i2c/max9271.c | 116 +++++++++++++++++++++---------------
>  1 file changed, 68 insertions(+), 48 deletions(-)
>
> --
> 2.33.1
>