[0/3] drm/cma-helper: Clean up public interface

Message

Thomas Zimmermann Nov. 15, 2021, 12:01 p.m. UTC

Convert GEM CMA functions to accept struct drm_gem_cma_object, provide
small wrappers for GEM object callbacks and update all users. Brings
up the interface to the pattern used in SHMEM and VRAM helpers.

Converting all GEM object functions to use drm_gem_cma_object enables
type checking by the C compiler. Previous callers could have passed any
implementation of drm_gem_object to the GEM CMA helpers. It also
removes upcasting in the GEM functions and simplifies the caller side.
No functional changes.

For GEM object callbacks, the CMA helper library now provides a
number of small wrappers that do the necessary upcasting. Again no
functional changes.

Thomas Zimmermann (3):
  drm/cma-helper: Move driver and file ops to the end of header
  drm/cma-helper: Export dedicated wrappers for GEM object functions
  drm/cma-helper: Pass GEM CMA object in public interfaces

 drivers/gpu/drm/drm_gem_cma_helper.c  |  73 +++++-----
 drivers/gpu/drm/rcar-du/rcar_du_kms.c |  10 +-
 drivers/gpu/drm/vc4/vc4_bo.c          |   8 +-
 include/drm/drm_gem_cma_helper.h      | 189 +++++++++++++++++++-------
 4 files changed, 180 insertions(+), 100 deletions(-)


base-commit: 9fccd12cfac1c863fa46d4d17c2d8ac25a44b190
--
2.33.1

Comments

Thomas Zimmermann Nov. 29, 2021, 9:51 a.m. UTC | #1

ping. Are there further comments on this patchset?

Am 15.11.21 um 13:01 schrieb Thomas Zimmermann:
> Convert GEM CMA functions to accept struct drm_gem_cma_object, provide
> small wrappers for GEM object callbacks and update all users. Brings
> up the interface to the pattern used in SHMEM and VRAM helpers.
> 
> Converting all GEM object functions to use drm_gem_cma_object enables
> type checking by the C compiler. Previous callers could have passed any
> implementation of drm_gem_object to the GEM CMA helpers. It also
> removes upcasting in the GEM functions and simplifies the caller side.
> No functional changes.
> 
> For GEM object callbacks, the CMA helper library now provides a
> number of small wrappers that do the necessary upcasting. Again no
> functional changes.
> 
> Thomas Zimmermann (3):
>    drm/cma-helper: Move driver and file ops to the end of header
>    drm/cma-helper: Export dedicated wrappers for GEM object functions
>    drm/cma-helper: Pass GEM CMA object in public interfaces
> 
>   drivers/gpu/drm/drm_gem_cma_helper.c  |  73 +++++-----
>   drivers/gpu/drm/rcar-du/rcar_du_kms.c |  10 +-
>   drivers/gpu/drm/vc4/vc4_bo.c          |   8 +-
>   include/drm/drm_gem_cma_helper.h      | 189 +++++++++++++++++++-------
>   4 files changed, 180 insertions(+), 100 deletions(-)
> 
> 
> base-commit: 9fccd12cfac1c863fa46d4d17c2d8ac25a44b190
> --
> 2.33.1
>