[v6,00/12] serial: 8250: dw: RZN1 DMA support

Message

Miquel Raynal April 21, 2022, 9:53 a.m. UTC

Hello,

Support for the RZN1 DMA engine allows us adapt a little bit the 8250 DW
UART driver with to bring DMA support for this SoC.

This short series applies on top of the series bringing RZN1 DMA
support, currently on its v11, see [1]. Technically speaking, only the DT
patch needs to be applied after [1]. The other patches can come in at
any moment, because if no "dmas" property is provided in the DT, DMA
support will simply be ignored.

[1] https://lore.kernel.org/dmaengine/[e-mail]/T/#t

Thanks,
Miquèl

Changes in v6:
* Collected more tags.
* Moved some RZN1 definitions below to respect the increasing order of
  the register offsets.
* Renamed the cpr platdata entry to cpr_val.
* Moved the cpr/cpr_val platdata entry closer to usr_reg.
* Dropped the patch from Emil Renner Berthing adding jh7100 support from
  my tree. Squashed the other patch from this external series with the
  fixes which applied on top of it and were supposed to bring platform
  data support.
* Rebased on top of tty-next.

Changes in v5:
* Collected the various tags.
* Updated the style to fit Andy's requests.
* Moved the usr register offset to pdata as advised by Andy.
* Moved the addition of the property.h header to the right patch.
* Return earlier from the IRQ handler whenever possible.
* Moved the dw8250_readl/writel_ext() helpers to dwlib.h so that they
  could be reused by the patch adding rzn1 support.

Changes in v4:
* Squashed the patch changing the quirks type with the patch introducing
  the pdata structure. This way I don't need to go through the uintptr_t
  step. 
* Added a pdata stub to the DW compatible. This way "if (pdata)" checks
  are no longer needed and we can avoid ternary operators disliked by
  Greg.
* Saved the pdata structure pointer inside the per-device structure to
  avoid calling the same device property heplper over and over again. 
* Changed the style a bit to fit Andy's requirements.

Changes in v3:
* Added Geert's Reviewed-by's.
* Used forward declaration in dwlib.h when relevant.
* Reordered the headers when necessary.
* Added a patch changing the quirks type from unsigned long to unsigned
  int as advised by Andy.
* s/up->port.dev/p->dev/ when relevant.
* Added a debug message in dwlib when no CPR is available.
* Dropped the CPR_DMA_EXTRA bit addition: we assume DMA is there.
* Changed the prefix of certain definitions.

Changes in v2:
* Rebased on top of Emil's patches. Added platform data structures
  instead of raw quirk integers in order to provide a CPR value.
* Added includes in dwlib.h even though it's not particularly useful, it
  may help preventing a build error later on if we ever decide to include
  this file from another location.
* Dropped the call to ->tx_dma and instead implemented a callback that
  can be called from serial8250_tx/rx_dma.
* Used the device API instead of the of API.
* Changed the logic about DMA capabilities to avoid breaking existing
  designs.
* Introduced a new quirk related to the flow-control feature of the
  RZ/N1 version of the UART controller when used with DMA.
* Re-arranged the entire series as advised by Andy and Geert.
* Added several preparation patches to ease the review of various
  functional changes.

Emil Renner Berthing (1):
  serial: 8250: dw: Create a generic platform data structure

Miquel Raynal (8):
  serial: 8250: dw: Move the USR register to pdata
  serial: 8250: dw: Allow to use a fallback CPR value if not synthesized
  serial: 8250: dma: Allow driver operations before starting DMA
    transfers
  serial: 8250: dw: Introduce an rx_timeout variable in the IRQ path
  serial: 8250: dw: Move the IO accessors to 8250_dwlib.h
  ARM: dts: r9a06g032: Fill the UART DMA properties
  bestla: Enable DMA, UART3 and UART4
  bestla: Add support for RZN1 dmamux

Phil Edworthy (3):
  serial: 8250: dw: Move definitions to the shared header
  serial: 8250: dw: Add support for DMA flow controlling devices
  serial: 8250: dw: Improve RZN1 support

 .../boot/dts/r9a06g032-rzn1d400-bestla.dts    |  35 +++++
 arch/arm/boot/dts/r9a06g032.dtsi              |  15 ++
 arch/arm/configs/bestla_defconfig             |   2 +-
 drivers/tty/serial/8250/8250.h                |  18 +++
 drivers/tty/serial/8250/8250_dma.c            |   4 +
 drivers/tty/serial/8250/8250_dw.c             | 139 ++++++++++++++----
 drivers/tty/serial/8250/8250_dwlib.c          |  26 +---
 drivers/tty/serial/8250/8250_dwlib.h          |  48 ++++++
 8 files changed, 236 insertions(+), 51 deletions(-)