[v10,0/1] gpio: add simple logic analyzer using polling

Message

Wolfram Sang June 20, 2024, 9:41 a.m. UTC

Changes since v9:
* add comment why late_initcall is used
* use .remove_new instead of .remove
* add needed includes
* use devm for allocating mutex
* remove stray ',' in compatible-array
* remove success message in probe()

Thank you everyone for the valuable feedback so far. Thing is, I am not
sure anymore if this is suitable for upstream. Maybe it is a tad too
hackish. v9 had some ideas for improvements (IIO interface, configfs
support) which I am not going to tackle. For me, it is (and has been)
useful as is, but I need to move on. The latest version of what I use
can be found here:

  git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/topic/gpio-logic-analyzer

If someone wants to continue from here, I am all for it. If that thing
is useful or educational for someone, I am happy. And for those who
don't know what this is about, here is an old coverletter:

===
Here is the next update of the in-kernel logic analyzer based on GPIO
polling with local irqs disabled. It has been tested locally and
remotely. It provided satisfactory results. Besides the driver, there is
also a script which isolates a CPU to achieve the best possible result.
I am aware of the latency limitations. However, the intention is for
debugging only, not mass production. Especially for remote debugging and
to get a first impression, this has already been useful. Documentation
is within the patch, to get a better idea what this is all about.

And an eLinux-wiki page with a picture of a result is here:
https://elinux.org/Kernel_GPIO_Logic_analyzer
===

Wolfram Sang (1):
  gpio: add sloppy logic analyzer using polling

 .../dev-tools/gpio-sloppy-logic-analyzer.rst  |  93 +++++
 Documentation/dev-tools/index.rst             |   1 +
 drivers/gpio/Kconfig                          |  17 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-sloppy-logic-analyzer.c     | 344 ++++++++++++++++++
 tools/gpio/gpio-sloppy-logic-analyzer.sh      | 246 +++++++++++++
 6 files changed, 702 insertions(+)
 create mode 100644 Documentation/dev-tools/gpio-sloppy-logic-analyzer.rst
 create mode 100644 drivers/gpio/gpio-sloppy-logic-analyzer.c
 create mode 100755 tools/gpio/gpio-sloppy-logic-analyzer.sh

Comments

Bartosz Golaszewski July 1, 2024, 8:54 a.m. UTC | #1

From: Bartosz Golaszewski <[e-mail]>


On Thu, 20 Jun 2024 11:41:57 +0200, Wolfram Sang wrote:
> Changes since v9:
> * add comment why late_initcall is used
> * use .remove_new instead of .remove
> * add needed includes
> * use devm for allocating mutex
> * remove stray ',' in compatible-array
> * remove success message in probe()
> 
> [...]

Applied, thanks!

[1/1] gpio: add sloppy logic analyzer using polling
      commit: 7828b7bbbf2074dd7dd14d87f50bc5ce9036d692

Best regards,