mbox series

[0/5] ARM: dts: renesas: bring genmai up to date - the easy stuff

Message ID 20240921114813.4124-7-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series ARM: dts: renesas: bring genmai up to date - the easy stuff | expand

Message

Wolfram Sang Sept. 21, 2024, 11:48 a.m. UTC 
I recently rediscovered the Genmai board as a great platform for
regression testing (RIIC, pre R-Car SDHI and MMCIF). Its DTS file is a
bit outdated, though. This series adds the simple stuff, and reorganizes
it to be sorted. I want to add SDHI and MMCIF on top of this, but those
didn't work out of the box and need a little more work, probably.

Let's start with this seris first. Looking forward to comments.

Happy hacking,

   Wolfram


Wolfram Sang (5):
  ARM: dts: renesas: genmai: enable watchdog
  ARM: dts: renesas: genmai: enable OS timer modules
  ARM: dts: renesas: genmai: sort nodes
  ARM: dts: renesas: genmai: sort pinctrl entries
  ARM: dts: renesas: genmai: define keyboard switch

 arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 136 +++++++++++-------
 1 file changed, 85 insertions(+), 51 deletions(-)

Comments

Rob Herring (Arm) Sept. 25, 2024, 1:56 a.m. UTC | #1 
On Sat, 21 Sep 2024 13:48:12 +0200, Wolfram Sang wrote:
> I recently rediscovered the Genmai board as a great platform for
> regression testing (RIIC, pre R-Car SDHI and MMCIF). Its DTS file is a
> bit outdated, though. This series adds the simple stuff, and reorganizes
> it to be sorted. I want to add SDHI and MMCIF on top of this, but those
> didn't work out of the box and need a little more work, probably.
> 
> Let's start with this seris first. Looking forward to comments.
> 
> Happy hacking,
> 
>    Wolfram
> 
> 
> Wolfram Sang (5):
>   ARM: dts: renesas: genmai: enable watchdog
>   ARM: dts: renesas: genmai: enable OS timer modules
>   ARM: dts: renesas: genmai: sort nodes
>   ARM: dts: renesas: genmai: sort pinctrl entries
>   ARM: dts: renesas: genmai: define keyboard switch
> 
>  arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 136 +++++++++++-------
>  1 file changed, 85 insertions(+), 51 deletions(-)
> 
> --
> 2.45.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y renesas/r7s72100-genmai.dtb' for 20240921114813.4124-7-wsa+renesas@sang-engineering.com:

arch/arm/boot/dts/renesas/r7s72100-genmai.dtb: keyboard: 'interrupt-parent' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
Wolfram Sang Sept. 25, 2024, 8:08 a.m. UTC | #2 
> arch/arm/boot/dts/renesas/r7s72100-genmai.dtb: keyboard: 'interrupt-parent' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#

I fixed this by moving 'interrupt-parent' to 'key-1'. Checked with
dtbs_check now (which I needed to repair first becausde of a Python
version upgrade :/).

Geert, shall I resend the series or just the last patch?