| Message ID | 20241204155806.3781200-1-claudiu.beznea.uj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | serial: sh-sci: Fixes for earlycon and keep_bootcon | expand |
Hi Claudiu, > in the following scenarios: > > 1/ "earlycon keep_bootcon" were present in bootargs > 2/ only "earlycon" was present in bootargs > 3/ none of the "earlycon" or "earlycon keep_bootcon" were present in > bootargs ... > Please give it a try on your devices as well. Will happily do so. Is there something to look for? Except for "it works"? Happy hacking, Wolfram
Hi, Wolfram, On 04.12.2024 23:38, Wolfram Sang wrote: > Hi Claudiu, > >> in the following scenarios: >> >> 1/ "earlycon keep_bootcon" were present in bootargs >> 2/ only "earlycon" was present in bootargs >> 3/ none of the "earlycon" or "earlycon keep_bootcon" were present in >> bootargs > ... >> Please give it a try on your devices as well. > > Will happily do so. Is there something to look for? Except for "it > works"? As this code touches the earlycon functionality, of interest are the 3 cases highlighted above: 1/ "earlycon keep_bootcon" are both present in bootargs 2/ only "earlycon" is present in bootargs 3/ none of the "earlycon" or "earlycon keep_bootcon" are present in bootargs One other thing, that I was currently able to test only on RZ/G3S, is to see how it behaves when the debug serial is described in DT with an alias other than zero. E.g., on [1] the debug serial alias on RZ/G3S was changed from 0 to 3. With the new alias (3) there were issues that I've tried to fix with this series. Thank you for checking it, Claudiu [1] https://lore.kernel.org/all/20241115134401.3893008-6-claudiu.beznea.uj@bp.renesas.com/ > > Happy hacking, > > Wolfram >
Hi, Wolfram, On 05.12.2024 10:39, Claudiu Beznea wrote: > Hi, Wolfram, > > On 04.12.2024 23:38, Wolfram Sang wrote: >> Hi Claudiu, >> >>> in the following scenarios: >>> >>> 1/ "earlycon keep_bootcon" were present in bootargs >>> 2/ only "earlycon" was present in bootargs >>> 3/ none of the "earlycon" or "earlycon keep_bootcon" were present in >>> bootargs >> ... >>> Please give it a try on your devices as well. >> >> Will happily do so. Is there something to look for? Except for "it >> works"? Sorry, I noticed I missed to provide a clear answer your question: if boot works for this scenarios we should be OK. > > As this code touches the earlycon functionality, of interest are the 3 > cases highlighted above: > > 1/ "earlycon keep_bootcon" are both present in bootargs > 2/ only "earlycon" is present in bootargs > 3/ none of the "earlycon" or "earlycon keep_bootcon" are present in > bootargs > > One other thing, that I was currently able to test only on RZ/G3S, is to > see how it behaves when the debug serial is described in DT with an alias > other than zero. E.g., on [1] the debug serial alias on RZ/G3S was changed > from 0 to 3. With the new alias (3) there were issues that I've tried to > fix with this series. If you can also check: - it boots in this case and - the serial device with alias zero and the debug serial are both working (tx, rx are working) after boot then we can declare it OK as well. Thank you, Claudiu > > Thank you for checking it, > Claudiu > > [1] > https://lore.kernel.org/all/20241115134401.3893008-6-claudiu.beznea.uj@bp.renesas.com/ > >> >> Happy hacking, >> >> Wolfram >>
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Hi, This series adds fixes for earlycon and keep_bootcon on sh-sci driver. Patch 1/6 was initially part of [1], then posted as standalone fix at [2]. Patch 5/6 was integrated but then reverted as issues were identified after that with it as standalone patch. I added it in this series to keep all the sh-sci fixes in the same place. All these fixes are prerequisites for the Renesas RZ/G3S SCI support. Series was tested on the boards with the following device trees binaries: - r8a7742-iwg21d-q7.dtb - r8a7743-iwg20d-q7.dtb - r8a7745-iwg22d-sodimm.dtb - r8a77470-iwg23s-sbc.dtb - r8a774a1-hihope-rzg2m-ex.dtb - r8a774b1-hihope-rzg2n-ex.dtb - r8a774e1-hihope-rzg2h-ex.dtb - r9a07g043u11-smarc.dtb - r9a07g044c2-smarc.dtb - r9a07g044l2-smarc.dtb - r9a07g054l2-smarc.dtb - r9a08g045s33-smarc.dtb - r9a08g045s33-smarc-pmod.dtb (not integrated in the latest kernel tree, but the device tree was posted at [3]) in the following scenarios: 1/ "earlycon keep_bootcon" were present in bootargs 2/ only "earlycon" was present in bootargs 3/ none of the "earlycon" or "earlycon keep_bootcon" were present in bootargs 1, 2, 3 were tested also with renesas_defconfig on r9a08g045s33-smarc-pmod.dtb. Please give it a try on your devices as well. Thank you, Claudiu Beznea [1] https://lore.kernel.org/all/20241115134401.3893008-1-claudiu.beznea.uj@bp.renesas.com/ [2] https://lore.kernel.org/all/20241125115856.513642-1-claudiu.beznea.uj@bp.renesas.com/ [3] https://lore.kernel.org/all/20241115134401.3893008-9-claudiu.beznea.uj@bp.renesas.com/ Claudiu Beznea (6): serial: sh-sci: Check if TX data was written to device in .tx_empty() serial: sh-sci: Drop __initdata macro for port_cfg serial: sh-sci: Move runtime PM enable to sci_probe_single() serial: sh-sci: Do not probe the serial port if its slot in sci_ports[] is in use serial: sh-sci: Clean sci_ports[0] after at earlycon exit serial: sh-sci: Increment the runtime usage counter for the earlycon device drivers/tty/serial/sh-sci.c | 121 ++++++++++++++++++++++++++++++------ 1 file changed, 102 insertions(+), 19 deletions(-)