mbox series

[00/11] Add support for RZ/G3E CANFD

Message ID 20250218105007.66358-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series Add support for RZ/G3E CANFD | expand

Message

Biju Das Feb. 18, 2025, 10:49 a.m. UTC
The CAN-FD module on RZ/G3E is very similar to the one on both R-Car V4H
and RZ/G2L, but differs in some hardware parameters:
 * No external clock, but instead has ram clock.
 * Support up to 6 channels.
 * 20 interrupts.

Biju Das (11):
  clk: renesas: r9a09g047: Add CANFD clock/reset
  dt-bindings: can: renesas,rcar-canfd: Fix typo in pattern properties
    for R-Car V4M
  dt-bindings: can: renesas,rcar-canfd: Simplify the conditional schema
  dt-bindings: can: renesas,rcar-canfd: Document RZ/G3E support
  can: rcar_canfd: Fix page entries in the AFL list
  can: rcar_canfd: Add gen4_type variable to struct rcar_canfd_hw_info
  can: rcar_canfd: Add only_internal_clks variable to struct
    rcar_canfd_hw_info
  can: rcar_canfd: Enhance multi_channel_irqs handling
  can: rcar_canfd: Add RZ/G3E support
  arm64: dts: renesas: r9a09g047: Add CANFD node
  arm64: dts: renesas: r9a09g047e57-smarc: Enable CANFD

 .../bindings/net/can/renesas,rcar-canfd.yaml  | 182 +++++++++++++-----
 arch/arm64/boot/dts/renesas/r9a09g047.dtsi    |  62 ++++++
 .../boot/dts/renesas/r9a09g047e57-smarc.dts   |  45 +++++
 .../boot/dts/renesas/renesas-smarc2.dtsi      |  15 ++
 drivers/clk/renesas/r9a09g047-cpg.c           |  10 +
 drivers/net/can/rcar/rcar_canfd.c             |  46 +++--
 6 files changed, 305 insertions(+), 55 deletions(-)

Comments

Marc Kleine-Budde Feb. 18, 2025, 11:14 a.m. UTC | #1
On 18.02.2025 10:49:50, Biju Das wrote:
> The CAN-FD module on RZ/G3E is very similar to the one on both R-Car V4H
> and RZ/G2L, but differs in some hardware parameters:
>  * No external clock, but instead has ram clock.
>  * Support up to 6 channels.
>  * 20 interrupts.

Thanks for you contribution. Can you split this series in fixes and
enhancements and post the fixes as a separate series. Please add
stable@k.o on Cc if needed.

regards,
Marc
Marc Kleine-Budde Feb. 18, 2025, 11:18 a.m. UTC | #2
On 18.02.2025 10:49:50, Biju Das wrote:
> The CAN-FD module on RZ/G3E is very similar to the one on both R-Car V4H
> and RZ/G2L, but differs in some hardware parameters:
>  * No external clock, but instead has ram clock.
>  * Support up to 6 channels.
>  * 20 interrupts.
> 
> Biju Das (11):
>   clk: renesas: r9a09g047: Add CANFD clock/reset
>   dt-bindings: can: renesas,rcar-canfd: Fix typo in pattern properties
>     for R-Car V4M
>   dt-bindings: can: renesas,rcar-canfd: Simplify the conditional schema
>   dt-bindings: can: renesas,rcar-canfd: Document RZ/G3E support
>   can: rcar_canfd: Fix page entries in the AFL list
>   can: rcar_canfd: Add gen4_type variable to struct rcar_canfd_hw_info
>   can: rcar_canfd: Add only_internal_clks variable to struct
>     rcar_canfd_hw_info
>   can: rcar_canfd: Enhance multi_channel_irqs handling
>   can: rcar_canfd: Add RZ/G3E support
>   arm64: dts: renesas: r9a09g047: Add CANFD node
>   arm64: dts: renesas: r9a09g047e57-smarc: Enable CANFD

Please send the dts changes as a separate series, too. They will
probably go mainline via the renesas SoC tree.

regards,
Marc
Biju Das Feb. 18, 2025, 11:46 a.m. UTC | #3
Hi Marc,

Thanks for the feedback.

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 18 February 2025 11:14
> Subject: Re: [PATCH 00/11] Add support for RZ/G3E CANFD
> 
> On 18.02.2025 10:49:50, Biju Das wrote:
> > The CAN-FD module on RZ/G3E is very similar to the one on both R-Car
> > V4H and RZ/G2L, but differs in some hardware parameters:
> >  * No external clock, but instead has ram clock.
> >  * Support up to 6 channels.
> >  * 20 interrupts.
> 
> Thanks for you contribution. Can you split this series in fixes and enhancements and post the fixes as
> a separate series. Please add stable@k.o on Cc if needed.

Sure, will split this series in fixes and enhancements as you suggested.

Cheers,
Biju
Biju Das Feb. 18, 2025, 11:47 a.m. UTC | #4
Hi Marc,

Thanks for the feedback.

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 18 February 2025 11:19
> Subject: Re: [PATCH 00/11] Add support for RZ/G3E CANFD
> 
> On 18.02.2025 10:49:50, Biju Das wrote:
> > The CAN-FD module on RZ/G3E is very similar to the one on both R-Car
> > V4H and RZ/G2L, but differs in some hardware parameters:
> >  * No external clock, but instead has ram clock.
> >  * Support up to 6 channels.
> >  * 20 interrupts.
> >
> > Biju Das (11):
> >   clk: renesas: r9a09g047: Add CANFD clock/reset
> >   dt-bindings: can: renesas,rcar-canfd: Fix typo in pattern properties
> >     for R-Car V4M
> >   dt-bindings: can: renesas,rcar-canfd: Simplify the conditional schema
> >   dt-bindings: can: renesas,rcar-canfd: Document RZ/G3E support
> >   can: rcar_canfd: Fix page entries in the AFL list
> >   can: rcar_canfd: Add gen4_type variable to struct rcar_canfd_hw_info
> >   can: rcar_canfd: Add only_internal_clks variable to struct
> >     rcar_canfd_hw_info
> >   can: rcar_canfd: Enhance multi_channel_irqs handling
> >   can: rcar_canfd: Add RZ/G3E support
> >   arm64: dts: renesas: r9a09g047: Add CANFD node
> >   arm64: dts: renesas: r9a09g047e57-smarc: Enable CANFD
> 
> Please send the dts changes as a separate series, too. They will probably go mainline via the renesas
> SoC tree.

Agreed. Clk, dts as separate series.

Cheers,
Biju