diff mbox series

[4/5] ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig

Message ID 0cd4f4f10245d1d9616e00245093f46acd198141.1555654474.git.horms+renesas@verge.net.au (mailing list archive)
State Accepted
Commit 0cd4f4f10245d1d9616e00245093f46acd198141
Delegated to: Simon Horman
Headers show
Series [GIT,PULL] Renesas ARM Based SoC Defconfig Updates for v5.2 | expand

Commit Message

Simon Horman April 19, 2019, 2:34 p.m. UTC 
From: Biju Das <biju.das@bp.renesas.com>

Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig so that boards
based on RZ/G1C SoC design can use the corresponding driver.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven April 23, 2019, 9:20 a.m. UTC | #1 
Hi Simon, Biju,

On Fri, Apr 19, 2019 at 4:36 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig so that boards
> based on RZ/G1C SoC design can use the corresponding driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/configs/shmobile_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 291abdd650ed..30abd8176010 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -197,6 +197,7 @@ CONFIG_PWM_RENESAS_TPU=y
>  CONFIG_RESET_CONTROLLER=y
>  CONFIG_GENERIC_PHY=y
>  CONFIG_PHY_RCAR_GEN2=y
> +CONFIG_PHY_RCAR_GEN3_USB2=y

As PHY_RCAR_GEN3_USB2 selects GENERIC_PHY, the line

    CONFIG_GENERIC_PHY=y

should be removed from shmobile_defconfig.

>  # CONFIG_DNOTIFY is not set
>  CONFIG_MSDOS_FS=y
>  CONFIG_VFAT_FS=y

Gr{oetje,eeting}s,

                        Geert
Biju Das April 23, 2019, 9:45 a.m. UTC | #2 
Hi Geert,

Thanks for the feedback.

Simon,
 
How do you want to address this? A new patch for  taking out "CONFIG_GENERIC_PHY=y"
from shmobile_defconfig  ?? Please let us know.

Regards,
Biju


> -----Original Message-----
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-
> owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> Sent: 23 April 2019 10:21
> To: Simon Horman <horms+renesas@verge.net.au>; Biju Das
> <biju.das@bp.renesas.com>
> Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>; Magnus Damm
> <magnus.damm@gmail.com>; Linux ARM <linux-arm-
> kernel@lists.infradead.org>
> Subject: Re: [PATCH 4/5] ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in
> shmobile_defconfig
> 
> Hi Simon, Biju,
> 
> On Fri, Apr 19, 2019 at 4:36 PM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Biju Das <biju.das@bp.renesas.com>
> >
> > Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig so that boards
> based
> > on RZ/G1C SoC design can use the corresponding driver.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/configs/shmobile_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > index 291abdd650ed..30abd8176010 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -197,6 +197,7 @@ CONFIG_PWM_RENESAS_TPU=y
> > CONFIG_RESET_CONTROLLER=y  CONFIG_GENERIC_PHY=y
> > CONFIG_PHY_RCAR_GEN2=y
> > +CONFIG_PHY_RCAR_GEN3_USB2=y
> 
> As PHY_RCAR_GEN3_USB2 selects GENERIC_PHY, the line
> 
>     CONFIG_GENERIC_PHY=y
> 
> should be removed from shmobile_defconfig.

> >  # CONFIG_DNOTIFY is not set
> >  CONFIG_MSDOS_FS=y
> >  CONFIG_VFAT_FS=y
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
Simon Horman April 23, 2019, 10:28 a.m. UTC | #3 
On Tue, Apr 23, 2019 at 09:45:18AM +0000, Biju Das wrote:
> Hi Geert,
> 
> Thanks for the feedback.
> 
> Simon,
>  
> How do you want to address this? A new patch for  taking out "CONFIG_GENERIC_PHY=y"
> from shmobile_defconfig  ?? Please let us know.

Hi Biju,

yes, I think that an incremental patch would be best.
Biju Das April 23, 2019, 10:38 a.m. UTC | #4 
Hello Simon,

Thanks for the feedback.

> Subject: Re: [PATCH 4/5] ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in
> shmobile_defconfig
> 
> On Tue, Apr 23, 2019 at 09:45:18AM +0000, Biju Das wrote:
> > Hi Geert,
> >
> > Thanks for the feedback.
> >
> > Simon,
> >
> > How do you want to address this? A new patch for  taking out
> "CONFIG_GENERIC_PHY=y"
> > from shmobile_defconfig  ?? Please let us know.
> 
> Hi Biju,
> 
> yes, I think that an incremental patch would be best.

Ok. Will send an incremental patch to take out " CONFIG_GENERIC_PHY=y" from shmobile_defconfig .

Regards,
Biju
diff mbox series

Patch

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 291abdd650ed..30abd8176010 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -197,6 +197,7 @@  CONFIG_PWM_RENESAS_TPU=y
 CONFIG_RESET_CONTROLLER=y
 CONFIG_GENERIC_PHY=y
 CONFIG_PHY_RCAR_GEN2=y
+CONFIG_PHY_RCAR_GEN3_USB2=y
 # CONFIG_DNOTIFY is not set
 CONFIG_MSDOS_FS=y
 CONFIG_VFAT_FS=y