From patchwork Tue Jan 19 12:19:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ulrich Hecht X-Patchwork-Id: 8061261 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-renesas-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9FD199F8AA for ; Tue, 19 Jan 2016 12:19:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 05BF120392 for ; Tue, 19 Jan 2016 12:19:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 030322038A for ; Tue, 19 Jan 2016 12:19:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753021AbcASMTW (ORCPT ); Tue, 19 Jan 2016 07:19:22 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:35747 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753605AbcASMTV (ORCPT ); Tue, 19 Jan 2016 07:19:21 -0500 Received: by mail-lb0-f175.google.com with SMTP id bc4so361379870lbc.2; Tue, 19 Jan 2016 04:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=8zQ84K7fjOJfZvrNZa1lQrROw+2nJy151pnXuWeKfqA=; b=zN63nkiDWU7BMLcaAPZ3ucxnBjUnZs2DAaFEFrVBi/scHcfk3kde5f88H4fbfBvmqi SrALU0H6uRGEcIDzz0CjGhYLDbf66uA2Mkhw+Rw3gBhnSBtI1Xmg1v4kXvpD2v2jPRZo 22veBL+gvRmeIoj/f7WX24g0pAFMLCI+mx6nlc9Pd8f9fz98cFo5I1moguHQRw2pl12j i3PgS4fYGBEkfh7SlvXOlJApFM6VPpfa+cNaVY1CMU23HWo3fXLhX2xbQMSOf4TAmodT vKqEMBnLeq2K9bb2rW/n44TztGTyUXrc9yLwt1+g3k7KrGJrJb0mCfM38AhGlRIk0SDI ThxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=8zQ84K7fjOJfZvrNZa1lQrROw+2nJy151pnXuWeKfqA=; b=k4oxLs+oHI58TAnzOoJyPFcHkSWe0c8BfigN8tRoO5Rnto6877wQHt5ihayIffuekD xptPd1qXabictiENro+zuwTOi0N1quCE3FH7e6PE7ZU9eIH56+Nd6N5qOwsuxEOFS2Ui YAWkFAQ8yjWaX657mpe0EA9yr2PsypW3XKs788NsIukmUriL1xzPAlbcbqt3HpoK44VF /04DtlY95TBWY2IWDN1kRrnrg7NJwT2UbHltVyxd0tG02rLy0NVGF0fafvh/PuGJAeER rdnRx6zNYIFgEo1zg2KdMHoYNm6NIRIYwqXmA3mJL8CaXpaFUSNhJLlmtCvRMO7Z98NU +xqQ== X-Gm-Message-State: ALoCoQnRhUjot3az5xfx4d/Bwxyj9LaO3bSl5n6g2ohLJj44joOgjzY6jBWn715Abqx94W/KQv1nO/7e8HI0IwGn54jD5A7miA== X-Received: by 10.112.198.72 with SMTP id ja8mr10537635lbc.142.1453205960348; Tue, 19 Jan 2016 04:19:20 -0800 (PST) Received: from groucho.site (ip9234e209.dynamic.kabel-deutschland.de. [146.52.226.9]) by smtp.gmail.com with ESMTPSA id xo4sm3926762lbb.27.2016.01.19.04.19.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jan 2016 04:19:19 -0800 (PST) From: Ulrich Hecht To: linux-media@vger.kernel.org, hans.verkuil@cisco.com Cc: linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, ian.molton@codethink.co.uk, lars@metafoo.de, william.towle@codethink.co.uk, niklas.soderlund+renesas@ragnatech.se, Ulrich Hecht Subject: [RESEND PATCH] media: adv7180: increase delay after reset to 5ms Date: Tue, 19 Jan 2016 13:19:16 +0100 Message-Id: <1453205956-9103-1-git-send-email-ulrich.hecht+renesas@gmail.com> X-Mailer: git-send-email 2.6.4 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initialization of the ADV7180 chip fails on the Renesas R8A7790-based Lager board about 50% of the time. This patch resolves the issue by increasing the minimum delay after reset from 2 ms to 5 ms, following the recommendation in the ADV7180 datasheet: "Executing a software reset takes approximately 2 ms. However, it is recommended to wait 5 ms before any further I2C writes are performed." Signed-off-by: Ulrich Hecht Acked-by: Laurent Pinchart Acked-by: Lars-Peter Clausen Tested-by: Niklas Söderlund --- drivers/media/i2c/adv7180.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index f82c8aa..3c3c4bf 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -1112,7 +1112,7 @@ static int init_device(struct adv7180_state *state) mutex_lock(&state->mutex); adv7180_write(state, ADV7180_REG_PWR_MAN, ADV7180_PWR_MAN_RES); - usleep_range(2000, 10000); + usleep_range(5000, 10000); ret = state->chip_info->init(state); if (ret)