Message ID | 1456997751-5828-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Geert Uytterhoeven |
Headers | show
Return-Path: <linux-renesas-soc-owner@kernel.org> X-Original-To: patchwork-linux-renesas-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 441F8C0553 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Thu, 3 Mar 2016 09:36:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AB34F20295 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Thu, 3 Mar 2016 09:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1B6220270 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Thu, 3 Mar 2016 09:36:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757012AbcCCJgC (ORCPT <rfc822;patchwork-linux-renesas-soc@patchwork.kernel.org>); Thu, 3 Mar 2016 04:36:02 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:25805 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756716AbcCCJgA (ORCPT <rfc822;linux-renesas-soc@vger.kernel.org>); Thu, 3 Mar 2016 04:36:00 -0500 Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie1.idc.renesas.com with ESMTP; 03 Mar 2016 18:35:59 +0900 Received: from relmlac4.idc.renesas.com (relmlac4.idc.renesas.com [10.200.69.24]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 4BAE863013; Thu, 3 Mar 2016 18:35:59 +0900 (JST) Received: by relmlac4.idc.renesas.com (Postfix, from userid 0) id 3B177480A5; Thu, 3 Mar 2016 18:35:59 +0900 (JST) Received: from relmlac4.idc.renesas.com (localhost [127.0.0.1]) by relmlac4.idc.renesas.com (Postfix) with ESMTP id 36C40480A3; Thu, 3 Mar 2016 18:35:59 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac4.idc.renesas.com with ESMTP id UAD19700; Thu, 3 Mar 2016 18:35:59 +0900 X-IronPort-AV: E=Sophos;i="5.22,531,1449500400"; d="scan'";a="206908996" Received: from mail-sg2apc01lp0244.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.244]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA; 03 Mar 2016 18:35:58 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesasgroup-onmicrosoft-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hEjTIWuxAve24K3hko8yUTj5IzUXpvFpdoGE8lqTpFE=; b=O2xTPfbrRMX3fmAFcYeSY2WujWiznLlWCI3qPe1ot2+p6uTt1GADJHENYa39jjpTmQvc3kG2n0/Nrt0seG6ydgy4Ivgzk6pe7HvulxoFWYCKMdGHiFl+9mT7dqVZzhyqBaElUmR7HynPFb6c3v7W7vg72ZqpLDhSFdfwcUe/1xI= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from localhost (211.11.155.144) by SIXPR06MB0922.apcprd06.prod.outlook.com (10.162.173.157) with Microsoft SMTP Server (TLS) id 15.1.415.20; Thu, 3 Mar 2016 09:35:57 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: <balbi@kernel.org> CC: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH/RESEND] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable() Date: Thu, 3 Mar 2016 18:35:51 +0900 Message-ID: <1456997751-5828-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.4.msysgit.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR06CA0003.apcprd06.prod.outlook.com (25.164.91.13) To SIXPR06MB0922.apcprd06.prod.outlook.com (25.162.173.157) X-Microsoft-Exchange-Diagnostics: 1; SIXPR06MB0922; 2:XSjkx5l17SmDCj9JP8FxxqKG6HwTSJC1DZWsDmZYtaud09uJMB0204N35kaPTQnfmqm6IlSun+Gf2OUddFSV6Q+SqsDFdvfGMCFEAm5rtAQYYkeWfrkWS4UxjSb+Ai0yO0TxhGgQZVtc/0qh0yLlOA==; 3:8gdlTlWMwoi9E3T/iaN3/8pRRmrglapFh6fx1dNlFT0PpEDsGVeQ8vS6v+hIbFJ+0D8nVg9rahuQPQe+xKzERUWaaw+HNNCDNrDm7+EC0ZtkP6/NGCeaHmTY1UU/neHo; 25:GigeiWjA9uYS2SQsybpT/6RdMjXPq0DSRHWH/QCC/vyjuenvgQQLBeRjR3pZytI/LNUst/hjEy5pODfYUQ7E8GEOZWBimDEroALwlNHNs1yCHnIEP+5S+RH6Jo68Avm03dsI0PN5ikvKH/SNu5uOnYAFemBaSSX8Zgz6MmQeDCCNXUzjoHHb5VzldLSMf68/9LrShYIt/SWcKMHp4fq5onlgJPUGVsBLsFe2HbFCHMXtS+9XrEPZW9wjf0ilCHwy9HxHMZRx06RNYRZntZMNaqbcmzpEQFRLDmZHkW1YN70bvQHsUrZXS9S0CLJrui0cxpX2V1PGC/HZERHasftfew== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SIXPR06MB0922; X-MS-Office365-Filtering-Correlation-Id: e42b7ee5-c3cb-4bf7-a32c-08d34347396a X-Microsoft-Exchange-Diagnostics: 1; SIXPR06MB0922; 20:r1+MxdpwF+gfzWZ6MO2W/lbMNS+rvHfjXVMcS3WffbL8lpvxSG6pZiXvwbgqKitOLHoCEPPGBIEcg+SAHBUgxOW7gfTxs1V1ExaG3YhZmBieIoaIKT+sdnRq8Z8R4HuFBq3uFWbWK8qqYTLkC9FawrMM4WekXwhYszhNlK1uACTGXhoJGxdAyzk4jKjGFvfnG75fKDPaS9kOHlSB5F/rHOoC5l/l9eLXisgcGsHil2jsHxDEbYKMbX2V3HBrKv9+sGQvGRj+2/iNThIiYGogGaf7Sbif1UuiDWo/CbKx9SBJnsemvK61J+mccgOKgaqQslpNqwbIzvYzZSb65Cpvmg0niKwQp8WxdrCvR+wGWLC2tAl7tG5vorP81Jq8rZRRduorUtqsO5AXYr1ogA8R2k+xI9suouz2W4Rq/6jbUW9Ks7EQ3R6kfxAfUNoCBETx6JOrAi+l83y7jPHSYGayCFSB836La8otuzDBsRa6Li3FlyAmMiFq+XFuEw5Iq72X; 4:uKm86K6fJ7fm2QP51E+g01y9QFiCH84A2R/FVbaYsYrJ2Cp+NBKtZ0aIrxRnWrNbMJhSWDKX7DD0OxEwoME71Kgwy1O+USFEjxJgVxpfDde5WoCy+ue+kp4V33aVGRnAYvPi+whWXc/XHy2/uQTLTCeGcBtrM0q7F93KJ9aPozSQrlb9hDNO/lxUoNbK0OL9otyt4eV4djfQ+LDBe5gtfNGEGlC/3JsxYvaiCxJvu6VhARWKlY5cnpJnKWLWg58mznqz/ltDe7ugPpsYVyohN2PJg8IZXs9VZLEWdpuamIIlyNrsI6upjhFjNx31qoY5CqFNvwZz+9lulIkZ5wlXLHt4tJNhtAgZ+PqCVXr9cWDVFvOV9havFp9xF8v6v/vk X-Microsoft-Antispam-PRVS: <SIXPR06MB0922B49F965514F651DFF9F0B8BD0@SIXPR06MB0922.apcprd06.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:SIXPR06MB0922; BCL:0; PCL:0; RULEID:; SRVR:SIXPR06MB0922; X-Forefront-PRVS: 0870212862 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6069001)(6009001)(77096005)(4326007)(92566002)(47776003)(5004730100002)(229853001)(66066001)(42186005)(2351001)(19580405001)(40100003)(1096002)(19580395003)(5001960100004)(50466002)(586003)(42382002)(189998001)(107886002)(2906002)(122386002)(78352003)(4001430100002)(6116002)(3846002)(50226001)(5008740100001)(110136002)(48376002)(76506005)(87976001)(36756003)(50986999)(33646002)(5003940100001); DIR:OUT; SFP:1102; SCL:1; SRVR:SIXPR06MB0922; H:localhost; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SIXPR06MB0922; 23:nGTmQoNnFLlMgS2jCwsCmb+msTyveA6oN0UJdpvFO?= =?us-ascii?Q?saTTuu/YWTGNR6bGOQZByeufvHeByQbUmO9tqPMkRjchfXA/XC9pTsu0js/b?= =?us-ascii?Q?/CLUSIw2hC7XEtVNSfD+70RJZy1F6eWak+l02Zfk/xFSqV5ioKbPU2QoYusy?= =?us-ascii?Q?fQAjV4lVVSbWQB65/LtuQlrh7YAjhzR4vuk349h0ZMPh4iBi4tfMbTuN/2pE?= =?us-ascii?Q?6YI0/WmnvDYU9L9ClWpjG8ZnAO/+LPVG6amBYopan1TTu4Nyg0QaWtwNoTkD?= =?us-ascii?Q?8JfIk4kU3AoljbkMKCT76xlIIo00VWXQIm9JSo6x1iPmuzPTPL6huyOC5fDR?= =?us-ascii?Q?xAibPhKZFelX0O3prhFAxgimC5C527dTqRU40Onzb/XUgr2V31XvIBXrnVKT?= =?us-ascii?Q?1EG6S2A3zUDwaxMPbBQEHS0sgpZ/tya2jE5/LMHRUxl0e3gxHgHgo/TgwkYc?= =?us-ascii?Q?MhhEp2Llk3Z2ZNf172uwBvOF84iN5kj2y+srAPjnlSnT0zIdrQNrQxsr6Y2U?= =?us-ascii?Q?XuZ2k8Ir/gFPcdO4dvqU+XH9UnrxUTR9yQAfCl7qfLoDC4gwYumQy2qKbtwj?= =?us-ascii?Q?QPbjQDtJocwoF/gWVeXxgDTgsWYzgJb0YZ2ngS9Epl+fDmESYVbzbCy7y7nG?= =?us-ascii?Q?Sle3pqjtT8nOldXWdSPk+5REV0tEQQqOwhrVMCERxJBN9TiObvFMUup2r0+J?= =?us-ascii?Q?n5T7MCDCUhC3GoeSR+a9t8OEYntiVc0iwSK69BNsUUOyiecbZpoh4h0j0k9y?= =?us-ascii?Q?Fg51sD4Irw4Pg+Pp6dwhHJGfePZEpts0/Nu+qU9aP+KDJPhldqNRbE4bUuZX?= =?us-ascii?Q?neaVulZu8YhQkMLxBT/PvB8ktOqHrxaEVOtG2youxgN8Qf4CEO58CNxpkFhC?= =?us-ascii?Q?R1cK6vz6NYtEIJnl2IFeZv6/t7oxI7umc5a9KaRlPkUw6nJgTD49FBxt4iSQ?= =?us-ascii?Q?2oNrK8HPALrA+k+/i7bOuMQWQFyWm4IRoTUBXatUcjUqOrXHpWJcA39KzX8S?= =?us-ascii?Q?+/sNhavnisru+qjOayBmJhTJ+MkLOOPKvDriEb7HlJuqg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SIXPR06MB0922; 5:N3atETFNYjyON0jJzXqit16rl25mATAEjlKU+aLYB1eTAwtSdEvZcTXhyJ9vJ9v2CElL6rOIpTMOf+mFXvtnfvHu5Jh7Cup8E2uR1WTpoQdCv6H1YBCq9tGToQ46J2XIi0OEDlq2C88UmmXj8pjBPA==; 24:T8rQixXQCnC1gSMxGCXAft2tJoD9HCXDuSuPiXuaRHAGbonAvi8zCOYQTz6AEMSFxM6sIFnfW6qhJwQjwboCat8kNod2aHkrUdYvvy8B7ag=; 20:/gbf/H4yWtVsiRY3JFoHVGZbN0Wz4oP/1+YUeKP178iC1wlYPpUf0cLMFUGFZ2jrqr82pw118De7xPaMahy04z7+iTMcLKWCvU8HpVh1OUMZANCwUTgDkohsGI7zW9Xod0rxWaIQ9UjSCRlxC1eze1CnvVPUiR8xn3edb4nuXqk= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2016 09:35:57.1275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR06MB0922 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: <linux-renesas-soc.vger.kernel.org> X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 657f967..664b263 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -561,7 +561,7 @@ static int usbhsg_pipe_disable(struct usbhsg_uep *uep) if (!pkt) break; - usbhsg_queue_pop(uep, usbhsg_pkt_to_ureq(pkt), -ECONNRESET); + usbhsg_queue_pop(uep, usbhsg_pkt_to_ureq(pkt), -ESHUTDOWN); } usbhs_pipe_disable(pipe);
A udc driver should set the giveback status to -ESHUTDOWN in usb_ep_disable(). Otherwise, a gadget driver (e.g. g_serial) might request next data wrongly and it is possible to cause kernel panic. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/renesas_usbhs/mod_gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)