diff mbox

[v2] ARM: dts: r8a7793: Add MMCIF0

Message ID 1460995360-11417-1-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State Superseded
Commit e3183ac5bafa195d481373c115b3c71d6870c0e5
Delegated to: Simon Horman
Headers show

Commit Message

Ulrich Hecht April 18, 2016, 4:02 p.m. UTC
Same as on r8a7794.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
This revision adds the missing dma-names and power-domains entires spotted
by Sergei and Simon.

CU
Uli


 arch/arm/boot/dts/r8a7793.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Geert Uytterhoeven April 21, 2016, 12:52 p.m. UTC | #1
On Mon, Apr 18, 2016 at 6:02 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Same as on r8a7794.

r8a7791?

> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -510,6 +510,19 @@
>                 reg = <0 0xe6060000 0 0x250>;
>         };
>
> +       mmcif0: mmcif@ee200000 {
> +               compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> +               reg = <0 0xee200000 0 0x80>;
> +               interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;

s/0/GIC_SPI/

> +               clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> +               dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> +                      <&dmac1 0xd1>, <&dmac1 0xd2>;
> +               dma-names = "tx", "rx", "tx", "rx";
> +               power-domains = <&cpg_clocks>;
> +               reg-io-width = <4>;
> +               status = "disabled";

max-frequency = <97500000>;?

It's always a good idea to compare r8a7791.dts and r8a7793.dtsi
after s/r8a779[13]/r8a779x/...

> +       };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Simon Horman April 22, 2016, 12:20 a.m. UTC | #2
On Thu, Apr 21, 2016 at 02:52:09PM +0200, Geert Uytterhoeven wrote:
> On Mon, Apr 18, 2016 at 6:02 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Same as on r8a7794.
> 
> r8a7791?
> 
> > --- a/arch/arm/boot/dts/r8a7793.dtsi
> > +++ b/arch/arm/boot/dts/r8a7793.dtsi
> > @@ -510,6 +510,19 @@
> >                 reg = <0 0xe6060000 0 0x250>;
> >         };
> >
> > +       mmcif0: mmcif@ee200000 {
> > +               compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> > +               reg = <0 0xee200000 0 0x80>;
> > +               interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> 
> s/0/GIC_SPI/
> 
> > +               clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> > +               dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> > +                      <&dmac1 0xd1>, <&dmac1 0xd2>;
> > +               dma-names = "tx", "rx", "tx", "rx";
> > +               power-domains = <&cpg_clocks>;
> > +               reg-io-width = <4>;
> > +               status = "disabled";
> 
> max-frequency = <97500000>;?
> 
> It's always a good idea to compare r8a7791.dts and r8a7793.dtsi
> after s/r8a779[13]/r8a779x/...
> 
> > +       };

Thanks Geert,

it looks like I was a little hasty in queueing up this patch.
I have dropped it for now. 

Ulrich,

please address the feedback and repost.

Thanks
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index bf70c46..6843f46 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -510,6 +510,19 @@ 
 		reg = <0 0xe6060000 0 0x250>;
 	};
 
+	mmcif0: mmcif@ee200000 {
+		compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
+		reg = <0 0xee200000 0 0x80>;
+		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
+		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
+		       <&dmac1 0xd1>, <&dmac1 0xd2>;
+		dma-names = "tx", "rx", "tx", "rx";
+		power-domains = <&cpg_clocks>;
+		reg-io-width = <4>;
+		status = "disabled";
+	};
+
 	scifa0: serial@e6c40000 {
 		compatible = "renesas,scifa-r8a7793",
 			     "renesas,rcar-gen2-scifa", "renesas,scifa";