| Message ID | 1472021362-8085-2-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Shimoda-san, On Wed, Aug 24, 2016 at 8:49 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > The clocks property should be set to &cpg, not &mstpX_clks. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > index 2281d6c..b54fb36 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > @@ -30,11 +30,11 @@ Example (R-Car H3): > compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; > reg = <0 0xee080200 0 0x700>; > interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&mstp7_clks R8A7795_CLK_EHCI0>; > + clocks = <&cpg CPG_MOD 703>; > }; > > usb-phy@ee0a0200 { > compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; > reg = <0 0xee0a0200 0 0x700>; > - clocks = <&mstp7_clks R8A7795_CLK_EHCI0>; > + clocks = <&cpg CPG_MOD 702>; > }; BTW, do you want to add #phy-cells and power-domains properties? BTW2, the actual .dtsi doesn't have the "renesas,rcar-gen3-usb2-phy" fallback properties. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Aug 24, 2016 at 03:49:21PM +0900, Yoshihiro Shimoda wrote: > The clocks property should be set to &cpg, not &mstpX_clks. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt index 2281d6c..b54fb36 100644 --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt @@ -30,11 +30,11 @@ Example (R-Car H3): compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; reg = <0 0xee080200 0 0x700>; interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&mstp7_clks R8A7795_CLK_EHCI0>; + clocks = <&cpg CPG_MOD 703>; }; usb-phy@ee0a0200 { compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; reg = <0 0xee0a0200 0 0x700>; - clocks = <&mstp7_clks R8A7795_CLK_EHCI0>; + clocks = <&cpg CPG_MOD 702>; };
The clocks property should be set to &cpg, not &mstpX_clks. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)