| Message ID | 1480693434-9415-4-git-send-email-jacopo@jmondi.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Jacopo, On Fri, Dec 2, 2016 at 4:43 PM, Jacopo Mondi <jacopo@jmondi.org> wrote: > spidev is not meant to be configured directly from DTS anymore. > Since we're prototyping, add the "linux,spidev" compatibility string > back I guess you needed this because you used "linux,spidev" in your DTS? With "spidev", it should work out-of-the-box. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On 03/12/2016 11:30, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Fri, Dec 2, 2016 at 4:43 PM, Jacopo Mondi <jacopo@jmondi.org> wrote: >> spidev is not meant to be configured directly from DTS anymore. >> Since we're prototyping, add the "linux,spidev" compatibility string >> back > > I guess you needed this because you used "linux,spidev" in your DTS? > With "spidev", it should work out-of-the-box. > Oh, yes it does! I can drop this patch and use "spidev" in [2/3] Thanks j > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 6941e04..e767265 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -690,6 +690,7 @@ static int spidev_remove(struct spi_device *spi) } static const struct of_device_id spidev_dt_ids[] = { + { .compatible = "linux,spidev" }, { .compatible = "rohm,dh2228fv" }, {}, };
spidev is not meant to be configured directly from DTS anymore. Since we're prototyping, add the "linux,spidev" compatibility string back Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+)