| Message ID | 1485367787-8109-6-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
On 1/25/2017 9:09 PM, Jacopo Mondi wrote: > Add TxD and RxD pin configuration for SCIF2 serial communication > interface on r7s72100 Genmai board. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > arch/arm/boot/dts/r7s72100-genmai.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts > index 118a8e2..ea649c7 100644 > --- a/arch/arm/boot/dts/r7s72100-genmai.dts > +++ b/arch/arm/boot/dts/r7s72100-genmai.dts [...] > @@ -34,6 +35,18 @@ > #address-cells = <1>; > #size-cells = <1>; > }; > + > +}; > + > +&pinctrl { > + pinctrl-names = "default"; > + pinctrl-0 = <&scif2_pins>; > + > + scif2_pins: serial2 { > + /* P3_0 as TxD2; P3_2 as RxD2 */ > + renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>, The comma should be after the vendor prefix ("renesas"). MBR, Sergei
Hello, On Thursday 26 Jan 2017 12:51:03 Sergei Shtylyov wrote: > On 1/25/2017 9:09 PM, Jacopo Mondi wrote: > > Add TxD and RxD pin configuration for SCIF2 serial communication > > interface on r7s72100 Genmai board. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > --- > > > > arch/arm/boot/dts/r7s72100-genmai.dts | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts > > b/arch/arm/boot/dts/r7s72100-genmai.dts index 118a8e2..ea649c7 100644 > > --- a/arch/arm/boot/dts/r7s72100-genmai.dts > > +++ b/arch/arm/boot/dts/r7s72100-genmai.dts > > [...] > > > @@ -34,6 +35,18 @@ > > #address-cells = <1>; > > #size-cells = <1>; > > }; > > + That's not needed. > > +}; > > + > > +&pinctrl { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&scif2_pins>; > > + > > + scif2_pins: serial2 { > > + /* P3_0 as TxD2; P3_2 as RxD2 */ > > + renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>, > > The comma should be after the vendor prefix ("renesas"). And the "-rz" suffix isn't needed, "renesas,pins" will do.
Hi Laurent, On Mon, Jan 30, 2017 at 7:17 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thursday 26 Jan 2017 12:51:03 Sergei Shtylyov wrote: >> On 1/25/2017 9:09 PM, Jacopo Mondi wrote: >> > +&pinctrl { >> > + pinctrl-names = "default"; >> > + pinctrl-0 = <&scif2_pins>; >> > + >> > + scif2_pins: serial2 { >> > + /* P3_0 as TxD2; P3_2 as RxD2 */ >> > + renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>, >> >> The comma should be after the vendor prefix ("renesas"). > > And the "-rz" suffix isn't needed, "renesas,pins" will do. Then it can just become "pins"? Or not? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts index 118a8e2..ea649c7 100644 --- a/arch/arm/boot/dts/r7s72100-genmai.dts +++ b/arch/arm/boot/dts/r7s72100-genmai.dts @@ -11,6 +11,7 @@ /dts-v1/; #include "r7s72100.dtsi" +#include "include/dt-bindings/pinctrl/pinctrl-renesas-rz.h" / { model = "Genmai"; @@ -34,6 +35,18 @@ #address-cells = <1>; #size-cells = <1>; }; + +}; + +&pinctrl { + pinctrl-names = "default"; + pinctrl-0 = <&scif2_pins>; + + scif2_pins: serial2 { + /* P3_0 as TxD2; P3_2 as RxD2 */ + renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>, + <RZ_PIN(3, 2) ALTERNATE_FUNC_4>; + }; }; &extal_clk {
Add TxD and RxD pin configuration for SCIF2 serial communication interface on r7s72100 Genmai board. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- arch/arm/boot/dts/r7s72100-genmai.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)