From patchwork Fri Feb 3 10:38:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Hecht X-Patchwork-Id: 9553855 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 96053604A7 for ; Fri, 3 Feb 2017 10:38:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 866732831C for ; Fri, 3 Feb 2017 10:38:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7AA8228515; Fri, 3 Feb 2017 10:38:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B06082831C for ; Fri, 3 Feb 2017 10:38:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbdBCKie (ORCPT ); Fri, 3 Feb 2017 05:38:34 -0500 Received: from mail-wj0-f194.google.com ([209.85.210.194]:33018 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbdBCKid (ORCPT ); Fri, 3 Feb 2017 05:38:33 -0500 Received: by mail-wj0-f194.google.com with SMTP id le4so432108wjb.0; Fri, 03 Feb 2017 02:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=6ApTiiNvI2yrG3ymsNzbPCjKRdaRUglZLLDNmAoYoo8=; b=qnH1r3j6AyuZdlPv0kQSIGQkldAEq4YHvZy65ajlBJMS36ODRLP2s91oW4ZzZvsPMS 3t5OncupHiUrAu6faMmI6OR+LcvfScWnzxTRA60xEE9fjWDeygKsGbNzqvn3vDgOkiDT +9qd0fGQIHQqmbFARQZVXbA3fExhYOHjmglnYmpTSOSycZ28GpxmeDsrXlzujD0mOQ+K tJR6O1ag6tqFoHOIw4SkFijdr+9apU45G5AiopaaHaljLeHOyMyX9OHOAkUgaAPPo9lI s5QeM8gd6MxGhKEE10GDv77yH0RaDPkdq/TinOEglnN2dXa47inWFSrAo6syqUwU0ODU DA4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=6ApTiiNvI2yrG3ymsNzbPCjKRdaRUglZLLDNmAoYoo8=; b=UoC+voIA4EzcJF9FJSQKL7B40w/D07NmARfsTOD8vL90UiXIlrABoydaRQ97M3Mfeq p3GzkpzClQXGVOJOky9ti9rzWboMmpKr3VwL0ehMvpW+jTFBYErL2SNQjTUFtO84xjTk T/D6vbHaHEi/A8LaWVH28psM9xpBPGbQ+irSdCGs2a0BsfIRanMMMHpdNGG6ekz+buuD l0abbu2V7Kbbhn3zJ99tYxwvEpjwB4x5X3xoAY6o24vkEMOPowB8u8z8hBTnnOVI6vuB kShTYcBjXw5XtoFYQzOXltQvSpwIIsv3FahsDIwxTTOL6n0r709uVXradPSZ/DRDbkd7 UkuQ== X-Gm-Message-State: AMke39nw/kKM2L7Rgq8qgMOuIwkHPQmFZlrBBFJRiluj5D9roAkNjLtdbD7fHh/UgPEX3g== X-Received: by 10.28.143.5 with SMTP id r5mr746703wmd.141.1486118311885; Fri, 03 Feb 2017 02:38:31 -0800 (PST) Received: from groucho.site (ipbcc0353e.dynamic.kabel-deutschland.de. [188.192.53.62]) by smtp.gmail.com with ESMTPSA id 186sm2278913wmw.24.2017.02.03.02.38.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Feb 2017 02:38:30 -0800 (PST) From: Ulrich Hecht To: linux-renesas-soc@vger.kernel.org, geert@linux-m68k.org, gregkh@linuxfoundation.org Cc: wsa@the-dreams.de, linux-serial@vger.kernel.org, magnus.damm@gmail.com, sergei.shtylyov@cogentembedded.com, Ulrich Hecht Subject: [PATCH v4 1/4] serial: sh-sci: increase RX FIFO trigger defaults for (H)SCIF Date: Fri, 3 Feb 2017 11:38:17 +0100 Message-Id: <1486118300-12633-2-git-send-email-ulrich.hecht+renesas@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1486118300-12633-1-git-send-email-ulrich.hecht+renesas@gmail.com> References: <1486118300-12633-1-git-send-email-ulrich.hecht+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sets reasonable trigger defaults for the various SCIF variants. Also corrects the FIFO size for SH7705-style ports. Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven --- drivers/tty/serial/sh-sci.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 050d028..520e344 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -148,6 +148,7 @@ struct sci_port { struct timer_list rx_timer; unsigned int rx_timeout; #endif + int rx_trigger; bool has_rtscts; bool autorts; @@ -450,7 +451,7 @@ static const struct sci_port_params sci_port_params[SCIx_NR_REGTYPES] = { [SCFCR] = { 0x18, 16 }, [SCFDR] = { 0x1c, 16 }, }, - .fifosize = 16, + .fifosize = 64, .overrun_reg = SCxSR, .overrun_mask = SCIFA_ORER, .sampling_rate_mask = SCI_SR(16), @@ -2062,6 +2063,7 @@ static void sci_reset(struct uart_port *port) { const struct plat_sci_reg *reg; unsigned int status; + struct sci_port *s = to_sci_port(port); do { status = serial_port_in(port, SCxSR); @@ -2081,6 +2083,9 @@ static void sci_reset(struct uart_port *port) status &= ~(SCLSR_TO | SCLSR_ORER); serial_port_out(port, SCLSR, status); } + + if (s->rx_trigger > 1) + scif_set_rtrg(port, s->rx_trigger); } static void sci_set_termios(struct uart_port *port, struct ktermios *termios, @@ -2615,6 +2620,28 @@ static int sci_init_single(struct platform_device *dev, if (unlikely(sci_port->params == NULL)) return -EINVAL; + switch (p->type) { + case PORT_SCIFB: + sci_port->rx_trigger = 48; + break; + case PORT_HSCIF: + sci_port->rx_trigger = 64; + break; + case PORT_SCIFA: + sci_port->rx_trigger = 32; + break; + case PORT_SCIF: + if (p->regtype == SCIx_SH7705_SCIF_REGTYPE) + /* RX triggering not implemented for this IP */ + sci_port->rx_trigger = 1; + else + sci_port->rx_trigger = 8; + break; + default: + sci_port->rx_trigger = 1; + break; + } + /* SCIFA on sh7723 and sh7724 need a custom sampling rate that doesn't * match the SoC datasheet, this should be investigated. Let platform * data override the sampling rate for now.