diff mbox

[PATCH/RFC,2/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

Message ID 1489150886-27862-3-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Yoshihiro Shimoda March 10, 2017, 1:01 p.m. UTC 
This patch sets hcd->phy from own phy context to avoid phy_get()
in usb_add_hcd(). Since hcd.c manage the phy only in usb_add_hcd()
and usb_remove_hcd(), there is difficult to manage the phy in
suspend/resume.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/usb/host/ohci-platform.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Yoshihiro Shimoda March 10, 2017, 1:05 p.m. UTC | #1 
> From: Yoshihiro Shimoda, Sent: Friday, March 10, 2017 10:01 PM

Oops, this subject should be ohci-platform, not ehci-platform...

Best regards,
Yoshihiro Shimoda
diff mbox

Patch

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 898b740..00cc841 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -185,6 +185,8 @@  static int ohci_platform_probe(struct platform_device *dev)
 				goto err_put_hcd;
 			}
 		}
+		/* Avoiding phy_get in usb_add_hcd() */
+		hcd->phy = priv->phys[0];
 
 		for (clk = 0; clk < OHCI_MAX_CLKS; clk++) {
 			priv->clks[clk] = of_clk_get(dev->dev.of_node, clk);