Message ID | 1496420523-23506-4-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Simon Horman |
Headers | show |
Hi Biju, On Fri, Jun 2, 2017 at 6:22 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Add support for iWave RZG1M Qseven System On Module. > http://www.iwavesystems.com/rz-g1m-qseven-module.html Thanks for your patch! > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > --- /dev/null > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > @@ -0,0 +1,27 @@ > +/* > + * Device Tree Source for the iWave-RZG1M-20M Qseven SOM > + * > + * Copyright (C) 2017 Renesas Electronics Corp. > + * > + * This file is licensed under the terms of the GNU General Public License > + * version 2. This program is licensed "as is" without any warranty of any > + * kind, whether express or implied. > + */ > + > +#include "r8a7743.dtsi" > + > +/ { Given this is a sub-board with many other components, I think it should have its own (documented) compatible value, e.g. compatible = "iwave,g20m", "renesas,r8a7743"; > + memory@40000000 { > + device_type = "memory"; > + reg = <0 0x40000000 0 0x20000000>; > + }; > + > + memory@200000000 { > + device_type = "memory"; > + reg = <2 0x00000000 0 0x20000000>; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> On Fri, Jun 2, 2017 at 6:22 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add support for iWave RZG1M Qseven System On Module. > > http://www.iwavesystems.com/rz-g1m-qseven-module.html > > Thanks for your patch! > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > > --- /dev/null > > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > @@ -0,0 +1,27 @@ > > +/* > > + * Device Tree Source for the iWave-RZG1M-20M Qseven SOM > > + * > > + * Copyright (C) 2017 Renesas Electronics Corp. > > + * > > + * This file is licensed under the terms of the GNU General Public > > +License > > + * version 2. This program is licensed "as is" without any warranty > > +of any > > + * kind, whether express or implied. > > + */ > > + > > +#include "r8a7743.dtsi" > > + > > +/ { > > Given this is a sub-board with many other components, I think it should have > its own (documented) compatible value, e.g. > > compatible = "iwave,g20m", "renesas,r8a7743"; Thanks for the input. I will document this system on module and apply the above change. > > + memory@40000000 { > > + device_type = "memory"; > > + reg = <0 0x40000000 0 0x20000000>; > > + }; > > + > > + memory@200000000 { > > + device_type = "memory"; > > + reg = <2 0x00000000 0 0x20000000>; > > + }; > > +}; > [>] Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello, This series aims to add iWave RZ/G1M R8A7743 based Qseven SOM and RainboW-G20D- Qseven board support. This series has been tested against linux-next tag next-20170606. Modifications: v1->v2 -Documented iWave iW-RainboW-G20M-Qseven-RZG1M system on module -Documented iW-RainboW-G20D-Qseven-RZG1M board in alphabatical order -Added compatible string in iWave RZG1M Qseven SOM -Modified the compatible string in iWave G20D-Q7 board History: ------- [v1]: http://www.spinics.net/lists/devicetree/msg179565.html Biju Das (5): of: Add vendor prefix for iWave Systems Technologies Pvt. Ltd ARM: shmobile: document iW-RainboW-G20M-Qseven-RZG1M system on module ARM: shmobile: document iW-RainboW-G20D-Qseven-RZG1M board ARM: dts: iwg20m: Add iWave RZG1M Qseven SOM ARM: dts: iwg20d-q7: Add support for iWave G20D-Q7 board based on RZ/G1M Documentation/devicetree/bindings/arm/shmobile.txt | 4 +++ .../devicetree/bindings/vendor-prefixes.txt | 1 + arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 25 +++++++++++++++++++ arch/arm/boot/dts/r8a7743-iwg20m.dtsi | 29 ++++++++++++++++++++++ 5 files changed, 60 insertions(+) create mode 100644 arch/arm/boot/dts/r8a7743-iwg20d-q7.dts create mode 100644 arch/arm/boot/dts/r8a7743-iwg20m.dtsi
On Tue, Jun 06, 2017 at 04:10:13PM +0100, Biju Das wrote: > Hello, > > This series aims to add iWave RZ/G1M R8A7743 based Qseven SOM and RainboW-G20D- Qseven board support. > > This series has been tested against linux-next tag next-20170606. > > Modifications: > v1->v2 > -Documented iWave iW-RainboW-G20M-Qseven-RZG1M system on module > -Documented iW-RainboW-G20D-Qseven-RZG1M board in alphabatical order > -Added compatible string in iWave RZG1M Qseven SOM > -Modified the compatible string in iWave G20D-Q7 board > > History: > ------- > [v1]: http://www.spinics.net/lists/devicetree/msg179565.html > > Biju Das (5): > of: Add vendor prefix for iWave Systems Technologies Pvt. Ltd > ARM: shmobile: document iW-RainboW-G20M-Qseven-RZG1M system on module > ARM: shmobile: document iW-RainboW-G20D-Qseven-RZG1M board > ARM: dts: iwg20m: Add iWave RZG1M Qseven SOM > ARM: dts: iwg20d-q7: Add support for iWave G20D-Q7 board based on > RZ/G1M > > Documentation/devicetree/bindings/arm/shmobile.txt | 4 +++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 25 +++++++++++++++++++ > arch/arm/boot/dts/r8a7743-iwg20m.dtsi | 29 ++++++++++++++++++++++ > 5 files changed, 60 insertions(+) > create mode 100644 arch/arm/boot/dts/r8a7743-iwg20d-q7.dts > create mode 100644 arch/arm/boot/dts/r8a7743-iwg20m.dtsi Thanks, I have queued these up after moving the Makefile change from the 2nd to last to the last patch. They should appear in the next and devel branches of the renesas tree later today.
diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi new file mode 100644 index 0000000..d7bdf5d --- /dev/null +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi @@ -0,0 +1,27 @@ +/* + * Device Tree Source for the iWave-RZG1M-20M Qseven SOM + * + * Copyright (C) 2017 Renesas Electronics Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +#include "r8a7743.dtsi" + +/ { + memory@40000000 { + device_type = "memory"; + reg = <0 0x40000000 0 0x20000000>; + }; + + memory@200000000 { + device_type = "memory"; + reg = <2 0x00000000 0 0x20000000>; + }; +}; + +&extal_clk { + clock-frequency = <20000000>; +};