| Message ID | 1498055229-42052-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Wed, Jun 21, 2017 at 4:27 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2 > family. Add support for its GPIO controllers. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Although I think the time has come for family-specific compatible values for R-Car Gen2 and Gen3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Jun 26, 2017 at 10:13:00AM +0200, Geert Uytterhoeven wrote: > On Wed, Jun 21, 2017 at 4:27 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2 > > family. Add support for its GPIO controllers. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Although I think the time has come for family-specific compatible values > for R-Car Gen2 and Gen3. Yes, agreed.
On Wed, Jun 21, 2017 at 03:27:09PM +0100, Biju Das wrote: > Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2 > family. Add support for its GPIO controllers. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > --- > v1->v2 > * Modified the text "RZ-G1M" to "RZ/G1M" > > Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 + > drivers/gpio/gpio-rcar.c | 4 ++++ > 2 files changed, 5 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
On Wed, Jun 21, 2017 at 4:27 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2 > family. Add support for its GPIO controllers. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > --- > v1->v2 > * Modified the text "RZ-G1M" to "RZ/G1M" Patch applied with the ACKs. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt index 7c1ab3b..6826a37 100644 --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt @@ -3,6 +3,7 @@ Required Properties: - compatible: should contain one of the following. + - "renesas,gpio-r8a7743": for R8A7743 (RZ/G1M) compatible GPIO controller. - "renesas,gpio-r8a7778": for R8A7778 (R-Mobile M1) compatible GPIO controller. - "renesas,gpio-r8a7779": for R8A7779 (R-Car H1) compatible GPIO controller. - "renesas,gpio-r8a7790": for R8A7790 (R-Car H2) compatible GPIO controller. diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 31ad288..4a1536a 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -344,6 +344,10 @@ struct gpio_rcar_info { static const struct of_device_id gpio_rcar_of_table[] = { { + .compatible = "renesas,gpio-r8a7743", + /* RZ/G1 GPIO is identical to R-Car Gen2. */ + .data = &gpio_rcar_info_gen2, + }, { .compatible = "renesas,gpio-r8a7790", .data = &gpio_rcar_info_gen2, }, {